From patchwork Thu Nov 15 06:24:21 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kachhap X-Patchwork-Id: 1747061 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id D99D33FCA5 for ; Thu, 15 Nov 2012 06:24:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751556Ab2KOGYX (ORCPT ); Thu, 15 Nov 2012 01:24:23 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:55948 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751345Ab2KOGYW (ORCPT ); Thu, 15 Nov 2012 01:24:22 -0500 Received: by mail-oa0-f46.google.com with SMTP id h16so1342113oag.19 for ; Wed, 14 Nov 2012 22:24:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:x-gm-message-state; bh=4YFzmJNppo0GJXdgID1EAD5x8mzpPQxcdeOBadUDnbo=; b=GJGNoVaXWifA0EgGRsJ2KGu1yxb110/2miaWJPVGD+MWPP2rshMLe30/SbHOTMCq66 epgfYF3Dkt3rwjsY0t6UQ0vevqXSRRVb8TBLyiWlFmgkmkI82Igcf6nUEZZ0gbOA8l1z Bu0l5Dc3ojvDLNAyxn5zQLgQGIW1YeRFzq+dkH9ZbSz/6aB9mFgpy58E9ZXET1nWVJC0 Pm9g4ldEJrYlm0i8EiClS2y2dJ5bQuZZmNLDdtj8OM+kzFUDDK+Gifbxs2Ep3inwZLXP zhA0vA2xEQYGTaf1XD3Ju7MrruGbIlZsf+h/z8ag2XTUJ3utyNAaHYthhF2/M4+BaYZL B69w== MIME-Version: 1.0 Received: by 10.182.177.7 with SMTP id cm7mr116338obc.20.1352960662042; Wed, 14 Nov 2012 22:24:22 -0800 (PST) Received: by 10.76.85.105 with HTTP; Wed, 14 Nov 2012 22:24:21 -0800 (PST) In-Reply-To: <1352938284.2143.5.camel@rzhang1-mobl4> References: <1352875704-2178-1-git-send-email-sachin.kamat@linaro.org> <1352938284.2143.5.camel@rzhang1-mobl4> Date: Thu, 15 Nov 2012 11:54:21 +0530 Message-ID: Subject: Re: [PATCH 1/1] thermal: Exynos: Add missing dependency From: Amit Kachhap To: linux-pm@vger.kernel.org, Sachin Kamat Cc: durgadoss.r@intel.com, patches@linaro.org, akpm@linux-foundation.org X-Gm-Message-State: ALoCoQk7Rt4E1GhnaCjDwV9V664N3t+NPQdYrLsHE3a39WRjW+DfF2tSK7mRcCnWJfnGGOVOgKN2 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 15 November 2012 05:41, Zhang Rui wrote: > Hi, Sachin, > > thanks for catching the problem. > > On Wed, 2012-11-14 at 12:18 +0530, Sachin Kamat wrote: >> CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without checking >> for dependencies gives the following compilation warnings: >> warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC && UX500_SOC_DB8500 && >> CPU_THERMAL && EXYNOS_THERMAL) selects CPU_FREQ_TABLE which has unmet >> direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ) >> > Amit, > > how is exynos driver supposed to work? > do you want the exynos driver still be loaded without CPU_THERMAL? > If yes, EXYNOS_THERMAL should not select CPU_FREQ_TABLE. > If no, EXYNOS_THERMAL should depends on CPU_THERMAL instead of THERMAL. > and CPU_THERMAL will select CPU_FREQ_TABLE instead. > > IMO, either of the above solution will be more proper to fix this > warning. Yes Rui, Currently exynos driver has dependency on CPU_THERMAL. There is some code-refactoring work needed to remove this dependency. As of now to fix the warning following changes may be sufficient. Thanks, Amit Daniel > > thanks, > rui > >> Cc: Amit Daniel Kachhap >> Signed-off-by: Sachin Kamat >> --- >> Build tested using exynos4_defconfig on linux-next tree of 20121114. >> --- >> drivers/thermal/Kconfig | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig >> index 266c15e..197b7db 100644 >> --- a/drivers/thermal/Kconfig >> +++ b/drivers/thermal/Kconfig >> @@ -50,7 +50,7 @@ config RCAR_THERMAL >> >> config EXYNOS_THERMAL >> tristate "Temperature sensor on Samsung EXYNOS" >> - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL >> + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL && CPU_FREQ >> select CPU_FREQ_TABLE >> help >> If you say yes here you get support for TMU (Thermal Managment > > --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -50,7 +50,8 @@ config RCAR_THERMAL config EXYNOS_THERMAL tristate "Temperature sensor on Samsung EXYNOS" - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL + depends on THERMAL + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && CPU_THERMAL select CPU_FREQ_TABLE help If you say yes here you get support for TMU (Thermal Managment