From patchwork Wed Feb 6 09:58:34 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 2102911 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id B1E643FDF1 for ; Wed, 6 Feb 2013 09:58:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754908Ab3BFJ6g (ORCPT ); Wed, 6 Feb 2013 04:58:36 -0500 Received: from mail-qc0-f177.google.com ([209.85.216.177]:61131 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754612Ab3BFJ6f (ORCPT ); Wed, 6 Feb 2013 04:58:35 -0500 Received: by mail-qc0-f177.google.com with SMTP id u28so436902qcs.8 for ; Wed, 06 Feb 2013 01:58:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=C4gFKc4gnFmGsvHZB8OvP9SbrgZxNlcx34hqN/4WPF0=; b=HxAGPyoIKtib4nLo4NNIQdDRtTV9MEYaOY8muiFKsyN5V8pa9MBe3bBjBQqqbOAnXp ZyB0cLe5+CDL6qP5RqkoXlX3Vr7xkVyIjGF0DsfmhD3hqX4xHSBbie9QE3sBFOconZDn 9EjyeLXWPFxA0n/JdVL5eTXzqFtkT1FafJ6XdWkIeGGn1zaa+QJvyW4Gb+uICnPG6rcX TitYt1+Iqu3lN6BiT33bhRRbNM+sT5j1ltrLlAhlFIM5Q/Q4vKSK07q/ckX5zSsChXEM UUBEz4zdUD9rZekdP/kXfKLTff9j6h1OTgaOj86xZInDO8Fbv1Q7PQqbt9QWrhV79eW8 7IYg== MIME-Version: 1.0 X-Received: by 10.49.127.180 with SMTP id nh20mr24893303qeb.19.1360144714714; Wed, 06 Feb 2013 01:58:34 -0800 (PST) Received: by 10.49.130.100 with HTTP; Wed, 6 Feb 2013 01:58:34 -0800 (PST) In-Reply-To: References: Date: Wed, 6 Feb 2013 15:28:34 +0530 Message-ID: Subject: Re: [PATCH 0/4] CPUFreq: Implement per policy instances of governors From: Viresh Kumar To: rjw@sisk.pl, Borislav Petkov Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, Viresh Kumar , Charles Garcia-Tobin X-Gm-Message-State: ALoCoQm64PryYAXRnBLrrNEEy+joh9yKKtXjeJAb2By9+C2U99bR1iBYnnafSCKzBfOkcENIMMvf Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 5 February 2013 21:51, Viresh Kumar wrote: > commit 15b5548c9ccfb8088270f7574710d9d67edfe33b > Author: Viresh Kumar > Date: Tue Feb 5 21:29:05 2013 +0530 > > cpufreq: Make governors directory sysfs location based on > have_multiple_policies > > Until now directory for governors tunables was getting created in > cpu/cpufreq/. With the introduction of following patch: > "cpufreq: governor: Implement per policy instances of governors" > > this directory would be created in > cpu/cpu/cpufreq/. This might > break userspace of existing platforms. Lets do this change only > for platforms > which need support for multiple policies and thus above mentioned patch. > > From now on, such platforms would be require to do following from > their init() > routines: > > policy->have_multiple_policies = true; > > Signed-off-by: Viresh Kumar > --- > drivers/cpufreq/cpufreq_governor.c | 2 +- > include/linux/cpufreq.h | 14 ++++++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) Hi Rafael, Because this patch was quite big (317 insertions(+), 238 deletions(-)), i was planning a detailed self review to capture any mistakes and luckily i found one for above patch :) I have pushed the complete patchset here: http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/cpufreq-updates --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index 41ee86f..fe037c0 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -342,7 +342,8 @@ int cpufreq_governor_dbs(struct cpufreq_policy *policy, mutex_lock(&dbs_data->mutex); mutex_destroy(&cpu_cdbs->timer_mutex); - sysfs_remove_group(&policy->kobj, dbs_data->cdata->attr_group); + sysfs_remove_group(get_governor_parent_kobj(policy), + dbs_data->cdata->attr_group); if (dbs_data->cdata->governor == GOV_CONSERVATIVE) cpufreq_unregister_notifier(cs_ops->notifier_block, CPUFREQ_TRANSITION_NOTIFIER);