From patchwork Fri Feb 22 02:31:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 2174291 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id F24DB3FD4E for ; Fri, 22 Feb 2013 02:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756693Ab3BVCbL (ORCPT ); Thu, 21 Feb 2013 21:31:11 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:48693 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756585Ab3BVCbC (ORCPT ); Thu, 21 Feb 2013 21:31:02 -0500 Received: by mail-oa0-f46.google.com with SMTP id k1so179133oag.19 for ; Thu, 21 Feb 2013 18:31:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=KoeT/DJzWsJ0rsjk4vsquTRm6hsNV53oNzHRZ2YuuXI=; b=J+sG2xnWODfF6YfI1fSrxDyybdyWcTZFjj6d8BhADk+6RFJ5od/csURx6lzhYJsohH 3iKrJmuODZUEJHUdOl7tY7XXC0r7kKA15l5sDTSc085hMJAfFLFMhtcVV4qydisnge76 UkCJwgF3F5k7SL1TFSi2fsaGF91Lfv80YE+x1azywM2Qz5qM2MqZe9VVxo4uEVE/Uzsn 1Ro36ulw5ID8wjLMgP0o/DuiWHPRhfR1HDNaC4GXlM5rn2RHZbBP6V7FEuMwclcDpQWs ldD+GD1+EzV2vFmMNrvnhD5Qzu9RCXI/XNMcTxEWTJ1ulAaJcr55BbaI+m34hLMOTxqj qJbg== MIME-Version: 1.0 X-Received: by 10.60.5.231 with SMTP id v7mr120022oev.62.1361500260693; Thu, 21 Feb 2013 18:31:00 -0800 (PST) Received: by 10.182.69.20 with HTTP; Thu, 21 Feb 2013 18:31:00 -0800 (PST) In-Reply-To: <3793606.bilcxohA80@vostro.rjw.lan> References: <3793606.bilcxohA80@vostro.rjw.lan> Date: Fri, 22 Feb 2013 08:01:00 +0530 Message-ID: Subject: Re: [PATCH V2 1/4] cpufreq: Add per policy governor-init/exit infrastructure From: Viresh Kumar To: "Rafael J. Wysocki" Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, linaro-dev@lists.linaro.org, francescolavra.fl@gmail.com, toddpoynor@google.com X-Gm-Message-State: ALoCoQmNAjBiGxHrftISK2bzSLH9WifUEFnkGK3jNUZkuJqu5CwJQfk97iBRSdczTdN01Rry9EF2 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 22 February 2013 05:05, Rafael J. Wysocki wrote: > Why don't you use different values here? > > If you need only one value, one #define should be sufficient. This is the fixup i have for this, I will push all patches again to cpufreq-for-3.10 branch: ---------------------------------------------- commit 4d7296fb64f2353aafad5104f0a046466d0f4ea9 Author: Viresh Kumar Date: Fri Feb 22 07:56:31 2013 +0530 fixup! cpufreq: Add per policy governor-init/exit infrastructure --- include/linux/cpufreq.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) char name[CPUFREQ_NAME_LEN]; -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 3b822ce..b7393b5 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -183,7 +183,7 @@ static inline unsigned long cpufreq_scale(unsigned long old, u_int div, u_int mu #define CPUFREQ_GOV_STOP 2 #define CPUFREQ_GOV_LIMITS 3 #define CPUFREQ_GOV_POLICY_INIT 4 -#define CPUFREQ_GOV_POLICY_EXIT 4 +#define CPUFREQ_GOV_POLICY_EXIT 5 struct cpufreq_governor {