From patchwork Thu Mar 7 17:04:51 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 2233141 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id B74883FC8F for ; Thu, 7 Mar 2013 17:04:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759150Ab3CGREw (ORCPT ); Thu, 7 Mar 2013 12:04:52 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:54789 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758823Ab3CGREv (ORCPT ); Thu, 7 Mar 2013 12:04:51 -0500 Received: by mail-ob0-f177.google.com with SMTP id eh20so523245obb.8 for ; Thu, 07 Mar 2013 09:04:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=JrXLOdkgRE9+cSZzGmOf4wrJNaZwBJjyymUy8+1bUx4=; b=N4rI13vnF+T3hkjMbSj65pmTJMyHBKDBsGlnwYye8P+yrPvp7/HoYxKJ5CQyZzrYKb 7xnSagxadLgLR7UbHaiZu5BS/vglnXQKjyfumnC/6lTLKALxY+5vQBr0b6EMZhqHNex/ XT+RRCCK+BaHmXTwNYIeMnAJbu6hWr5jrpF8b3hG+94SvIJc7kIwR9Fd6ZOUYY7f8jdL RqzLalKZ0uiZI8OS7LyBnug3Z4P5P06hREBMt0omoFuvlbyYsagJb0kC4y61IlPl64mg LQRwDp3AFFEkO6FQJe0EyN40HnxDGUavD5S0Gd+60C76lTUiR4Xgj6oDASaDQlUtDY+D mAxA== MIME-Version: 1.0 X-Received: by 10.182.118.42 with SMTP id kj10mr26174527obb.99.1362675891321; Thu, 07 Mar 2013 09:04:51 -0800 (PST) Received: by 10.182.69.20 with HTTP; Thu, 7 Mar 2013 09:04:51 -0800 (PST) In-Reply-To: <20130307114950.GF17833@n2100.arm.linux.org.uk> References: <20130305105251.GL17833@n2100.arm.linux.org.uk> <20130307005119.GY17833@n2100.arm.linux.org.uk> <20130307114950.GF17833@n2100.arm.linux.org.uk> Date: Fri, 8 Mar 2013 01:04:51 +0800 Message-ID: Subject: Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue From: Viresh Kumar To: Russell King - ARM Linux Cc: rjw@sisk.pl, Steve.Bannister@arm.com, linux-pm@vger.kernel.org, Sudeep KarkadaNagesha , Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, robin.randhawa@arm.com, linux-arm-kernel@lists.infradead.org, mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org, charles.garcia-tobin@arm.com X-Gm-Message-State: ALoCoQlPjSVMEI+7eWlCq5X6p6WliDvjNDF5IDZjXGQ2ZDRcRFBt+ZFSwTDP/x3hRfoWfaObTFj5 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 7 March 2013 19:49, Russell King - ARM Linux wrote: > So how is this different from any other clock which may also return zero > from its clk_get_rate() ? > > If that's the condition you want to check for, call clk_get_rate() after > a successful clk_get*() and check for the condition. Don't go treating > the cookie somehow specially. You're *assuming* a behaviour that is > inappropriate for the side of the interface you're working with. Okay. I will replace the earlier fixup with following: For more clarity i will resend this patch now will all updates. --- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index fdf54a9..87b7e48 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -9,8 +9,7 @@ config ARM_BIG_LITTLE_CPUFREQ config ARM_DT_BL_CPUFREQ tristate "Generic ARM big LITTLE CPUfreq driver probed via DT" select ARM_BIG_LITTLE_CPUFREQ - depends on OF - default n + depends on OF && HAVE_CLK help This enables the Generic CPUfreq driver for ARM big.LITTLE platform. This gets frequency tables from DT. diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c index 2486b9a..a41fd89 100644 --- a/drivers/cpufreq/arm_big_little.c +++ b/drivers/cpufreq/arm_big_little.c @@ -147,7 +147,7 @@ static void put_cluster_clk_and_freq_table(u32 cluster) static int get_cluster_clk_and_freq_table(u32 cluster) { - char name[9] = "cluster"; + char name[9] = "cpu-cluster"; int count; if (atomic_inc_return(&cluster_usage[cluster]) != 1)