From patchwork Mon Mar 11 00:57:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 2246131 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 0256A40AFD for ; Mon, 11 Mar 2013 00:58:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753660Ab3CKA56 (ORCPT ); Sun, 10 Mar 2013 20:57:58 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:65202 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753600Ab3CKA5x (ORCPT ); Sun, 10 Mar 2013 20:57:53 -0400 Received: by mail-ob0-f174.google.com with SMTP id 16so2846127obc.33 for ; Sun, 10 Mar 2013 17:57:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=CATx2lciI0BohIdGold6AcbBllzGTrfB9eJvQ35z2VM=; b=KfH7ypH1TvXfeMqHbPGNZd8pDmCD+bt5GfV4Uk2X4/4C5ldJ8U6PUQlErxIwJVpSTa 19j0Fb/H4JNv6TekxHZx/Un9GfklNeYzoknhp9Y1l7Ts6pduWhgRr75+9rr2UdJeGhbd d5qiL8xbTK3uu5whH+op/fLDATsTbmgLzaeuBsRdFmLcikgfAQQ78Mkqs/caNjUWG644 2dOewDQS/agICg544yg4eZBtJccV7LihwHRGasrdWgZv+yOVa4JP8hSwwZLV9dp0sdPi tl/CKTnsy5EsQWSYi7jm6wo7CP3FFp68k2KIXdOVVRRpKQutDjIesHGf8lq0YZiw9jfd Spng== MIME-Version: 1.0 X-Received: by 10.182.8.70 with SMTP id p6mr7075487oba.90.1362963470192; Sun, 10 Mar 2013 17:57:50 -0700 (PDT) Received: by 10.182.69.20 with HTTP; Sun, 10 Mar 2013 17:57:49 -0700 (PDT) In-Reply-To: <513CAD9B.908@gmail.com> References: <6cba8f153cfd4b0d3075a34a6dfe287bdec2eb06.1362676407.git.viresh.kumar@linaro.org> <513CAD9B.908@gmail.com> Date: Mon, 11 Mar 2013 08:57:49 +0800 Message-ID: Subject: Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue From: Viresh Kumar To: Francesco Lavra Cc: rjw@sisk.pl, Steve.Bannister@arm.com, linux@arm.linux.org.uk, linux-pm@vger.kernel.org, Sudeep KarkadaNagesha , devicetree-discuss@lists.ozlabs.org, Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, robin.randhawa@arm.com, linux-arm-kernel@lists.infradead.org, mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org, charles.garcia-tobin@arm.com X-Gm-Message-State: ALoCoQmi/3VuukVMejIYwV9YUe8nYs+56IJ6GLWFXoFOAzz2qfNIlty/Cpr/HEe9sfnhO2Lvwlbi Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 10 March 2013 23:58, Francesco Lavra wrote: > On 03/07/2013 06:14 PM, Viresh Kumar wrote: >> +void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) >> +{ >> + if (arm_bL_ops != ops) { >> + pr_info("%s: Registered with: %s, can't unregister, exiting\n", >> + __func__, arm_bL_ops->name); >> + } > > The code is not doing what the info message says. Yes, following is the improvement: More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c index 8b8b07e..9d449cf 100644 --- a/drivers/cpufreq/arm_big_little.c +++ b/drivers/cpufreq/arm_big_little.c @@ -264,8 +264,9 @@ EXPORT_SYMBOL_GPL(bL_cpufreq_register); void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) { if (arm_bL_ops != ops) { - pr_info("%s: Registered with: %s, can't unregister, exiting\n", + pr_err("%s: Registered with: %s, can't unregister, exiting\n", __func__, arm_bL_ops->name); + return; } -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org