From patchwork Wed Feb 17 19:53:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anand Moon X-Patchwork-Id: 8342871 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E1DD9C0553 for ; Wed, 17 Feb 2016 19:53:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF87D203A5 for ; Wed, 17 Feb 2016 19:53:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BCFA3203A0 for ; Wed, 17 Feb 2016 19:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030294AbcBQTxh (ORCPT ); Wed, 17 Feb 2016 14:53:37 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:36657 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964976AbcBQTxg (ORCPT ); Wed, 17 Feb 2016 14:53:36 -0500 Received: by mail-wm0-f45.google.com with SMTP id g62so178093258wme.1; Wed, 17 Feb 2016 11:53:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=vtPr5C6nUV/GiyCoX+DrQJjszZKQVgLzBcg16kUeLjg=; b=kMumWSQXGMzs8FWlc/25JlIovzC9n9uy3DrNXKDQIpk70nuBIOf/snWLcfILImqjN1 NL4weAwjD/hc2Y2R3kALT5zTJiTGL2KsP/It9LMNw/YfBcwwLHUMdUYm9RLe8P0CpOdl foOPiAEt3IMLjpskeRTCuAoxvIZ2B/txcgua2K3yt+dvLy+0UzuST2ePAnv/ma6XtJ3t ol46Z+9MZZlSV9gD5IHX1MDuO0zWsIv3oZIamjLkT1KVuXpNpOUWwMZR7952xPnPLZaW /RGGOw/uYULOF8k2ZOaCRm8a469WekxE8MaYQp/4d7iM0qdCjOIHbaa9jzLNj2YwLQgS dYQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=vtPr5C6nUV/GiyCoX+DrQJjszZKQVgLzBcg16kUeLjg=; b=MnP8amox4bEbBvED3DAFi/cxctKF24YXNrcMX+i8SkuG4fMEaXmR6RRRD4x7ozbw2Q xQ+PHyyHptvSKnfTn3RFG57eXn+VRh5BROGUeeL9LPtdF88p66MhF/ASVVZgH6nQaXc/ AolMA5WKFfp21VXymRLIPRMkVojC4YgenI3vjbl26CKM1S6VaxBAHewfZUW9mRs9wdbw bSJW/bMbvFK0WdsAaltQ7lf8Jwl7gD/ixWUf1q10VIAXHUNUTLdJjEW5w+HG///2K+GP jhZiSwj3mKnaIEdQoKtDoJSNakVXilC5K7GfHevddLYtuLS9/+XuHj4fa6Lvxt+2q6R6 cJwA== X-Gm-Message-State: AG10YOQ9KDiqq5EncjSG5YUe6Bzc1bF/C9dMjIJfDkjJgm+TPqsORRyyfa1gEvBVox+2s+IFGW5UehVGkmf2qQ== X-Received: by 10.28.88.15 with SMTP id m15mr26302021wmb.60.1455738814435; Wed, 17 Feb 2016 11:53:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.28.188.87 with HTTP; Wed, 17 Feb 2016 11:53:14 -0800 (PST) In-Reply-To: <1455692128-28504-4-git-send-email-k.kozlowski@samsung.com> References: <1455692128-28504-1-git-send-email-k.kozlowski@samsung.com> <1455692128-28504-4-git-send-email-k.kozlowski@samsung.com> From: Anand Moon Date: Thu, 18 Feb 2016 01:23:14 +0530 Message-ID: Subject: Re: [RFC 3/3] ARM: dts: Don't overheat the Odroid XU3-Lite on high load To: Krzysztof Kozlowski Cc: Kukjin Kim , Lukasz Majewski , linux-arm-kernel@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Linux PM list , Zhang Rui , Eduardo Valentin , Viresh Kumar , Bartlomiej Zolnierkiewicz , Javier Martinez Canillas Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Krzysztof, On 17 February 2016 at 12:25, Krzysztof Kozlowski wrote: > After adding cpufreq-dt support to Exynos542x, the Odroid XU3-Lite can > be easily overheated when launching eight CPU-intensive tasks: > thermal thermal_zone3: critical temperature reached(121 C),shutting down > > This seems to be specific to Odroid XU3-Lite board which officially > supports lower frequencies than regular XU3 or XU4. When working at > maximum CPU speed (1800 MHz big and 1300 MHz LITTLE) in warmer place for > longer time, the fan fails to cool down the board and it reaches > critical temperature. > > Add CPU cooling to Exynos5422/5800 to fix this issue. When reaching 95 > degrees of Celsius, the board will slow down by 3 steps (around > 1400/1000 MHz). When reaching 110 degrees of Celsius go to 600 MHz. > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi | 41 +++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi b/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi > index 2b289d7c0d13..66073ce29aee 100644 > --- a/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi > +++ b/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi > @@ -34,6 +34,16 @@ > hysteresis = <5000>; /* millicelsius */ > type = "active"; > }; > + cpu_alert3: cpu-alert-3 { > + temperature = <95000>; /* millicelsius */ > + hysteresis = <5000>; /* millicelsius */ > + type = "passive"; > + }; > + cpu_alert4: cpu-alert-4 { > + temperature = <110000>; /* millicelsius */ > + hysteresis = <5000>; /* millicelsius */ > + type = "passive"; > + }; > cpu_crit0: cpu-crit-0 { > temperature = <120000>; /* millicelsius */ > hysteresis = <0>; /* millicelsius */ > @@ -53,6 +63,37 @@ > trip = <&cpu_alert2>; > cooling-device = <&fan0 2 3>; > }; > + > + /* > + * When reaching cpu_alert3, reduce CPU > + * by 3 steps. On Exynos5422/5800 that would > + * be: 1400 MHz and 1000 MHz. > + */ > + map3 { > + trip = <&cpu_alert3>; > + cooling-device = <&cpu0 3 3>; > + }; > + map4 { > + trip = <&cpu_alert3>; > + cooling-device = <&cpu4 3 3>; > + }; > + > + /* > + * When reaching cpu_alert4, reduce CPU > + * to 600 MHz (11 steps for big, 7 steps for > + * LITTLE). > + * Exynos5420 has less OPPs and reversed > + * numbering of CPUs (big/LITTLE) so this > + * would not match. > + */ > + map5 { > + trip = <&cpu_alert4>; > + cooling-device = <&cpu0 7 7>; > + }; > + map6 { > + trip = <&cpu_alert4>; > + cooling-device = <&cpu4 11 11>; > + }; > }; > }; > }; > -- > 2.5.0 > could you append this patch with following changes. millicelsius */ --- On running linaro pm-qa diagnostic tool ---------------------------------------------------------- thermal_01.28: checking 'thermal_zone2'/'trip_point_2_temp' ='110000'... Ok thermal_01.29: checking 'cdev0_trip_point' exists in '/sys/devices/virtual/thermal/thermal_zone0'... Ok thermal_01.30: checking 'thermal_zone0/cdev0_trip_point' valid binding... Ok thermal_01.31: checking 'cdev4_trip_point' exists in '/sys/devices/virtual/thermal/thermal_zone0'... Ok thermal_01.32: checking 'thermal_zone0/cdev4_trip_point' valid binding... Err thermal_01.33: checking 'cdev4_trip_point' exists in '/sys/devices/virtual/thermal/thermal_zone0'... Ok thermal_01.34: checking 'thermal_zone0/cdev4_trip_point' valid binding... Err thermal_01.35: checking 'cdev4_trip_point' exists in '/sys/devices/virtual/thermal/thermal_zone0'... Ok thermal_01.36: checking 'thermal_zone0/cdev4_trip_point' valid binding... Err thermal_01.37: checking 'cdev4_trip_point' exists in '/sys/devices/virtual/thermal/thermal_zone0'... Ok thermal_01.38: checking 'thermal_zone0/cdev4_trip_point' valid binding... Err thermal_01: fail ------------------------------------------------------- I also got lot's of error. root@odroidxu4l:~# cpu[ 3050.847663] cpu cpu4: Failed to find dev_opp: -19 [ 3171.640836] cpu cpu4: device_opp_debug_create_link: Failed to create link [ 3171.646197] cpu cpu4: _add_list_dev: Failed to register opp debugfs (-12) [ 3171.653574] cpu cpu7: device_opp_debug_create_link: Failed to create link [ 3171.659752] cpu cpu7: _add_list_dev: Failed to register opp debugfs (-12) [ 3171.697011] cpu cpu5: cpufreq_init: failed to get clk: -2 [ 3171.732505] cpu cpu6: cpufreq_init: failed to get clk: -2 [ 3171.768160] cpu cpu7: cpufreq_init: failed to get clk: -2 Tested on Odroid-XU4 Reviewed-by: Anand Moon Tested-by: Anand Moon Best Regards -Anand Moon > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi b/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi index 66073ce..4e72637 100644 --- a/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi +++ b/arch/arm/boot/dts/exynos5422-cpu-thermal.dtsi @@ -16,8 +16,8 @@ thermal-zones { cpu0_thermal: cpu0-thermal { thermal-sensors = <&tmu_cpu0 0>; - polling-delay-passive = <0>; - polling-delay = <0>; + polling-delay-passive = <250>; /* milliseconds */ + polling-delay = <500>; /* milliseconds */ trips { cpu_alert0: cpu-alert-0 { temperature = <50000>; /*