| Message ID | CAOh2x=mjTX3hM0uxJh9qk=9OUWqZaAjAV57r2H4AgH+ZjY+eCg@mail.gmail.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, 07 Feb 2013 13:11:52 +0530, Viresh Kumar said: > First of all i want to confirm something about your system. I am sure it is a > multi-policy system (or multi cluster system). i.e. there are more than one > clock line for different cpus ? And so multiple struct policy exist > simultaneously. Hmm.. it's a bog-standard Dell Latitude E6500 laptop, with a single Core2 Duo P8700 CPU (one die, 2 cores, no HT). It's apparently able to clock both cores at different speeds (one core running busy at 2540mhz and the other idling at 800mhz), if that's what you mean by multiple clock lines. In any case, next-20130206 complained, and with this patch added I see nothing in dmesg and cpufreq is acting properly on both cores, so: Tested-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> (btw - I had to hand-apply your patch, as it showed up white-space damaged. Three lines wrapped, and tabs converted to spaces).
On 8 February 2013 00:48, <Valdis.Kletnieks@vt.edu> wrote: > On Thu, 07 Feb 2013 13:11:52 +0530, Viresh Kumar said: > >> First of all i want to confirm something about your system. I am sure it is a >> multi-policy system (or multi cluster system). i.e. there are more than one >> clock line for different cpus ? And so multiple struct policy exist >> simultaneously. > > Hmm.. it's a bog-standard Dell Latitude E6500 laptop, with a single > Core2 Duo P8700 CPU (one die, 2 cores, no HT). It's apparently able > to clock both cores at different speeds (one core running busy at 2540mhz > and the other idling at 800mhz), if that's what you mean by multiple > clock lines. Perfect!! So, when the cpus can manage different freqs, we have multiple struct policies for them per cpu. > In any case, next-20130206 complained, and with this patch added I see > nothing in dmesg and cpufreq is acting properly on both cores, so: > > Tested-By: Valdis Kletnieks <valdis.kletnieks@vt.edu> Thanks. > (btw - I had to hand-apply your patch, as it showed up white-space > damaged. Three lines wrapped, and tabs converted to spaces). I know that and feeling bad for you :( I gave you this because of my mails issue :) http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/for-valdis -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index ccc598a..3b941a1 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1567,8 +1567,10 @@ static int __cpufreq_governor(struct cpufreq_policy *policy, policy->cpu, event); ret = policy->governor->governor(policy, event); - if (!policy->governor->initialized && (event == CPUFREQ_GOV_START)) - policy->governor->initialized = 1; + if (event == CPUFREQ_GOV_START) + policy->governor->initialized++; + else if (event == CPUFREQ_GOV_STOP) + policy->governor->initialized--; /* we keep one module reference alive for each CPU governed by this CPU */ diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index e4a306c..5a76086 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -247,11 +247,13 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, dbs_data->gov_dbs_timer); } - rc = sysfs_create_group(cpufreq_global_kobject, - dbs_data->attr_group); - if (rc) { - mutex_unlock(&dbs_data->mutex); - return rc; + if (!policy->governor->initialized) { + rc = sysfs_create_group(cpufreq_global_kobject, + dbs_data->attr_group); + if (rc) { + mutex_unlock(&dbs_data->mutex); + return rc; + } } /* @@ -262,13 +264,15 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, cs_dbs_info->down_skip = 0; cs_dbs_info->enable = 1; cs_dbs_info->requested_freq = policy->cur; - cpufreq_register_notifier(cs_ops->notifier_block, - CPUFREQ_TRANSITION_NOTIFIER); - if (!policy->governor->initialized) + if (!policy->governor->initialized) { + cpufreq_register_notifier(cs_ops->notifier_block, + CPUFREQ_TRANSITION_NOTIFIER); + dbs_data->min_sampling_rate = MIN_SAMPLING_RATE_RATIO * jiffies_to_usecs(10); + } } else { od_dbs_info->rate_mult = 1;