| Message ID | E1qA7yZ-00Ea50-OC@rmk-PC.armlinux.org.uk (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | Update for AP807 thermal data | expand |
Hi Russell and Alex, On Fri, Jun 16, 2023 at 12:50:47PM +0100, Russell King wrote: > From: Alex Leibovich <alexl@marvell.com> > > Use the correct thermal coefficients for the Armada AP807 dies. > > Signed-off-by: Alex Leibovich <alexl@marvell.com> > Reviewed-by: Stefan Chulski <stefanc@marvell.com> > Tested-by: Stefan Chulski <stefanc@marvell.com> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > --- > arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > index 4a23f65d475f..a3328d05fc94 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > @@ -33,3 +33,6 @@ &ap_sdhci0 { > "marvell,armada-ap806-sdhci"; /* Backward compatibility */ > }; > > +&ap_thermal { > + compatible = "marvell,armada-ap807-thermal"; > +}; While working on some thermal optimizations, our hardware team discovered that this patch is still missing upstream. Is something missing or did it get lost? Regards, Stefan
On Wed, Feb 07, 2024 at 05:15:48PM +0100, Stefan Eichenberger wrote: > Hi Russell and Alex, > > On Fri, Jun 16, 2023 at 12:50:47PM +0100, Russell King wrote: > > From: Alex Leibovich <alexl@marvell.com> > > > > Use the correct thermal coefficients for the Armada AP807 dies. > > > > Signed-off-by: Alex Leibovich <alexl@marvell.com> > > Reviewed-by: Stefan Chulski <stefanc@marvell.com> > > Tested-by: Stefan Chulski <stefanc@marvell.com> > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > --- > > arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > > index 4a23f65d475f..a3328d05fc94 100644 > > --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > > +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > > @@ -33,3 +33,6 @@ &ap_sdhci0 { > > "marvell,armada-ap806-sdhci"; /* Backward compatibility */ > > }; > > > > +&ap_thermal { > > + compatible = "marvell,armada-ap807-thermal"; > > +}; > > While working on some thermal optimizations, our hardware team > discovered that this patch is still missing upstream. Is something > missing or did it get lost? Patch 1/3 had a change request. Was it ever reposted with the requested change? It would also be nice to convert the .txt to .yaml. The DT Maintainers might insist on that when it is reposted? Andrew
On Wed, Feb 07, 2024 at 05:25:59PM +0100, Andrew Lunn wrote: > On Wed, Feb 07, 2024 at 05:15:48PM +0100, Stefan Eichenberger wrote: > > Hi Russell and Alex, > > > > On Fri, Jun 16, 2023 at 12:50:47PM +0100, Russell King wrote: > > > From: Alex Leibovich <alexl@marvell.com> > > > > > > Use the correct thermal coefficients for the Armada AP807 dies. > > > > > > Signed-off-by: Alex Leibovich <alexl@marvell.com> > > > Reviewed-by: Stefan Chulski <stefanc@marvell.com> > > > Tested-by: Stefan Chulski <stefanc@marvell.com> > > > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> > > > --- > > > arch/arm64/boot/dts/marvell/armada-ap807.dtsi | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > > > index 4a23f65d475f..a3328d05fc94 100644 > > > --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > > > +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi > > > @@ -33,3 +33,6 @@ &ap_sdhci0 { > > > "marvell,armada-ap806-sdhci"; /* Backward compatibility */ > > > }; > > > > > > +&ap_thermal { > > > + compatible = "marvell,armada-ap807-thermal"; > > > +}; > > > > While working on some thermal optimizations, our hardware team > > discovered that this patch is still missing upstream. Is something > > missing or did it get lost? > > Patch 1/3 had a change request. Was it ever reposted with the > requested change? I don't think so, it's just another patch series of many that I have that's basically low priority, and other stuff probably overrode it and I then forgot about it.
On Wed, Feb 07, 2024 at 04:29:59PM +0000, Russell King (Oracle) wrote: > On Wed, Feb 07, 2024 at 05:25:59PM +0100, Andrew Lunn wrote: > > > While working on some thermal optimizations, our hardware team > > > discovered that this patch is still missing upstream. Is something > > > missing or did it get lost? > > > > Patch 1/3 had a change request. Was it ever reposted with the > > requested change? I forgot to mention that the other patches were applied, so it is only the one missing without change request. > > I don't think so, it's just another patch series of many that I have > that's basically low priority, and other stuff probably overrode it > and I then forgot about it. No problem at all, thanks a lot for the feedback. Regards, Stefan
On Wed, Feb 07, 2024 at 05:46:56PM +0100, Stefan Eichenberger wrote: > On Wed, Feb 07, 2024 at 04:29:59PM +0000, Russell King (Oracle) wrote: > > On Wed, Feb 07, 2024 at 05:25:59PM +0100, Andrew Lunn wrote: > > > > While working on some thermal optimizations, our hardware team > > > > discovered that this patch is still missing upstream. Is something > > > > missing or did it get lost? > > > > > > Patch 1/3 had a change request. Was it ever reposted with the > > > requested change? > > I forgot to mention that the other patches were applied, so it is only > the one missing without change request. Ah. O.K. Repost it to the MVEBU Maintainers. Andrew
diff --git a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi index 4a23f65d475f..a3328d05fc94 100644 --- a/arch/arm64/boot/dts/marvell/armada-ap807.dtsi +++ b/arch/arm64/boot/dts/marvell/armada-ap807.dtsi @@ -33,3 +33,6 @@ &ap_sdhci0 { "marvell,armada-ap806-sdhci"; /* Backward compatibility */ }; +&ap_thermal { + compatible = "marvell,armada-ap807-thermal"; +};