| Message ID | X/V2k8dwaXJH6VFh@mwanda (mailing list archive) |
|---|---|
| State | Mainlined, archived |
| Headers | show |
| Series | [1/3] powercap/drivers/dtpm: Fix a double shift bug | expand |
On 06/01/2021 09:36, Dan Carpenter wrote: > The DTPM_POWER_LIMIT_FLAG is used for test_bit() etc which take a bit > number so it should be bit 0. But currently it's set to BIT(0) then > that is double shifted equivalent to BIT(BIT(0)). This doesn't cause a > run time problem because it's done consistently. > > Fixes: a20d0ef97abf ("powercap/drivers/dtpm: Add API for dynamic thermal power management") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > drivers/powercap/dtpm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c > index 0abcc439d728..d49df0569cd4 100644 > --- a/drivers/powercap/dtpm.c > +++ b/drivers/powercap/dtpm.c > @@ -24,7 +24,7 @@ > #include <linux/slab.h> > #include <linux/mutex.h> > > -#define DTPM_POWER_LIMIT_FLAG BIT(0) > +#define DTPM_POWER_LIMIT_FLAG 0 > > static const char *constraint_name[] = { > "Instantaneous", >
diff --git a/drivers/powercap/dtpm.c b/drivers/powercap/dtpm.c index 0abcc439d728..d49df0569cd4 100644 --- a/drivers/powercap/dtpm.c +++ b/drivers/powercap/dtpm.c @@ -24,7 +24,7 @@ #include <linux/slab.h> #include <linux/mutex.h> -#define DTPM_POWER_LIMIT_FLAG BIT(0) +#define DTPM_POWER_LIMIT_FLAG 0 static const char *constraint_name[] = { "Instantaneous",
The DTPM_POWER_LIMIT_FLAG is used for test_bit() etc which take a bit number so it should be bit 0. But currently it's set to BIT(0) then that is double shifted equivalent to BIT(BIT(0)). This doesn't cause a run time problem because it's done consistently. Fixes: a20d0ef97abf ("powercap/drivers/dtpm: Add API for dynamic thermal power management") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/powercap/dtpm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)