diff mbox

cpufreq-SCPI: Delete unnecessary assignment for the field "owner"

Message ID a3baf5da-9471-8b58-468f-b9670e136bd4@users.sourceforge.net (mailing list archive)
State Changes Requested, archived
Headers show

Commit Message

SF Markus Elfring Aug. 16, 2016, 8:38 p.m. UTC 
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Tue, 16 Aug 2016 22:30:17 +0200

The field "owner" is set by the core.
Thus delete an unneeded initialisation.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/cpufreq/scpi-cpufreq.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Julia Lawall Aug. 16, 2016, 8:41 p.m. UTC | #1 
On Tue, 16 Aug 2016, SF Markus Elfring wrote:

> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 16 Aug 2016 22:30:17 +0200
>
> The field "owner" is set by the core.
> Thus delete an unneeded initialisation.
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/cpufreq/scpi-cpufreq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index e8a7bf5..4a70d241 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -104,8 +104,7 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
>
>  static struct platform_driver scpi_cpufreq_platdrv = {
>  	.driver = {
> -		.name	= "scpi-cpufreq",
> -		.owner	= THIS_MODULE,
> +		.name	= "scpi-cpufreq"

You don't need to remove the comma.  There was a trailing comma
originally, so you may as well leave that.

julia

>  	},
>  	.probe		= scpi_cpufreq_probe,
>  	.remove		= scpi_cpufreq_remove,
> --
> 2.9.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Rafael J. Wysocki Aug. 16, 2016, 8:47 p.m. UTC | #2 
On Tuesday, August 16, 2016 10:38:02 PM SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 16 Aug 2016 22:30:17 +0200
> 
> The field "owner" is set by the core.
> Thus delete an unneeded initialisation.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
>  drivers/cpufreq/scpi-cpufreq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
> index e8a7bf5..4a70d241 100644
> --- a/drivers/cpufreq/scpi-cpufreq.c
> +++ b/drivers/cpufreq/scpi-cpufreq.c
> @@ -104,8 +104,7 @@ static int scpi_cpufreq_remove(struct platform_device *pdev)
>  
>  static struct platform_driver scpi_cpufreq_platdrv = {
>  	.driver = {
> -		.name	= "scpi-cpufreq",
> -		.owner	= THIS_MODULE,
> +		.name	= "scpi-cpufreq"

Comma, please.

>  	},
>  	.probe		= scpi_cpufreq_probe,
>  	.remove		= scpi_cpufreq_remove,
> 

Thanks.
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-pm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/cpufreq/scpi-cpufreq.c b/drivers/cpufreq/scpi-cpufreq.c
index e8a7bf5..4a70d241 100644
--- a/drivers/cpufreq/scpi-cpufreq.c
+++ b/drivers/cpufreq/scpi-cpufreq.c
@@ -104,8 +104,7 @@  static int scpi_cpufreq_remove(struct platform_device *pdev)
 
 static struct platform_driver scpi_cpufreq_platdrv = {
 	.driver = {
-		.name	= "scpi-cpufreq",
-		.owner	= THIS_MODULE,
+		.name	= "scpi-cpufreq"
 	},
 	.probe		= scpi_cpufreq_probe,
 	.remove		= scpi_cpufreq_remove,