| Message ID | aae042425e7a55d7d0f873cdfc3712953fb0df10.1627288191.git.mirq-linux@rere.qmqm.pl (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | viresh kumar |
| Headers | show |
| Series | opp: remove WARN when no valid OPPs remain | expand |
On 26-07-21, 10:30, Michał Mirosław wrote: > This WARN can be triggered per-core and the stack trace is not useful. > Replace it with plain dev_err(). Fix a comment while at it. > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> > --- > drivers/opp/of.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/opp/of.c b/drivers/opp/of.c > index c582a9ca397b..01feeba78426 100644 > --- a/drivers/opp/of.c > +++ b/drivers/opp/of.c > @@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table) > } > } > > - /* There should be one of more OPP defined */ > - if (WARN_ON(!count)) { > + /* There should be one or more OPPs defined */ > + if (!count) { > + dev_err(dev, "%s: no supported OPPs", __func__); > ret = -ENOENT; > goto remove_static_opp; > } Applied. Thanks.
diff --git a/drivers/opp/of.c b/drivers/opp/of.c index c582a9ca397b..01feeba78426 100644 --- a/drivers/opp/of.c +++ b/drivers/opp/of.c @@ -985,8 +985,9 @@ static int _of_add_opp_table_v2(struct device *dev, struct opp_table *opp_table) } } - /* There should be one of more OPP defined */ - if (WARN_ON(!count)) { + /* There should be one or more OPPs defined */ + if (!count) { + dev_err(dev, "%s: no supported OPPs", __func__); ret = -ENOENT; goto remove_static_opp; }
This WARN can be triggered per-core and the stack trace is not useful. Replace it with plain dev_err(). Fix a comment while at it. Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl> --- drivers/opp/of.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)