| Message ID | accb12bd6d048d95bd1feea07dd1a799ad3f8b31.1737532423.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | pmdomain: ti: Use of_property_present() for non-boolean properties | expand |
On Wed, 22 Jan 2025 at 08:56, Geert Uytterhoeven <geert+renesas@glider.be> wrote: > > On BeagleBone Black: > > OF: /ocp: Read of boolean property 'clocks' with a value. > OF: /ocp/interconnect@44c00000: Read of boolean property 'clocks' with a value. > OF: /ocp/interconnect@48000000: Read of boolean property 'clocks' with a value. > OF: /ocp/interconnect@4a000000: Read of boolean property 'clocks' with a value. > > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied for next, thanks! Kind regards Uffe > --- > Seen since commit c141ecc3cecd7647 ("of: Warn when > of_property_read_bool() is used on non-boolean properties") in > dt-rh/for-next. > --- > drivers/pmdomain/ti/omap_prm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c > index b8ceb3c2b81c2510..79d165331d8c6379 100644 > --- a/drivers/pmdomain/ti/omap_prm.c > +++ b/drivers/pmdomain/ti/omap_prm.c > @@ -613,7 +613,7 @@ static int omap_prm_domain_attach_clock(struct device *dev, > if (!of_device_is_compatible(np, "simple-pm-bus")) > return 0; > > - if (!of_property_read_bool(np, "clocks")) > + if (!of_property_present(np, "clocks")) > return 0; > > error = pm_clk_create(dev); > -- > 2.43.0 >
diff --git a/drivers/pmdomain/ti/omap_prm.c b/drivers/pmdomain/ti/omap_prm.c index b8ceb3c2b81c2510..79d165331d8c6379 100644 --- a/drivers/pmdomain/ti/omap_prm.c +++ b/drivers/pmdomain/ti/omap_prm.c @@ -613,7 +613,7 @@ static int omap_prm_domain_attach_clock(struct device *dev, if (!of_device_is_compatible(np, "simple-pm-bus")) return 0; - if (!of_property_read_bool(np, "clocks")) + if (!of_property_present(np, "clocks")) return 0; error = pm_clk_create(dev);
On BeagleBone Black: OF: /ocp: Read of boolean property 'clocks' with a value. OF: /ocp/interconnect@44c00000: Read of boolean property 'clocks' with a value. OF: /ocp/interconnect@48000000: Read of boolean property 'clocks' with a value. OF: /ocp/interconnect@4a000000: Read of boolean property 'clocks' with a value. The use of of_property_read_bool() for non-boolean properties is deprecated in favor of of_property_present() when testing for property presence. Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Seen since commit c141ecc3cecd7647 ("of: Warn when of_property_read_bool() is used on non-boolean properties") in dt-rh/for-next. --- drivers/pmdomain/ti/omap_prm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)