From patchwork Tue Nov 28 06:51:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10078761 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C6E9360353 for ; Tue, 28 Nov 2017 06:51:47 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9636D29181 for ; Tue, 28 Nov 2017 06:51:47 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8B50229186; Tue, 28 Nov 2017 06:51:47 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0D2BA29183 for ; Tue, 28 Nov 2017 06:51:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751322AbdK1Gvq (ORCPT ); Tue, 28 Nov 2017 01:51:46 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34946 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbdK1Gvq (ORCPT ); Tue, 28 Nov 2017 01:51:46 -0500 Received: by mail-pf0-f194.google.com with SMTP id r88so14602678pfi.2 for ; Mon, 27 Nov 2017 22:51:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=aiddccDqqWJDpW05Ve2RHswyxtGZTyJDCHzVd0xaMng=; b=cRVhR4gE4s/NBZfXjOoSTywasHwtJ5hytA3PhWVA9tH6r7ppVwe3uOzaZZSCGjOKtQ cNhx5jKvpHyyEAk7cwBQI1jVaF/ymJvQfRsSvK/gk+HsPa2Mj09GJeacbZwJ5xcY5owQ /l2FvO0uGmR8prjIsMknfSfrUhO0P3RwkNutE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=aiddccDqqWJDpW05Ve2RHswyxtGZTyJDCHzVd0xaMng=; b=l7XOjdUt+TQCiZvRHTSBLiYyqJY16RRM7PpRjroRYTA/N9lZYXtioCTy7Z9rnCJlb0 jdvczqXWIFYrD1vlkDhQB79njbJj+4n4a6Vsz94QIdHmGFxEtn48NubozoBBSZge/sQ9 EO912k/fkmSoPSsSdzOfZ6jouPEdS+7IaZmMRI07amPis3euG/6WB4hI4u+xzfpvnCQD MRztQ4JuR8ukyGDVCwyrTYOjxYIq2ArQVmj9bFPE+Xwak0awAkjlO/3n07K4x6TC3umX qVVXGDVp2yuwdCzt+57obE0CfQ0DnLpSFsIDgjJyXjsJ/FYwZttbR/AyCTxQeVaTQX6d stTA== X-Gm-Message-State: AJaThX78aeWYSe2EUrM5uNNkygXBL2dchXgqtgB17nIp+Ameyu0JPM+C CX5BKSkRcrpdm70AyQjQbBf9u5fdmEs= X-Google-Smtp-Source: AGs4zMZNKu0tmPw/ONG6n5X8uuA/YpSoSUeioLrbMBxsZtqFkQuVJskPs1nO5j4iESfDAqVpVXq/sA== X-Received: by 10.98.200.20 with SMTP id z20mr39630674pff.108.1511851902414; Mon, 27 Nov 2017 22:51:42 -0800 (PST) Received: from localhost ([122.171.67.58]) by smtp.gmail.com with ESMTPSA id f83sm58356135pfj.23.2017.11.27.22.51.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Nov 2017 22:51:41 -0800 (PST) From: Viresh Kumar To: stable@vger.kernel.org Cc: Viresh Kumar , linux-pm@vger.kernel.org Subject: [PATCH v4.9] PM / OPP: Add missing of_node_put(np) Date: Tue, 28 Nov 2017 12:21:38 +0530 Message-Id: X-Mailer: git-send-email 2.15.0.194.g9af6a3dea062 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tobias Jordan commit 7978db344719dab1e56d05e6fc04aaaddcde0a5e upstream. The for_each_available_child_of_node() loop in _of_add_opp_table_v2() doesn't drop the reference to "np" on errors. Fix that. Fixes: 274659029c9d (PM / OPP: Add support to parse "operating-points-v2" bindings) Cc: 4.9 # 4.9 Signed-off-by: Tobias Jordan [ VK: Improved commit log. ] Signed-off-by: Viresh Kumar Reviewed-by: Stephen Boyd Signed-off-by: Rafael J. Wysocki --- drivers/base/power/opp/of.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/base/power/opp/of.c b/drivers/base/power/opp/of.c index 5552211e6fcd..af208884bbed 100644 --- a/drivers/base/power/opp/of.c +++ b/drivers/base/power/opp/of.c @@ -348,6 +348,7 @@ static int _of_add_opp_table_v2(struct device *dev, struct device_node *opp_np) if (ret) { dev_err(dev, "%s: Failed to add OPP, %d\n", __func__, ret); + of_node_put(np); goto free_table; } }