| Message ID | b897b1c8741c8a871163b84d01b480f99329536d.1448263428.git.atx@atx.name (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi, On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: > Add a node describing the Security ID memory to the > Allwinner H3 .dtsi file. > > Signed-off-by: Josef Gajdusek <atx@atx.name> > --- > arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > index 0faa38a..58de718 100644 > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > @@ -359,6 +359,13 @@ > #size-cells = <0>; > }; > > + sid: eeprom@01c14000 { > + compatible = "allwinner,sun4i-a10-sid"; > + reg = <0x01c14000 0x400>; The datasheet says it's 256 bytes wide, while the size here is of 1kB, is it intentional? Thanks, Maxime
Hi, On Mon, Nov 23, 2015 at 8:43 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > Hi, > > On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: >> Add a node describing the Security ID memory to the >> Allwinner H3 .dtsi file. >> >> Signed-off-by: Josef Gajdusek <atx@atx.name> >> --- >> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> index 0faa38a..58de718 100644 >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> @@ -359,6 +359,13 @@ >> #size-cells = <0>; >> }; >> >> + sid: eeprom@01c14000 { >> + compatible = "allwinner,sun4i-a10-sid"; >> + reg = <0x01c14000 0x400>; > > The datasheet says it's 256 bytes wide, while the size here is of 1kB, > is it intentional? My H3 datasheet (v1.1) says its 1 kB wide. It'd be nice if Allwinner actually listed the "usable" E-fuse offsets and widths, instead of having us dig through the SDK code. Regards ChenYu -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 24, 2015 at 11:13:13AM +0800, Chen-Yu Tsai wrote: > Hi, > > On Mon, Nov 23, 2015 at 8:43 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > Hi, > > > > On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: > >> Add a node describing the Security ID memory to the > >> Allwinner H3 .dtsi file. > >> > >> Signed-off-by: Josef Gajdusek <atx@atx.name> > >> --- > >> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > >> index 0faa38a..58de718 100644 > >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi > >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > >> @@ -359,6 +359,13 @@ > >> #size-cells = <0>; > >> }; > >> > >> + sid: eeprom@01c14000 { > >> + compatible = "allwinner,sun4i-a10-sid"; > >> + reg = <0x01c14000 0x400>; > > > > The datasheet says it's 256 bytes wide, while the size here is of 1kB, > > is it intentional? > > My H3 datasheet (v1.1) says its 1 kB wide. Is it? in the Security ID section, it is said to be 2kb == 256B wide. > It'd be nice if Allwinner actually listed the "usable" E-fuse > offsets and widths, instead of having us dig through the SDK code. Yep. Thanks! Maxime
On Mon, Nov 23, 2015 at 07:24:40PM -0800, Sugar Wu wrote:
> I will give you the right widths as soon.
Great, thanks!
Maxime
On Tue, Nov 24, 2015 at 2:38 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote: > On Tue, Nov 24, 2015 at 11:13:13AM +0800, Chen-Yu Tsai wrote: >> Hi, >> >> On Mon, Nov 23, 2015 at 8:43 PM, Maxime Ripard >> <maxime.ripard@free-electrons.com> wrote: >> > Hi, >> > >> > On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: >> >> Add a node describing the Security ID memory to the >> >> Allwinner H3 .dtsi file. >> >> >> >> Signed-off-by: Josef Gajdusek <atx@atx.name> >> >> --- >> >> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ >> >> 1 file changed, 7 insertions(+) >> >> >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi >> >> index 0faa38a..58de718 100644 >> >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >> >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >> >> @@ -359,6 +359,13 @@ >> >> #size-cells = <0>; >> >> }; >> >> >> >> + sid: eeprom@01c14000 { >> >> + compatible = "allwinner,sun4i-a10-sid"; >> >> + reg = <0x01c14000 0x400>; >> > >> > The datasheet says it's 256 bytes wide, while the size here is of 1kB, >> > is it intentional? >> >> My H3 datasheet (v1.1) says its 1 kB wide. > > Is it? in the Security ID section, it is said to be 2kb == 256B wide. Right. I was looking at the memory map. Maybe it's sparsely mapped? I guess we'll know soon. ChenYu >> It'd be nice if Allwinner actually listed the "usable" E-fuse >> offsets and widths, instead of having us dig through the SDK code. > > Yep. > > Thanks! > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Nov 24, 2015 at 02:42:26PM +0800, Chen-Yu Tsai wrote: > On Tue, Nov 24, 2015 at 2:38 PM, Maxime Ripard > <maxime.ripard@free-electrons.com> wrote: > > On Tue, Nov 24, 2015 at 11:13:13AM +0800, Chen-Yu Tsai wrote: > >> Hi, > >> > >> On Mon, Nov 23, 2015 at 8:43 PM, Maxime Ripard > >> <maxime.ripard@free-electrons.com> wrote: > >> > Hi, > >> > > >> > On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: > >> >> Add a node describing the Security ID memory to the > >> >> Allwinner H3 .dtsi file. > >> >> > >> >> Signed-off-by: Josef Gajdusek <atx@atx.name> > >> >> --- > >> >> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ > >> >> 1 file changed, 7 insertions(+) > >> >> > >> >> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi > >> >> index 0faa38a..58de718 100644 > >> >> --- a/arch/arm/boot/dts/sun8i-h3.dtsi > >> >> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > >> >> @@ -359,6 +359,13 @@ > >> >> #size-cells = <0>; > >> >> }; > >> >> > >> >> + sid: eeprom@01c14000 { > >> >> + compatible = "allwinner,sun4i-a10-sid"; > >> >> + reg = <0x01c14000 0x400>; > >> > > >> > The datasheet says it's 256 bytes wide, while the size here is of 1kB, > >> > is it intentional? > >> > >> My H3 datasheet (v1.1) says its 1 kB wide. > > > > Is it? in the Security ID section, it is said to be 2kb == 256B wide. > > Right. I was looking at the memory map. Maybe it's sparsely mapped? > I guess we'll know soon. If it is just like the A20, I think there's a few registers at the end to control the writes (that we don't use). Which means that the size of the fuses is smaller than the size of the mapped area (which also measn that our driver is broken making that assumption). Maxime
On Mon, Nov 23, 2015 at 10:51:15PM -0800, Sugar Wu wrote: > On Monday, November 23, 2015 at 8:43:59 PM UTC+8, Maxime Ripard wrote: > > > > Hi, > > > > On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: > > > Add a node describing the Security ID memory to the > > > Allwinner H3 .dtsi file. > > > > > > Signed-off-by: Josef Gajdusek <a...@atx.name <javascript:>> > > > --- > > > arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ > > > 1 file changed, 7 insertions(+) > > > > > > diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi > > b/arch/arm/boot/dts/sun8i-h3.dtsi > > > index 0faa38a..58de718 100644 > > > --- a/arch/arm/boot/dts/sun8i-h3.dtsi > > > +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > > > @@ -359,6 +359,13 @@ > > > #size-cells = <0>; > > > }; > > > > > > + sid: eeprom@01c14000 { > > > + compatible = "allwinner,sun4i-a10-sid"; > > > + reg = <0x01c14000 0x400>; > > > > The datasheet says it's 256 bytes wide, while the size here is of 1kB, > > is it intentional? > > SID memory map is 0x01c14000 ~ 0x01c143FF, include 2048bits efuse space. > H3 efuse space is SID_SRAM, its range is 0x01c14200 ~ +0x100. Interesting, what is below the 0x200 registers? Thanks! Maxime
On Monday, November 23, 2015 at 17:32 UTC+8, Maxime Ripard wrote: > On Mon, Nov 23, 2015 at 10:51:15PM -0800, Sugar Wu wrote: >> On Monday, November 23, 2015 at 8:43:59 PM UTC+8, Maxime Ripard wrote: >>> >>> Hi, >>> >>> On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: >>>> Add a node describing the Security ID memory to the >>>> Allwinner H3 .dtsi file. >>>> >>>> Signed-off-by: Josef Gajdusek <a...@atx.name <javascript:>> >>>> --- >>>> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ >>>> 1 file changed, 7 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi >>> b/arch/arm/boot/dts/sun8i-h3.dtsi >>>> index 0faa38a..58de718 100644 >>>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi >>>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi >>>> @@ -359,6 +359,13 @@ >>>> #size-cells = <0>; >>>> }; >>>> >>>> + sid: eeprom@01c14000 { >>>> + compatible = "allwinner,sun4i-a10-sid"; >>>> + reg = <0x01c14000 0x400>; >>> >>> The datasheet says it's 256 bytes wide, while the size here is of 1kB, >>> is it intentional? >> >> SID memory map is 0x01c14000 ~ 0x01c143FF, include 2048bits efuse space. >> H3 efuse space is SID_SRAM, its range is 0x01c14200 ~ +0x100. > > Interesting, what is below the 0x200 registers? > Some control register about SID. offset: 0x40 SID Program/Read Control Register offset: 0x50 SID Program Key Value Register offset: 0x60 SID Read Key Value Register offset: 0x70 \ offset: 0x80 SJTAG Attribute 0 Register offset: 0x84 SJTAG Attribute 1 Register offset: 0x88 SJTAG Select Register offset: 0x90 SID Program Ctrol register for burned timing > > Thanks! > Maxime > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On Wed, Nov 25, 2015 at 09:22:56AM +0800, Shuge wrote: > On Monday, November 23, 2015 at 17:32 UTC+8, Maxime Ripard wrote: > > On Mon, Nov 23, 2015 at 10:51:15PM -0800, Sugar Wu wrote: > >> On Monday, November 23, 2015 at 8:43:59 PM UTC+8, Maxime Ripard wrote: > >>> > >>> Hi, > >>> > >>> On Mon, Nov 23, 2015 at 09:02:48AM +0100, Josef Gajdusek wrote: > >>>> Add a node describing the Security ID memory to the > >>>> Allwinner H3 .dtsi file. > >>>> > >>>> Signed-off-by: Josef Gajdusek <a...@atx.name <javascript:>> > >>>> --- > >>>> arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ > >>>> 1 file changed, 7 insertions(+) > >>>> > >>>> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi > >>> b/arch/arm/boot/dts/sun8i-h3.dtsi > >>>> index 0faa38a..58de718 100644 > >>>> --- a/arch/arm/boot/dts/sun8i-h3.dtsi > >>>> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi > >>>> @@ -359,6 +359,13 @@ > >>>> #size-cells = <0>; > >>>> }; > >>>> > >>>> + sid: eeprom@01c14000 { > >>>> + compatible = "allwinner,sun4i-a10-sid"; > >>>> + reg = <0x01c14000 0x400>; > >>> > >>> The datasheet says it's 256 bytes wide, while the size here is of 1kB, > >>> is it intentional? > >> > >> SID memory map is 0x01c14000 ~ 0x01c143FF, include 2048bits efuse space. > >> H3 efuse space is SID_SRAM, its range is 0x01c14200 ~ +0x100. > > > > Interesting, what is below the 0x200 registers? > > > Some control register about SID. > offset: 0x40 SID Program/Read Control Register > offset: 0x50 SID Program Key Value Register > offset: 0x60 SID Read Key Value Register > offset: 0x70 \ > offset: 0x80 SJTAG Attribute 0 Register > offset: 0x84 SJTAG Attribute 1 Register > offset: 0x88 SJTAG Select Register > offset: 0x90 SID Program Ctrol register for burned timing Thanks! I guess the layout changed a bit from the A10 and alikes then. Anyway, we should expose only to the nvmem framework the actual eeprom space, so from 0x200 to 0x300 from what you're saying (just like we should only expose the first 4 bytes in the A10 / A20) Maxime
diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi index 0faa38a..58de718 100644 --- a/arch/arm/boot/dts/sun8i-h3.dtsi +++ b/arch/arm/boot/dts/sun8i-h3.dtsi @@ -359,6 +359,13 @@ #size-cells = <0>; }; + sid: eeprom@01c14000 { + compatible = "allwinner,sun4i-a10-sid"; + reg = <0x01c14000 0x400>; + #address-cells = <1>; + #size-cells = <1>; + }; + usbphy: phy@01c19400 { compatible = "allwinner,sun8i-h3-usb-phy"; reg = <0x01c19400 0x2c>,
Add a node describing the Security ID memory to the Allwinner H3 .dtsi file. Signed-off-by: Josef Gajdusek <atx@atx.name> --- arch/arm/boot/dts/sun8i-h3.dtsi | 7 +++++++ 1 file changed, 7 insertions(+)