| Message ID | c46b4408-bf1d-408d-9e6b-16b0ad272532@moroto.mountain (mailing list archive) |
|---|---|
| State | Handled Elsewhere, archived |
| Headers | show |
| Series | power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice() | expand |
On 27.09.2023 14:41, Dan Carpenter wrote: > There is a missing "ret = " assignment so this checks the same "ret" > value twice. > > Fixes: c75f4bf6800b ("power: supply: Introduce MM8013 fuel gauge driver") > Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> > --- Oh that's a funny mistake Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Thanks! Konrad
On Wed, 27 Sep 2023 15:41:05 +0300, Dan Carpenter wrote: > There is a missing "ret = " assignment so this checks the same "ret" > value twice. > > Applied, thanks! [1/1] power: supply: mm8013: Fix an error checking issue in mm8013_checkdevice() commit: 8f8e9b7388514d937843337140f18ceb0f3da6eb Best regards,
diff --git a/drivers/power/supply/mm8013.c b/drivers/power/supply/mm8013.c index 29fd65fe6545..caa272b03564 100644 --- a/drivers/power/supply/mm8013.c +++ b/drivers/power/supply/mm8013.c @@ -53,7 +53,7 @@ static int mm8013_checkdevice(struct mm8013_chip *chip) if (ret < 0) return ret; - regmap_read(chip->regmap, REG_BATID, &val); + ret = regmap_read(chip->regmap, REG_BATID, &val); if (ret < 0) return ret;
There is a missing "ret = " assignment so this checks the same "ret" value twice. Fixes: c75f4bf6800b ("power: supply: Introduce MM8013 fuel gauge driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- drivers/power/supply/mm8013.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)