From patchwork Thu Jan 31 08:25:13 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10790013 X-Patchwork-Delegate: viresh.linux@gmail.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 81066139A for ; Thu, 31 Jan 2019 08:25:54 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7FBBC284B5 for ; Thu, 31 Jan 2019 08:25:54 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 71C9F285C7; Thu, 31 Jan 2019 08:25:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1767E284B5 for ; Thu, 31 Jan 2019 08:25:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726255AbfAaIZ3 (ORCPT ); Thu, 31 Jan 2019 03:25:29 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:40106 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725961AbfAaIZ2 (ORCPT ); Thu, 31 Jan 2019 03:25:28 -0500 Received: by mail-pg1-f193.google.com with SMTP id z10so1054853pgp.7 for ; Thu, 31 Jan 2019 00:25:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kZHVFmOzJU25u9HkbvP1Fa/F6wYGwLMXnctx3Yz3nHM=; b=iCUUO0PIyoJk5/cvtqGv+Fd5sv2pVJYL0+e52+knivjq+Iuvz/uGWErpsZWgF/E/ap uThiGmiTXiStQuF0xCLw54QgTqMfT0IEJ/2p5ZHk1gG5v33YttwWAsY+qZsRIK6JmwDF cjmdapDO/XGYUWEiTdumO4GsN5tgamZzp2HuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kZHVFmOzJU25u9HkbvP1Fa/F6wYGwLMXnctx3Yz3nHM=; b=EyDRqfTPuo07NbiIuJIT/K6TOqJCTOPXrE4ppcw/elDjActb8e1tlpjg/DXHJYKgkv qv5Bf3wWRS25aoy7P6sZz6W2IYey4jr+M7uj1+QWFF6C0pNvpMDwA+9frhmr0W2rsJ1S PJi8v9VguuoFBCLRbuTf7oRdE4+z4IXv8WBEbDLcTGgLtfurA7bkgAY/C8WqfYhQXR8P lvh8I2P1oe4ZtwdggS+n1gtibjqx8hxtsG31qJwOvVHn5k/z1mEuCVx/sVu9k9BMFrTr 8jmC8bIwL1VAhL43lWQYpnFchB8Q1ZG90FTs7laEQZAmAvrzHXF0fnBkwBshgD9vIpHW C1Wg== X-Gm-Message-State: AJcUukeqy4YLA0k6bZ8mGc9RvWO87WQMum/GNCGMvBzTt/Fkdx7ffrGe RtrO7hP2j4U7nRMGilI++L90cQ== X-Google-Smtp-Source: ALg8bN5CPVF1hoE2m5jYOIrmHZdzYV6fTyIc3y3+TBziqdt4RqSflvxhdqBh9HybtBb7Zm34xfWamw== X-Received: by 2002:a62:cf84:: with SMTP id b126mr33560188pfg.98.1548923127645; Thu, 31 Jan 2019 00:25:27 -0800 (PST) Received: from localhost ([122.172.102.63]) by smtp.gmail.com with ESMTPSA id s37sm8923021pgm.19.2019.01.31.00.25.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 00:25:26 -0800 (PST) From: Viresh Kumar To: Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Rafael Wysocki , linux-kernel@vger.kernel.org Subject: [PATCH] PM / OPP: Remove unused parameter of _generic_set_opp_clk_only() Date: Thu, 31 Jan 2019 13:55:13 +0530 Message-Id: X-Mailer: git-send-email 2.20.1.321.g9e740568ce00 MIME-Version: 1.0 Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The previous frequency value isn't getting used in the routine _generic_set_opp_clk_only(), drop it. Signed-off-by: Viresh Kumar Reviewed-by: Stephen Boyd --- drivers/opp/core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index d455b84cce5a..fa15aa8e00b0 100644 --- a/drivers/opp/core.c +++ b/drivers/opp/core.c @@ -533,9 +533,8 @@ static int _set_opp_voltage(struct device *dev, struct regulator *reg, return ret; } -static inline int -_generic_set_opp_clk_only(struct device *dev, struct clk *clk, - unsigned long old_freq, unsigned long freq) +static inline int _generic_set_opp_clk_only(struct device *dev, struct clk *clk, + unsigned long freq) { int ret; @@ -572,7 +571,7 @@ static int _generic_set_opp_regulator(const struct opp_table *opp_table, } /* Change frequency */ - ret = _generic_set_opp_clk_only(dev, opp_table->clk, old_freq, freq); + ret = _generic_set_opp_clk_only(dev, opp_table->clk, freq); if (ret) goto restore_voltage; @@ -586,7 +585,7 @@ static int _generic_set_opp_regulator(const struct opp_table *opp_table, return 0; restore_freq: - if (_generic_set_opp_clk_only(dev, opp_table->clk, freq, old_freq)) + if (_generic_set_opp_clk_only(dev, opp_table->clk, old_freq)) dev_err(dev, "%s: failed to restore old-freq (%lu Hz)\n", __func__, old_freq); restore_voltage: @@ -759,7 +758,7 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq) opp->supplies); } else { /* Only frequency scaling */ - ret = _generic_set_opp_clk_only(dev, clk, old_freq, freq); + ret = _generic_set_opp_clk_only(dev, clk, freq); } /* Scaling down? Configure required OPPs after frequency */