| Message ID | f0a8f9faefa8da662d5450ea90db7e8e4d943e25.1368740425.git.len.brown@intel.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Zhang Rui |
| Headers | show |
Hi Len/Fenghua, > -----Original Message----- > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > owner@vger.kernel.org] On Behalf Of Len Brown > Sent: Wednesday, May 22, 2013 1:05 AM > To: Zhang, Rui > Cc: linux-pm@vger.kernel.org; Yu, Fenghua > Subject: [PATCH 1/2] x86 thermal: Delete power-limit-notification console > messages > > From: Fenghua Yu <fenghua.yu@intel.com> > > Package power limits are common on some systems under some conditions - > - > so printing console messages when limits are reached > causes unnecessary customer concern and support calls. We are facing the exact similar situation here, but on the Thermal throttling events. So, basically I am in support of this removal patch. > > Note that even with these console messages gone, > the events can still be observed via system counters: > > $ grep TRM /proc/interrupts > > Shows total thermal interrupts, which includes both power > limit notifications and thermal throttling interrupts. Yes, On the other hand, we can use these counters, and not print those console messages. > > $ grep . /sys/devices/system/cpu/cpu*/thermal_throttle/* > > Will show what caused those interrupts, core and package > throttling and power limit notifications. > > https://bugzilla.kernel.org/show_bug.cgi?id=36182 Thanks for the link ;) > > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> > Signed-off-by: Len Brown <len.brown@intel.com> > --- > arch/x86/kernel/cpu/mcheck/therm_throt.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c > b/arch/x86/kernel/cpu/mcheck/therm_throt.c > index 47a1870..68fa890 100644 > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c > @@ -181,11 +181,6 @@ static int therm_throt_process(bool new_event, int > event, int level) > this_cpu, > level == CORE_LEVEL ? "Core" : "Package", > state->count); Here, can we remove the other print also ? (The thermal throttling prints) Thanks, Durga > - else > - printk(KERN_CRIT "CPU%d: %s power limit > notification (total events = %lu)\n", > - this_cpu, > - level == CORE_LEVEL ? "Core" : "Package", > - state->count); > return 1; > } > if (old_event) { > @@ -193,10 +188,6 @@ static int therm_throt_process(bool new_event, int > event, int level) > printk(KERN_INFO "CPU%d: %s temperature/speed > normal\n", > this_cpu, > level == CORE_LEVEL ? "Core" : "Package"); > - else > - printk(KERN_INFO "CPU%d: %s power limit > normal\n", > - this_cpu, > - level == CORE_LEVEL ? "Core" : "Package"); > return 1; > } > > -- > 1.8.3.rc2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-pm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: R, Durgadoss > Hi Len/Fenghua, > > > -----Original Message----- > > From: linux-pm-owner@vger.kernel.org [mailto:linux-pm- > > owner@vger.kernel.org] On Behalf Of Len Brown > > Sent: Wednesday, May 22, 2013 1:05 AM > > To: Zhang, Rui > > Cc: linux-pm@vger.kernel.org; Yu, Fenghua > > Subject: [PATCH 1/2] x86 thermal: Delete power-limit-notification > console > > messages > > > > From: Fenghua Yu <fenghua.yu@intel.com> > > > > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c > > b/arch/x86/kernel/cpu/mcheck/therm_throt.c > > index 47a1870..68fa890 100644 > > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c > > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c > > @@ -181,11 +181,6 @@ static int therm_throt_process(bool new_event, > int > > event, int level) > > this_cpu, > > level == CORE_LEVEL ? "Core" : "Package", > > state->count); > > Here, can we remove the other print also ? > (The thermal throttling prints) The thermal throttling is legacy code and users could use the printed info already. Adding Andi who wrote the thermal throttling code and may have more insight. Thanks. -Fenghua -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2013-05-21 at 15:35 -0400, Len Brown wrote: > From: Fenghua Yu <fenghua.yu@intel.com> > > Package power limits are common on some systems under some conditions -- > so printing console messages when limits are reached > causes unnecessary customer concern and support calls. > > Note that even with these console messages gone, > the events can still be observed via system counters: > > $ grep TRM /proc/interrupts > > Shows total thermal interrupts, which includes both power > limit notifications and thermal throttling interrupts. > > $ grep . /sys/devices/system/cpu/cpu*/thermal_throttle/* > > Will show what caused those interrupts, core and package > throttling and power limit notifications. > > https://bugzilla.kernel.org/show_bug.cgi?id=36182 > > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> > Signed-off-by: Len Brown <len.brown@intel.com> who should take these two patches? thanks, rui > --- > arch/x86/kernel/cpu/mcheck/therm_throt.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c > index 47a1870..68fa890 100644 > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c > @@ -181,11 +181,6 @@ static int therm_throt_process(bool new_event, int event, int level) > this_cpu, > level == CORE_LEVEL ? "Core" : "Package", > state->count); > - else > - printk(KERN_CRIT "CPU%d: %s power limit notification (total events = %lu)\n", > - this_cpu, > - level == CORE_LEVEL ? "Core" : "Package", > - state->count); > return 1; > } > if (old_event) { > @@ -193,10 +188,6 @@ static int therm_throt_process(bool new_event, int event, int level) > printk(KERN_INFO "CPU%d: %s temperature/speed normal\n", > this_cpu, > level == CORE_LEVEL ? "Core" : "Package"); > - else > - printk(KERN_INFO "CPU%d: %s power limit normal\n", > - this_cpu, > - level == CORE_LEVEL ? "Core" : "Package"); > return 1; > } > -- To unsubscribe from this list: send the line "unsubscribe linux-pm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: Zhang, Rui > Sent: Monday, May 27, 2013 7:17 PM > > On Tue, 2013-05-21 at 15:35 -0400, Len Brown wrote: > > From: Fenghua Yu <fenghua.yu@intel.com> > > > > Package power limits are common on some systems under some conditions > -- > > so printing console messages when limits are reached > > causes unnecessary customer concern and support calls. > > > > Note that even with these console messages gone, > > the events can still be observed via system counters: > > > > $ grep TRM /proc/interrupts > > > > Shows total thermal interrupts, which includes both power > > limit notifications and thermal throttling interrupts. > > > > $ grep . /sys/devices/system/cpu/cpu*/thermal_throttle/* > > > > Will show what caused those interrupts, core and package > > throttling and power limit notifications. > > > > https://bugzilla.kernel.org/show_bug.cgi?id=36182 > > > > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com> > > Signed-off-by: Len Brown <len.brown@intel.com> > > who should take these two patches? > > thanks, > rui I don't see the patches in upstream or tip trees. Are the patches on track in upstream? Thanks. -Fenghua
diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c b/arch/x86/kernel/cpu/mcheck/therm_throt.c index 47a1870..68fa890 100644 --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c @@ -181,11 +181,6 @@ static int therm_throt_process(bool new_event, int event, int level) this_cpu, level == CORE_LEVEL ? "Core" : "Package", state->count); - else - printk(KERN_CRIT "CPU%d: %s power limit notification (total events = %lu)\n", - this_cpu, - level == CORE_LEVEL ? "Core" : "Package", - state->count); return 1; } if (old_event) { @@ -193,10 +188,6 @@ static int therm_throt_process(bool new_event, int event, int level) printk(KERN_INFO "CPU%d: %s temperature/speed normal\n", this_cpu, level == CORE_LEVEL ? "Core" : "Package"); - else - printk(KERN_INFO "CPU%d: %s power limit normal\n", - this_cpu, - level == CORE_LEVEL ? "Core" : "Package"); return 1; }