From patchwork Wed Mar 30 04:24:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 8692841 Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 548819F36E for ; Wed, 30 Mar 2016 04:24:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7E40520340 for ; Wed, 30 Mar 2016 04:24:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AA11A202FE for ; Wed, 30 Mar 2016 04:24:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752066AbcC3EYh (ORCPT ); Wed, 30 Mar 2016 00:24:37 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:33946 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbcC3EYg (ORCPT ); Wed, 30 Mar 2016 00:24:36 -0400 Received: by mail-pa0-f44.google.com with SMTP id fe3so30303781pab.1 for ; Tue, 29 Mar 2016 21:24:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=RckHNdaRJ/pE68EQODn1wxEMvuqizboZnXmJS4KGQP4=; b=KfsayMokppzXLGwNtej+9XIhcuLhgAZjRrL7NzLo6btpgcw45OksRyKxrOyI4PTfsG r1mg0FiuiP9qfR4M607aExiRG8H8I617kPfmPKTbTuvcUzWzsrf5HPA45FGuJfCgV+IB zBmSXDCdsm4g6A/ehVX9IFYMmIqqcIez0CwvE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=RckHNdaRJ/pE68EQODn1wxEMvuqizboZnXmJS4KGQP4=; b=erLpfL7WG3sxqCL+9XQZqlmoR8L3Qw0aubHEKb+zNz+8R48HdUdgmNP3/LNea/HMeL y+SurtHOoXn+5VBo+J0ALfZGpkse7zG6bmnPpG8WbjVmkULc907hJW8ecLdJV8qUO14n B9Dg3FcuxtPigDulTN2BiIcG9oLNt6hR157/4E/rrHNKihP0O6X0S7qx10lV1aLibygA KuUaZ6Y/M7V7S4AjLx4g0j246X/SwBh02R+CCHYdeUjuwJh9DkU726yO5Co3qen5a8uA V8kbrGHuxwQA23f7R5xhgBTP/WcqR0VQ3C/lGL9jHD0JLT1BElldy6u8dv12g2j4JdPv +1nQ== X-Gm-Message-State: AD7BkJJ4YLaIFVVw1vWjqI4825vo/JQZd2UtUMdZgi8yd53gJdCJ0GJZ9yteeZEp/zSoH1HC X-Received: by 10.66.66.135 with SMTP id f7mr9463778pat.101.1459311876121; Tue, 29 Mar 2016 21:24:36 -0700 (PDT) Received: from localhost ([122.172.81.221]) by smtp.gmail.com with ESMTPSA id f12sm1783805pfd.87.2016.03.29.21.24.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Mar 2016 21:24:35 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki , Viresh Kumar Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cpufreq: acpi: policy->driver_data can't be NULL in ->exit() Date: Wed, 30 Mar 2016 09:54:24 +0530 Message-Id: X-Mailer: git-send-email 2.7.1.410.g6faf27b Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Its always set by ->init() and so it will always be there in ->exit(). There is no need to have a special check for just that. Signed-off-by: Viresh Kumar --- drivers/cpufreq/acpi-cpufreq.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c index eb2196f9d7fa..e20cbb1317cc 100644 --- a/drivers/cpufreq/acpi-cpufreq.c +++ b/drivers/cpufreq/acpi-cpufreq.c @@ -847,13 +847,11 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy) pr_debug("acpi_cpufreq_cpu_exit\n"); - if (data) { - policy->driver_data = NULL; - acpi_processor_unregister_performance(data->acpi_perf_cpu); - free_cpumask_var(data->freqdomain_cpus); - kfree(policy->freq_table); - kfree(data); - } + policy->driver_data = NULL; + acpi_processor_unregister_performance(data->acpi_perf_cpu); + free_cpumask_var(data->freqdomain_cpus); + kfree(policy->freq_table); + kfree(data); return 0; }