diff mbox series

[v5,4/4] power: supply: core: property to control reverse charge

Message ID f58e4cc6f5235d463d96c950f2af2b9a47920e9d.1595301250.git.huangqiwu@xiaomi.com (mailing list archive)
State Not Applicable, archived
Headers show
Series add some power supply properties about wireless/wired charging | expand

Commit Message

Qiwu Huang July 21, 2020, 5:59 a.m. UTC 
From: Qiwu Huang <huangqiwu@xiaomi.com>

Interface to control wireless reverse charge.
Supply reverse charge function when enabled.

Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
---
 Documentation/ABI/testing/sysfs-class-power | 12 ++++++++++++
 drivers/power/supply/power_supply_sysfs.c   |  1 +
 include/linux/power_supply.h                |  1 +
 3 files changed, 14 insertions(+)

Comments

Greg Kroah-Hartman July 21, 2020, 8:21 a.m. UTC | #1 
On Tue, Jul 21, 2020 at 01:59:37PM +0800, Qiwu Huang wrote:
> From: Qiwu Huang <huangqiwu@xiaomi.com>
> 
> Interface to control wireless reverse charge.
> Supply reverse charge function when enabled.
> 
> Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> ---
>  Documentation/ABI/testing/sysfs-class-power | 12 ++++++++++++
>  drivers/power/supply/power_supply_sysfs.c   |  1 +
>  include/linux/power_supply.h                |  1 +
>  3 files changed, 14 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> index 75ec7de2fe78..54647d6995d3 100644
> --- a/Documentation/ABI/testing/sysfs-class-power
> +++ b/Documentation/ABI/testing/sysfs-class-power
> @@ -767,3 +767,15 @@ Description:
>  
>  		Access: Read-Only
>  		Valid values: 0 - 100
> +
> +What:		/sys/class/power_supply/<supply_name>/reverse_chg_mode
> +Date:		Jul 2020
> +Contact:	Fei Jiang <jiangfei1@xiaomi.com>
> +Description:
> +		Some phones support wireless reverse charge function which charge other phones.

Replace "phones" with "devices"?

And shouldn't these lines be wrapped properly at 72 colums or so?

> +		The property supply interface to control wireless reverse charge.

I can't understand this sentance.

> +		If enabled, start TX mode and detect RX. Disabled when timeout or manual setting.

Can this be set, or is it just something to be read?

thanks,

greg k-h
Qiwu Huang July 21, 2020, 10:40 a.m. UTC | #2 
On Tue, Jul 21, 2020 at 4:21 PM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Tue, Jul 21, 2020 at 01:59:37PM +0800, Qiwu Huang wrote:
> > From: Qiwu Huang <huangqiwu@xiaomi.com>
> >
> > Interface to control wireless reverse charge.
> > Supply reverse charge function when enabled.
> >
> > Signed-off-by: Qiwu Huang <huangqiwu@xiaomi.com>
> > ---
> >  Documentation/ABI/testing/sysfs-class-power | 12 ++++++++++++
> >  drivers/power/supply/power_supply_sysfs.c   |  1 +
> >  include/linux/power_supply.h                |  1 +
> >  3 files changed, 14 insertions(+)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
> > index 75ec7de2fe78..54647d6995d3 100644
> > --- a/Documentation/ABI/testing/sysfs-class-power
> > +++ b/Documentation/ABI/testing/sysfs-class-power
> > @@ -767,3 +767,15 @@ Description:
> >
> >               Access: Read-Only
> >               Valid values: 0 - 100
> > +
> > +What:                /sys/class/power_supply/<supply_name>/reverse_chg_mode
> > +Date:                Jul 2020
> > +Contact:     Fei Jiang <jiangfei1@xiaomi.com>
> > +Description:
> > +             Some phones support wireless reverse charge function which charge other phones.
>
> Replace "phones" with "devices"?

 Yes,  devices better than phones

>
> And shouldn't these lines be wrapped properly at 72 colums or so?

Sorry, I will modify the format  to match this standard.


>
> > +             The property supply interface to control wireless reverse charge.
>
> I can't understand this sentance.

The property provider interface to enable/disable wireless reverse charge.

>
> > +             If enabled, start TX mode and detect RX. Disabled when timeout or manual setting.
>
> Can this be set, or is it just something to be read?

Sorry,I forgot the permission statement

Access: Read, Write




>
> thanks,
>
> greg k-h



--
Thanks

Qiwu
diff mbox series

Patch

diff --git a/Documentation/ABI/testing/sysfs-class-power b/Documentation/ABI/testing/sysfs-class-power
index 75ec7de2fe78..54647d6995d3 100644
--- a/Documentation/ABI/testing/sysfs-class-power
+++ b/Documentation/ABI/testing/sysfs-class-power
@@ -767,3 +767,15 @@  Description:
 
 		Access: Read-Only
 		Valid values: 0 - 100
+
+What:		/sys/class/power_supply/<supply_name>/reverse_chg_mode
+Date:		Jul 2020
+Contact:	Fei Jiang <jiangfei1@xiaomi.com>
+Description:
+		Some phones support wireless reverse charge function which charge other phones.
+		The property supply interface to control wireless reverse charge.
+		If enabled, start TX mode and detect RX. Disabled when timeout or manual setting.
+
+		Valid values:
+		- 1: enabled
+		- 0: disabled
diff --git a/drivers/power/supply/power_supply_sysfs.c b/drivers/power/supply/power_supply_sysfs.c
index e420a453095e..81916b6b6ccf 100644
--- a/drivers/power/supply/power_supply_sysfs.c
+++ b/drivers/power/supply/power_supply_sysfs.c
@@ -209,6 +209,7 @@  static struct power_supply_attr power_supply_attrs[] = {
 	POWER_SUPPLY_ATTR(QUICK_CHARGE_TYPE),
 	POWER_SUPPLY_ATTR(TX_ADAPTER),
 	POWER_SUPPLY_ATTR(SIGNAL_STRENGTH),
+	POWER_SUPPLY_ATTR(REVERSE_CHG_MODE),
 };
 
 static struct attribute *
diff --git a/include/linux/power_supply.h b/include/linux/power_supply.h
index 346c6c9c0737..a87ae1fff8d1 100644
--- a/include/linux/power_supply.h
+++ b/include/linux/power_supply.h
@@ -170,6 +170,7 @@  enum power_supply_property {
 	POWER_SUPPLY_PROP_QUICK_CHARGE_TYPE,
 	POWER_SUPPLY_PROP_TX_ADAPTER,
 	POWER_SUPPLY_PROP_SIGNAL_STRENGTH,
+	POWER_SUPPLY_PROP_REVERSE_CHG_MODE,
 };
 
 enum power_supply_type {