From patchwork Mon Jun 15 11:31:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Takashi Iwai X-Patchwork-Id: 6608411 X-Patchwork-Delegate: rjw@sisk.pl Return-Path: X-Original-To: patchwork-linux-pm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 987829F326 for ; Mon, 15 Jun 2015 11:31:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B755320562 for ; Mon, 15 Jun 2015 11:31:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 342CC2047C for ; Mon, 15 Jun 2015 11:31:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753987AbbFOLbH (ORCPT ); Mon, 15 Jun 2015 07:31:07 -0400 Received: from cantor2.suse.de ([195.135.220.15]:44735 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbbFOLbG (ORCPT ); Mon, 15 Jun 2015 07:31:06 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E390FABA5; Mon, 15 Jun 2015 11:31:04 +0000 (UTC) Date: Mon, 15 Jun 2015 13:31:04 +0200 Message-ID: From: Takashi Iwai To: Aaron Lu Cc: linux-pm@vger.kernel.org, Mark Scott , Benoit Goby , "Rafael J. Wysocki" Subject: Re: commit 70fea60d888d caused s2ram regression with WD disk In-Reply-To: <20150615025536.GA26473@aaronlu.sh.intel.com> References: <20150615025536.GA26473@aaronlu.sh.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP At Mon, 15 Jun 2015 10:55:36 +0800, Aaron Lu wrote: > > Hi, > > As explained by Takashi: > " > So this looks like the cause. The recent kernel has a watchdog for > async resume workers, and if it expires, it panics. This explains why > 3.12 worked; the watchdog was introduced since 3.13. > > The timeout length is unfortunately fixed in Kconfig, set to 12 as > default. And this seems too short. We should extend this to at least a > minute, I suppose. Also, it'd be better to be dynamically > configuratble. > " > https://bugzilla.opensuse.org/show_bug.cgi?id=934397#c5 > > The upstream bug page is here: > https://bugzilla.kernel.org/show_bug.cgi?id=91921 > Since Benoit isn't registered there, I write the email for discussion. Thanks Aaron for starting a thread. Below is a patch to make the default value a bit safer. I can submit another patch to add a boot option to change the timeout value, too, if anyone thinks it's worth. Just let me know. thanks, Takashi -- 8< -- From: Takashi Iwai Subject: [PATCH] PM: Increase default DPM watchdog timeout to 60 Many harddisks (mostly WD ones) have firmware problems and take too long, more than 10 seconds, to resume from suspend. And this often exceeds the default DPM watchdog timeout (12 seconds), resulting in a kernel panic out of sudden. Since most distros just take the default as is, we should give a bit more safer value. This patch increases the default value from 12 seconds to one minute, which has been confirmed to be long enough for such problematic disks. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=91921 Signed-off-by: Takashi Iwai --- kernel/power/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig index 7e01f78f0417..9e302315e33d 100644 --- a/kernel/power/Kconfig +++ b/kernel/power/Kconfig @@ -187,7 +187,7 @@ config DPM_WATCHDOG config DPM_WATCHDOG_TIMEOUT int "Watchdog timeout in seconds" range 1 120 - default 12 + default 60 depends on DPM_WATCHDOG config PM_TRACE