mbox series

[v4,0/2] Mdmonitor improvements

Message ID 20220606103213.12753-1-kinga.tanska@intel.com (mailing list archive)
Headers show
Series Mdmonitor improvements | expand

Message

Kinga Tanska June 6, 2022, 10:32 a.m. UTC
Changes in v4:
- fix place where is_mddev is calling
- no new changes in "Mdmonitor: Improve logging method" patch

Kinga Tanska (2):
  Mdmonitor: Fix segfault
  Mdmonitor: Improve logging method

 Monitor.c | 36 ++++++++++++++++++++++++------------
 mdadm.h   |  1 +
 mdopen.c  | 17 +++++++++++++++++
 util.c    |  2 +-
 4 files changed, 43 insertions(+), 13 deletions(-)

Comments

Jes Sorensen Sept. 29, 2022, 3:08 p.m. UTC | #1
On 6/6/22 06:32, Kinga Tanska wrote:
> Changes in v4:
> - fix place where is_mddev is calling
> - no new changes in "Mdmonitor: Improve logging method" patch
> 
> Kinga Tanska (2):
>   Mdmonitor: Fix segfault
>   Mdmonitor: Improve logging method
> 
>  Monitor.c | 36 ++++++++++++++++++++++++------------
>  mdadm.h   |  1 +
>  mdopen.c  | 17 +++++++++++++++++
>  util.c    |  2 +-
>  4 files changed, 43 insertions(+), 13 deletions(-)
> 

Coly,

I am curious why these are marked Changes-requested in patchwork as
there are no replies in the thread.

https://patchwork.kernel.org/project/linux-raid/patch/20220907125657.12192-2-mateusz.grzonka@intel.com/

Thanks,
Jes
Coly Li Sept. 29, 2022, 3:19 p.m. UTC | #2
> 2022年9月29日 23:08,Jes Sorensen <jes@trained-monkey.org> 写道:
> 
> On 6/6/22 06:32, Kinga Tanska wrote:
>> Changes in v4:
>> - fix place where is_mddev is calling
>> - no new changes in "Mdmonitor: Improve logging method" patch
>> 
>> Kinga Tanska (2):
>>  Mdmonitor: Fix segfault
>>  Mdmonitor: Improve logging method
>> 
>> Monitor.c | 36 ++++++++++++++++++++++++------------
>> mdadm.h   |  1 +
>> mdopen.c  | 17 +++++++++++++++++
>> util.c    |  2 +-
>> 4 files changed, 43 insertions(+), 13 deletions(-)
>> 
> 
> Coly,
> 
> I am curious why these are marked Changes-requested in patchwork as
> there are no replies in the thread.
> 
> https://patchwork.kernel.org/project/linux-raid/patch/20220907125657.12192-2-mateusz.grzonka@intel.com/

Hi Jes,

I noticed this too, and asked Mariusz offline why these patches disappeared from my delegation, and he didn’t know why neither. So I just continue to review this series regardless its patchwork state. This is something I am not familiar with, so the progress is a bit slow.

Thanks.

Coly Li
Jes Sorensen Sept. 29, 2022, 3:29 p.m. UTC | #3
On 9/29/22 11:19, Coly Li wrote:
> 
> 
>> 2022年9月29日 23:08,Jes Sorensen <jes@trained-monkey.org> 写道:
>> Coly,
>>
>> I am curious why these are marked Changes-requested in patchwork as
>> there are no replies in the thread.
>>
>> https://patchwork.kernel.org/project/linux-raid/patch/20220907125657.12192-2-mateusz.grzonka@intel.com/
> 
> Hi Jes,
> 
> I noticed this too, and asked Mariusz offline why these patches disappeared from my delegation, and he didn’t know why neither. So I just continue to review this series regardless its patchwork state. This is something I am not familiar with, so the progress is a bit slow.

No worries, I changed the marking to under review.

Thanks,
Jes