mbox series

[0/8] Fix checkpointing

Message ID 20240116112434.30705-1-mateusz.kusiak@intel.com (mailing list archive)
Headers show
Series Fix checkpointing | expand

Message

Mateusz Kusiak Jan. 16, 2024, 11:24 a.m. UTC
Currently there are multiple issues regarding checkpointing in mdadm.
This patchset fixes most of them.

Thanks,
Mateusz

Mateusz Kusiak (8):
  Remove hardcoded checkpoint interval checking
  monitor: refactor checkpoint update
  Super-intel: Fix first checkpoint restart
  Define sysfs max buffer size
  Replace "none" with macro
  super-intel: Remove inaccessible code
  Grow: Move update_tail assign to Grow_reshape()
  Add understanding output section in man

 Assemble.c    |  3 +-
 Build.c       |  4 +--
 Create.c      |  2 +-
 Grow.c        | 64 +++++++++++++++++++-------------------
 Incremental.c |  4 +--
 Manage.c      | 10 +++---
 Monitor.c     |  6 ++--
 config.c      |  2 +-
 managemon.c   |  6 ++--
 maps.c        |  4 +--
 mdadm.8.in    | 21 ++++++++++++-
 mdadm.c       |  7 ++---
 mdadm.h       | 18 +++++++++++
 monitor.c     | 85 ++++++++++++++++++++++-----------------------------
 msg.c         |  4 +--
 super-intel.c | 38 ++++++++---------------
 sysfs.c       | 12 ++++----
 util.c        |  2 +-
 18 files changed, 151 insertions(+), 141 deletions(-)

Comments

Mariusz Tkaczyk Jan. 17, 2024, 8:02 a.m. UTC | #1
On Tue, 16 Jan 2024 12:24:26 +0100
Mateusz Kusiak <mateusz.kusiak@intel.com> wrote:

> Currently there are multiple issues regarding checkpointing in mdadm.
> This patchset fixes most of them.
> 
> Thanks,
> Mateusz
> 

Hi Mateusz,
I would like to make a release soon, so I won't take them all for now because
risk is high.

For everyone interested in mdadm release, there are few medium risk regressions
in IMSM caused by:
https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?id=4dde420fc3e24077ab926f79674eaae1b71de10b
I will start considering a release after resolving them. I expected a patches
on ML within 2 weeks.

From this serie, I can take following patches earlier:

>   Define sysfs max buffer size
I think it is safe. I see this conflicting with another patchset I know you are
working on.

>   Replace "none" with macro
>   super-intel: Remove inaccessible code
These two are rather safe too.

and eventually (if there is no dependency in other patches):
>   Add understanding output section in man

Please consider dividing it into 2 series, or sending "Define sysfs max buffer
size" separately.

Thanks,
Mariusz

> Mateusz Kusiak (8):
>   Remove hardcoded checkpoint interval checking
>   monitor: refactor checkpoint update
>   Super-intel: Fix first checkpoint restart
>   Define sysfs max buffer size
>   Replace "none" with macro
>   super-intel: Remove inaccessible code
>   Grow: Move update_tail assign to Grow_reshape()
>   Add understanding output section in man
> 
>  Assemble.c    |  3 +-
>  Build.c       |  4 +--
>  Create.c      |  2 +-
>  Grow.c        | 64 +++++++++++++++++++-------------------
>  Incremental.c |  4 +--
>  Manage.c      | 10 +++---
>  Monitor.c     |  6 ++--
>  config.c      |  2 +-
>  managemon.c   |  6 ++--
>  maps.c        |  4 +--
>  mdadm.8.in    | 21 ++++++++++++-
>  mdadm.c       |  7 ++---
>  mdadm.h       | 18 +++++++++++
>  monitor.c     | 85 ++++++++++++++++++++++-----------------------------
>  msg.c         |  4 +--
>  super-intel.c | 38 ++++++++---------------
>  sysfs.c       | 12 ++++----
>  util.c        |  2 +-
>  18 files changed, 151 insertions(+), 141 deletions(-)
>