| Message ID | 20220609211130.5108-2-logang@deltatee.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Bug fixes and testing improvments | expand |
Hi Logan, Thanks for this patchset. I really appreciate effort you did here. On Thu, 9 Jun 2022 15:11:17 -0600 Logan Gunthorpe <logang@deltatee.com> wrote: > Running the test require building everything, but it seems to be > difficult to build the static version of mdadm now seeing there > is no readily available static udev library. > > There's no need to build it, so just remove it. I think that you want to remove it totally, right? What with following targets: everything-test install-static mdadm.static clear BTW. mdadm can be compiled without libudev dependency by setting DNO_LIBUDEV I'm fine with removing it but please did it globally. Please also remove mkinitramfs file. Thanks, Mariusz > > Signed-off-by: Logan Gunthorpe <logang@deltatee.com> > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index bf126033b841..f2f671cefe66 100644 > --- a/Makefile > +++ b/Makefile > @@ -182,7 +182,7 @@ check_rundir: > echo "***** or set CHECK_RUN_DIR=0"; exit 1; \ > fi > > -everything: all mdadm.static swap_super test_stripe raid6check \ > +everything: all swap_super test_stripe raid6check \ > mdadm.Os mdadm.O2 man > everything-test: all mdadm.static swap_super test_stripe \ > mdadm.Os mdadm.O2 man
On 2022-06-20 08:08, Mariusz Tkaczyk wrote: > Hi Logan, > Thanks for this patchset. I really appreciate effort you did here. > > On Thu, 9 Jun 2022 15:11:17 -0600 > Logan Gunthorpe <logang@deltatee.com> wrote: > >> Running the test require building everything, but it seems to be >> difficult to build the static version of mdadm now seeing there >> is no readily available static udev library. >> >> There's no need to build it, so just remove it. > > I think that you want to remove it totally, right? > > What with following targets: > everything-test > install-static > mdadm.static > clear I figured leaving the explicit targets (mdadm.static and install-static) would be fine so that if someone wants to, they can still build the static binary. Removing them from the 'everything' target was my intention seeing that's what the test scripts tell you to do. However I missed everything-test, so I'll make that change for v2 which I'll send shortly. Logan
diff --git a/Makefile b/Makefile index bf126033b841..f2f671cefe66 100644 --- a/Makefile +++ b/Makefile @@ -182,7 +182,7 @@ check_rundir: echo "***** or set CHECK_RUN_DIR=0"; exit 1; \ fi -everything: all mdadm.static swap_super test_stripe raid6check \ +everything: all swap_super test_stripe raid6check \ mdadm.Os mdadm.O2 man everything-test: all mdadm.static swap_super test_stripe \ mdadm.Os mdadm.O2 man
Running the test require building everything, but it seems to be difficult to build the static version of mdadm now seeing there is no readily available static udev library. There's no need to build it, so just remove it. Signed-off-by: Logan Gunthorpe <logang@deltatee.com> --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)