diff mbox series

[mdadm,v6,6/7] tests/00raid5-zero: Introduce test to exercise --write-zeros.

Message ID 20221123190954.95391-7-logang@deltatee.com (mailing list archive)
State Superseded, archived
Delegated to: Jes Sorensen
Headers show
Series Write Zeroes option for Creating Arrays | expand

Commit Message

Logan Gunthorpe Nov. 23, 2022, 7:09 p.m. UTC
Attempt to create a raid5 array with --write-zeros. If it is successful
check the array to ensure it is in sync.

If it is unsuccessful and an unsupported error is printed, skip the
test.

Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Kinga Tanska <kinga.tanska@linux.intel.com>
---
 tests/00raid5-zero | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 tests/00raid5-zero

Comments

Coly Li Feb. 24, 2023, 4:06 p.m. UTC | #1
On Wed, Nov 23, 2022 at 12:09:53PM -0700, Logan Gunthorpe wrote:
> Attempt to create a raid5 array with --write-zeros. If it is successful
> check the array to ensure it is in sync.
> 
> If it is unsuccessful and an unsupported error is printed, skip the
> test.
> 
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Acked-by: Kinga Tanska <kinga.tanska@linux.intel.com>

Acked-by: Coly Li <colyli@suse.de>

Thanks.

> ---
> tests/00raid5-zero | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 tests/00raid5-zero
> 
> diff --git a/tests/00raid5-zero b/tests/00raid5-zero
> new file mode 100644
> index 000000000000..7d0f05a12539
> --- /dev/null
> +++ b/tests/00raid5-zero
> @@ -0,0 +1,12 @@
> +
> +if mdadm -CfR $md0 -l 5 -n3 $dev0 $dev1 $dev2 --write-zeroes ; then
> +  check nosync
> +  echo check > /sys/block/md0/md/sync_action;
> +  check wait
> +elif grep "zeroing [^ ]* failed: Operation not supported" \
> +     $targetdir/stderr; then
> +  echo "write-zeros not supported, skipping"
> +else
> +  echo >&2 "ERROR: mdadm return failure without not supported message"
> +  exit 1
> +fi
> -- 
> 2.30.2
>
diff mbox series

Patch

diff --git a/tests/00raid5-zero b/tests/00raid5-zero
new file mode 100644
index 000000000000..7d0f05a12539
--- /dev/null
+++ b/tests/00raid5-zero
@@ -0,0 +1,12 @@ 
+
+if mdadm -CfR $md0 -l 5 -n3 $dev0 $dev1 $dev2 --write-zeroes ; then
+  check nosync
+  echo check > /sys/block/md0/md/sync_action;
+  check wait
+elif grep "zeroing [^ ]* failed: Operation not supported" \
+     $targetdir/stderr; then
+  echo "write-zeros not supported, skipping"
+else
+  echo >&2 "ERROR: mdadm return failure without not supported message"
+  exit 1
+fi