diff mbox series

[v4,2/3] md/raid10: fix wrong setting of max_corr_read_errors

Message ID 20230522072535.1523740-3-linan666@huaweicloud.com (mailing list archive)
State New, archived
Headers show
Series md: bugfix of writing raid sysfs | expand

Commit Message

Li Nan May 22, 2023, 7:25 a.m. UTC 
From: Li Nan <linan122@huawei.com>

There is no input check when echo md/max_read_errors and overflow might
occur. Add check of input number.

Fixes: 1e50915fe0bb ("raid: improve MD/raid10 handling of correctable read errors.")
Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/md/md.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/drivers/md/md.c b/drivers/md/md.c
index b2d69260b5b1..350094f1cb09 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -4478,6 +4478,8 @@  max_corrected_read_errors_store(struct mddev *mddev, const char *buf, size_t len
 	rv = kstrtouint(buf, 10, &n);
 	if (rv < 0)
 		return rv;
+	if (n > INT_MAX)
+		return -EINVAL;
 	atomic_set(&mddev->max_corr_read_errors, n);
 	return len;
 }