diff mbox series

[-next,7/7] md: don't check 'mddev->pers' and 'pers->quiesce' from suspend_lo_store()

Message ID 20230803132751.2741652-8-yukuai1@huaweicloud.com (mailing list archive)
State New, archived
Headers show
Series md: initialize 'active_io' while allocating | expand

Commit Message

Yu Kuai Aug. 3, 2023, 1:27 p.m. UTC 
From: Yu Kuai <yukuai3@huawei.com>

Now that mddev_suspend() doean't rely on 'mddev->pers' to be set, it's
safe to remove such checking.

This will also allow the array to be suspended even before the array
is ran.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/md/md.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
diff mbox series

Patch

diff --git a/drivers/md/md.c b/drivers/md/md.c
index a66e00b45be1..55a74d9b7457 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5192,18 +5192,13 @@  suspend_lo_store(struct mddev *mddev, const char *buf, size_t len)
 	err = mddev_lock(mddev);
 	if (err)
 		return err;
-	err = -EINVAL;
-	if (mddev->pers == NULL ||
-	    mddev->pers->quiesce == NULL)
-		goto unlock;
+
 	mddev_suspend(mddev);
 	mddev->suspend_lo = new;
 	mddev_resume(mddev);
 
-	err = 0;
-unlock:
 	mddev_unlock(mddev);
-	return err ?: len;
+	return len;
 }
 static struct md_sysfs_entry md_suspend_lo =
 __ATTR(suspend_lo, S_IRUGO|S_IWUSR, suspend_lo_show, suspend_lo_store);