diff mbox series

[-next,v2,26/28] md/md-linear: cleanup linear_add()

Message ID	20230828020021.2489641-27-yukuai1@huaweicloud.com (mailing list archive)
State	New, archived
Delegated to:	Song Liu
Headers	show Return-Path: <linux-raid-owner@vger.kernel.org> From: Yu Kuai <yukuai1@huaweicloud.com> To: agk@redhat.com, snitzer@kernel.org, dm-devel@redhat.com, song@kernel.org, xni@redhat.com Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, yukuai3@huawei.com, yukuai1@huaweicloud.com, yi.zhang@huawei.com, yangerkun@huawei.com Subject: [PATCH -next v2 26/28] md/md-linear: cleanup linear_add() Date: Mon, 28 Aug 2023 10:00:19 +0800 Message-Id: <20230828020021.2489641-27-yukuai1@huaweicloud.com> In-Reply-To: <20230828020021.2489641-1-yukuai1@huaweicloud.com> References: <20230828020021.2489641-1-yukuai1@huaweicloud.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	md: synchronize io with array reconfiguration \| expand [-next,v2,00/28] md: synchronize io with array reconfiguration [-next,v2,01/28] md: use READ_ONCE/WRITE_ONCE for 'suspend_lo' and 'suspend_hi' [-next,v2,02/28] md: use 'mddev->suspended' for is_md_suspended() [-next,v2,03/28] md: add new helpers to suspend/resume array [-next,v2,04/28] md: add new helpers to suspend/resume and lock/unlock array [-next,v2,05/28] md: use new apis to suspend array for suspend_lo/hi_store() [-next,v2,06/28] md: use new apis to suspend array for level_store() [-next,v2,07/28] md: use new apis to suspend array for serialize_policy_store() [-next,v2,08/28] md/dm-raid: use new apis to suspend array [-next,v2,09/28] md/md-bitmap: use new apis to suspend array for location_store() [-next,v2,10/28] md/raid5-cache: use READ_ONCE/WRITE_ONCE for 'conf->log' [-next,v2,11/28] md/raid5-cache: use new apis to suspend array for r5c_disable_writeback_async() [-next,v2,12/28] md/raid5-cache: use new apis to suspend array for r5c_journal_mode_store() [-next,v2,13/28] md/raid5: use new apis to suspend array for raid5_store_stripe_size() [-next,v2,14/28] md/raid5: use new apis to suspend array for raid5_store_skip_copy() [-next,v2,15/28] md/raid5: use new apis to suspend array for raid5_store_group_thread_cnt() [-next,v2,16/28] md/raid5: use new apis to suspend array for raid5_change_consistency_policy() [-next,v2,17/28] md/raid5: replace suspend with quiesce() callback [-next,v2,18/28] md: quiesce before md_kick_rdev_from_array() for md-cluster [-next,v2,19/28] md: use new apis to suspend array for ioctls involed array reconfiguration [-next,v2,20/28] md: use new apis to suspend array for adding/removing rdev from state_store() [-next,v2,21/28] md: use new apis to suspend array for bind_rdev_to_array() [-next,v2,22/28] md: use new apis to suspend array related to serial pool in state_store() [-next,v2,23/28] md: use new apis to suspend array in backlog_store() [-next,v2,24/28] md: suspend array in md_start_sync() if array need reconfiguration [-next,v2,25/28] md: cleanup mddev_create/destroy_serial_pool() [-next,v2,26/28] md/md-linear: cleanup linear_add() [-next,v2,27/28] md: remove old apis to suspend the array [-next,v2,28/28] md: rename __mddev_suspend/resume() back to mddev_suspend/resume()

Commit Message

Yu Kuai Aug. 28, 2023, 2 a.m. UTC

From: Yu Kuai <yukuai3@huawei.com>

Now that caller already suspend the array, there is no need to suspend
array in liner_add().

Note that mddev_suspend/resume() is not used anymore.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
 drivers/md/md-linear.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/md/md-linear.c b/drivers/md/md-linear.c
index 71ac99646827..66412397cef0 100644
--- a/drivers/md/md-linear.c
+++ b/drivers/md/md-linear.c
@@ -183,7 +183,6 @@  static int linear_add(struct mddev *mddev, struct md_rdev *rdev)
 	 * in linear_congested(), therefore kfree_rcu() is used to free
 	 * oldconf until no one uses it anymore.
 	 */
-	mddev_suspend(mddev);
 	oldconf = rcu_dereference_protected(mddev->private,
 			lockdep_is_held(&mddev->reconfig_mutex));
 	mddev->raid_disks++;
@@ -192,7 +191,6 @@  static int linear_add(struct mddev *mddev, struct md_rdev *rdev)
 	rcu_assign_pointer(mddev->private, newconf);
 	md_set_array_sectors(mddev, linear_size(mddev, 0, 0));
 	set_capacity_and_notify(mddev->gendisk, mddev->array_sectors);
-	mddev_resume(mddev);
 	kfree_rcu(oldconf, rcu);
 	return 0;
 }