| Message ID | 20240118103019.12385-4-mateusz.kusiak@intel.com (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Mariusz Tkaczyk |
| Headers | show |
| Series | Fix checkpointing - invasive | expand |
diff --git a/super-intel.c b/super-intel.c index 6a664a2e58d3..ebf43209e75d 100644 --- a/super-intel.c +++ b/super-intel.c @@ -8741,6 +8741,9 @@ static int imsm_set_array_state(struct active_array *a, int consistent) super->updates_pending++; } + if (a->prev_action == idle) + goto skip_mark_checkpoint; + mark_checkpoint: /* skip checkpointing for general migration, * it is controlled in mdadm
When imsm based array is stopped after reaching first checkpoint and then assembled, first checkpoint is reported as 0. This behaviour is valid only for initial checkpoint, if the array was stopped while performing some action. Last checkpoint value is not taken from metadata but always starts with 0 and it's incremented when sync_completed in sysfs changes. In simplification, read_and_act() is responsible for checkpoint updates and is executed each time sysfs checkpoint update happens. For first checkpoint it is executed twice and due to marking checkpoint before triggering any action on the array, it is impossible to read sync_completed from sysfs in just two iterations. The workaround to this is not marking any checkpoint for first sysfs checkpoint after RAID assembly, to preserve checkpoint value stored in metadata. Signed-off-by: Mateusz Kusiak <mateusz.kusiak@intel.com> --- super-intel.c | 3 +++ 1 file changed, 3 insertions(+)