[5/5] tests/01raid6integ.broken can be removed

Commit Message

Xiao Ni April 18, 2024, 10:23 a.m. UTC

01raid6integ can be run successfully with kernel 6.9.0-rc3.
So remove 01raid6integ.broken.

Signed-off-by: Xiao Ni <[e-mail]>
---
 tests/01raid6integ.broken | 7 -------
 1 file changed, 7 deletions(-)
 delete mode 100644 tests/01raid6integ.broken

Comments

Mariusz Tkaczyk April 19, 2024, 10:05 a.m. UTC | #1

On Thu, 18 Apr 2024 18:23:21 +0800
Xiao Ni <[e-mail]> wrote:

> 01raid6integ can be run successfully with kernel 6.9.0-rc3.
> So remove 01raid6integ.broken.
> 
> Signed-off-by: Xiao Ni <[e-mail]>
> ---
I don't follow the *.broken file concept. We could also describe that in comment
in the test, so LGTM for the changes.

If you want to, you can remove all *.broken files and add some comments
in test instead. If we have some tests failing marked as broken long time ago,
you can either remove those scenarios as we are obiously not interested in
fixing those scenarios.

Mariusz

Song Liu April 19, 2024, 3:57 p.m. UTC | #2

On Fri, Apr 19, 2024 at 3:06 AM Mariusz Tkaczyk
<[e-mail]> wrote:
>
> On Thu, 18 Apr 2024 18:23:21 +0800
> Xiao Ni <[e-mail]> wrote:
>
> > 01raid6integ can be run successfully with kernel 6.9.0-rc3.
> > So remove 01raid6integ.broken.
> >
> > Signed-off-by: Xiao Ni <[e-mail]>
> > ---
> I don't follow the *.broken file concept. We could also describe that in comment
> in the test, so LGTM for the changes.
>
> If you want to, you can remove all *.broken files and add some comments
> in test instead. If we have some tests failing marked as broken long time ago,
> you can either remove those scenarios as we are obiously not interested in
> fixing those scenarios.

test script has options to skip broken tests (--skip-broken,
--skip-always-broken).
If we remove all the .broken files, we need to update the script to handle
comments in the test file.

Thanks,
Song

Xiao Ni April 22, 2024, 1:54 p.m. UTC | #3

On Fri, Apr 19, 2024 at 11:58 PM Song Liu <[e-mail]> wrote:
>
> On Fri, Apr 19, 2024 at 3:06 AM Mariusz Tkaczyk
> <[e-mail]> wrote:
> >
> > On Thu, 18 Apr 2024 18:23:21 +0800
> > Xiao Ni <[e-mail]> wrote:
> >
> > > 01raid6integ can be run successfully with kernel 6.9.0-rc3.
> > > So remove 01raid6integ.broken.
> > >
> > > Signed-off-by: Xiao Ni <[e-mail]>
> > > ---
> > I don't follow the *.broken file concept. We could also describe that in comment
> > in the test, so LGTM for the changes.
> >
> > If you want to, you can remove all *.broken files and add some comments
> > in test instead. If we have some tests failing marked as broken long time ago,
> > you can either remove those scenarios as we are obiously not interested in
> > fixing those scenarios.
>
> test script has options to skip broken tests (--skip-broken,
> --skip-always-broken).
> If we remove all the .broken files, we need to update the script to handle
> comments in the test file.
>
> Thanks,
> Song
>

Hi all

I'll try to fix all the broken test cases this time and remove the *.broken

Thanks
Xiao

Mariusz Tkaczyk May 8, 2024, 8:37 a.m. UTC | #4

On Mon, 22 Apr 2024 21:54:14 +0800
Xiao Ni <[e-mail]> wrote:

> On Fri, Apr 19, 2024 at 11:58 PM Song Liu <[e-mail]> wrote:
> >
> > On Fri, Apr 19, 2024 at 3:06 AM Mariusz Tkaczyk
> > <[e-mail]> wrote:  
> > >
> > > On Thu, 18 Apr 2024 18:23:21 +0800
> > > Xiao Ni <[e-mail]> wrote:
> > >  
> > > > 01raid6integ can be run successfully with kernel 6.9.0-rc3.
> > > > So remove 01raid6integ.broken.
> > > >
> > > > Signed-off-by: Xiao Ni <[e-mail]>
> > > > ---  
> > > I don't follow the *.broken file concept. We could also describe that in
> > > comment in the test, so LGTM for the changes.
> > >
> > > If you want to, you can remove all *.broken files and add some comments
> > > in test instead. If we have some tests failing marked as broken long time
> > > ago, you can either remove those scenarios as we are obiously not
> > > interested in fixing those scenarios.  
> >
> > test script has options to skip broken tests (--skip-broken,
> > --skip-always-broken).
> > If we remove all the .broken files, we need to update the script to handle
> > comments in the test file.
> >
> > Thanks,
> > Song
> >  
> 
> Hi all
> 
> I'll try to fix all the broken test cases this time and remove the *.broken
> 
> Thanks
> Xiao
> 
> 

Anyway, this one removes one .broken file so applying!

Thanks,
Mariusz

Patch

diff --git a/tests/01raid6integ.broken b/tests/01raid6integ.broken
deleted file mode 100644
index 1df735f08c8c..000000000000
--- a/tests/01raid6integ.broken
+++ /dev/null
@@ -1,7 +0,0 @@ 
-fails infrequently
-
-Fails about 1 in 5 with a sha mismatch:
-
-    8286c2bc045ae2cfe9f8b7ae3a898fa25db6926f /dev/md0 does not match
-    a083a0738b58caab37fd568b91b177035ded37df /dev/md0 with /dev/loop2 and
-    /dev/loop3 missing