From patchwork Tue Nov 12 16:10:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 13872460 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29A96205148 for ; Tue, 12 Nov 2024 16:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731427844; cv=fail; b=GEXEGLfDHSLCfPsNoo1NLgwsAcwNqbvyhjBXZDPnJSW7h47AqU/l54l/ja5ZdXuz8vMkE51S1dt7fV9zI/957krriotO05lakNXVMpN5aqUYvXwXA90OCzHGtCCb/tzC46przP2ig5p37q4AXDRNQZSMKbKsfrNTuIa2AdJkdQ4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731427844; c=relaxed/simple; bh=GTOe7a7qJPCcV5ARy05NAf+z75sBt7LAUM3mOQdMhUo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: Content-Type:MIME-Version; b=SSFt7fTxXLz7aH0IMUdesHgRNZSExnex73mff+uzmy58MmI/PwQclsFIoAX+R+megVcJwl+jABWadLuQIobMDMoab14IjDvpF01pboOsCOiQthX1qGkU5q/UQcuhAxsucVV5QLdkhX672vhGgY5L/MNBx4m51jVbDI7hOORcwNU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=mM+mGrbS; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=FXw6H+by; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="mM+mGrbS"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="FXw6H+by" Received: from pps.filterd (m0246629.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4ACFNdvF008518; Tue, 12 Nov 2024 16:10:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2023-11-20; bh=dlrSVlWX6QLqGPQ+F7bKfzSxoO+BKzuz7C8fCrjU/Gk=; b= mM+mGrbSCwKnB570PkLcXlNhWCqwmnb2z42MNH53CATiccCXAlDTCpw6ysv6+N40 1klRZ99AoFCX23/mvJ2mtnWnqwHxDCe8HcQP93/dYJSJ2AWkgewodkEkHDYiEBxC eXEjsxI6y/FDMgmCGKm0rmCOv3mwD7MmtU3/sHLipNJPMubB+VlbW3KBBAV9QgqW 2JaeUbaec0WPmPPED7NL/FPCHgNpN0hZQq5yP9sPLaAMAghJ+pjTHHLDESGVLfcd xP1Kn6JR/IhrpNZKvDWzV9JsDJtxy0X3SHtl/FsPNPYs0by0XOOjCksWRYw7X8Xe FWnhC1Q2hWGG8sCak0KMJg== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 42t0n4vrg1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Nov 2024 16:10:37 +0000 (GMT) Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 4ACFvH9C001369; Tue, 12 Nov 2024 16:10:35 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2049.outbound.protection.outlook.com [104.47.70.49]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 42sx68c8wj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 12 Nov 2024 16:10:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=m0vDvFC6eRX34zuFo5i32GXD6ZzM/WCYpIk6WavEdgH+dHqxZxTMipmdt1AsOeK0L/saIRlMu+hXrEcLkeC9IQRPXGA+UEnFVYb3URZ7RJlUyFvEXOsdktvH0HBp8asoDR5Nfqb1UyMyA3Z8nH4AojARjebbO27HiJn6EUDZjyOSfi85MYMB9asYtGBHsBHT6GZbDUSYtce/c0jzj2VG/UkiyJvsf1E9SOg9iL1UJWrKQQr/A8E5dO5jds8ehOvBuWibIr7qM25cVXlGQYF/GchReKL6tvAi3Zy37UkS1+6HX9j0BJsNhMGiipbN+bj/tmp9iSQhXf7GxZ4y89knKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dlrSVlWX6QLqGPQ+F7bKfzSxoO+BKzuz7C8fCrjU/Gk=; b=KayJ6RI4t9ZUyZdJUBHN4/2b1UhK1+wiuC+ro0/FKuzNVYFb7y1OBzp5rmtrkwPGEFmBGRUisHGjMEactRleKkcc+AJg6zwNu5gWOz1Kh4hiiuPj8VF/5yOVjt8BELClX2jC9aXbW3cagmiUtUVKBm3m7reHNJO1ylcTOhmOKZZb10VY6INz4/uZl2HMFs/pc472qa3zOanfHkIAWdPXsIpqeD7faHCCMGlyKEjF8kVvNuMcT3VRaWXyJ5MWeK6tQrg5WK6mPw+QEyQx8Ba6B25Vtyv1kH79KrMpFaH8sZxKBUlBlTJCvtVqkilK43Wq6lKL3QYraarmtV7NXX9ioA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dlrSVlWX6QLqGPQ+F7bKfzSxoO+BKzuz7C8fCrjU/Gk=; b=FXw6H+byKP0mfybqhLqYwFDF8C25eL0GUPpBNTuljXHKMps2loPmnDWyucsD6K61ThbzDV1RXQFkc94Bxh12ho7d3U1EyupfSVN02YoWUdtB5yT+HDv/6oukbk/sMDE70ndXwFQg+zbfNnRMyWMOEn3zyd4aOQIixL9T/vBkHTM= Received: from DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) by MW5PR10MB5761.namprd10.prod.outlook.com (2603:10b6:303:19a::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Tue, 12 Nov 2024 16:10:33 +0000 Received: from DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088]) by DM6PR10MB4313.namprd10.prod.outlook.com ([fe80::4f45:f4ab:121:e088%5]) with mapi id 15.20.8137.027; Tue, 12 Nov 2024 16:10:33 +0000 From: John Garry To: song@kernel.org, yukuai3@huawei.com Cc: linux-raid@vger.kernel.org, John Garry Subject: [PATCH 1/2] md/raid5: Increase r5conf.cache_name size Date: Tue, 12 Nov 2024 16:10:18 +0000 Message-Id: <20241112161019.4154616-2-john.g.garry@oracle.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20241112161019.4154616-1-john.g.garry@oracle.com> References: <20241112161019.4154616-1-john.g.garry@oracle.com> X-ClientProxiedBy: LO6P265CA0011.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:339::17) To DM6PR10MB4313.namprd10.prod.outlook.com (2603:10b6:5:212::20) Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4313:EE_|MW5PR10MB5761:EE_ X-MS-Office365-Filtering-Correlation-Id: 44c66ee0-14e1-44c4-8c6c-08dd03348947 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?q?MgLK81x4CHEwxdloqwYX0KeTegxZciC?= =?utf-8?q?wMR1G+HUnhheZYKKyNUDLhUlevj5FWgvTu3CZmiPCeAoICqzgoyVDagnDuLXjLFV+?= =?utf-8?q?ARz6QkewA7dA6AcCb+Iuha4ZISBMKMMLfYd8etWCoxysr5/ljacm3yxhxjUKMNZWB?= =?utf-8?q?Z7GhagzL7nSp6vylAe37Do8ox/xfieSVsfMxY+XdYts/kKXYXp88awyqeQPExahwQ?= =?utf-8?q?VfSIGSpnJ89GSq+1asPySyH3gc7e0efs8VRaUmcP11oLjbIhqknjRTEUoUdSWKvPr?= =?utf-8?q?YjLaQP2NKAXXw4kioOIO8npmuQhpcV/nJ8AkPzXbXbff9MylT6m3yrHxyJzEfm9EX?= =?utf-8?q?EL+RVdNY2S/mj4+kp31QKzciNBwtxyb2WwUBUQ5wE45DnTf+UbdKPoXNkgOmXg7gL?= =?utf-8?q?nFHMaWT8XWC/pakzZ+dexuDO613FupbhufCj+PkznxBL80Dqy6se57l6e3usO+0hy?= =?utf-8?q?z/JMvb4anzq+wbHRMQjEl4MT8gLls6suX0RN9S+70mDJEvPKD9UwndTw9C868fcld?= =?utf-8?q?K4YmP04s0v+7KYxu6vpSn06PAQ4AlDivpxw/MvljwRR+eO28+iPPIKRwssTN/gZkc?= =?utf-8?q?p/n2OjjyPCU7Tu/NBG5Uhpu8WiePiFwHbiZNPV2yMlZONQzLCJQ/DHLwRBKvwOLay?= =?utf-8?q?3qPLDtUgi5zx6u3Cim2E6AfBHTiHQoEFfFNqd5vKxGhUHzwrbcBv7aKQf0Gjt8Gtl?= =?utf-8?q?BJjee08gaZ4QOtdcyOB/fFeLGR8bB389O/4Aobx/29/M1UnXlRXpzdTkSEHtQDm/7?= =?utf-8?q?6gT10Up+tZmNyXbuUpBHmCFDMqLTHMTK0w28xFOLTH7Np/iJtRUOYRfDHZ/hkW5Dn?= =?utf-8?q?avauZAtSz/ONj50uFBMOeYSTkeYYFZeP13rzuyTNhzPXE+r6ldaiT1Gj2FGl/vdYW?= =?utf-8?q?DCfDcHC8Zuw15GG2Jzj3iAUJg28cehv4SQo0cWAANQEzA2ibBj6QE9rbzn/eso4/B?= =?utf-8?q?yvyH1TMQOyNdpQZwk4fBE4ISez/EepDKk2/uNhA0iDhD+Z7UGq7Q4Qj7zXwsCNwsb?= =?utf-8?q?mxAWRZW3jvfD03Qe50eTytzWsr93lU/96NyKq9+/J/Kc6+aCUypn0TOxUBkYdVpVe?= =?utf-8?q?SaO5kOyqiL/1V61G0/6173ijCP1ja4CrNBvV/nVag4K5C252HnoWRGKbaiPd6inPm?= =?utf-8?q?yZ6l6uMHhSnG9eg/ew+rw27qyjI+d8HDmNiK7KaXaEszcl955QUSHnh4Bhxj6kSYH?= =?utf-8?q?f/5la1L2HdFu6f7x4lWip/iTBxmajrRBOboQk30B/X8kopmBhicc6aa4/oAPePopK?= =?utf-8?q?M8RPDAT2aGMgY?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4313.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?6Iuf5MSWBgGL7qOlcyqmGoF8UPpU?= =?utf-8?q?Svh4kB1C6sdyP4aspyfluJ1o9L2E6TAyaUoLn1+ogGzlX+OcXJBaGt5md7Ch4v1ZG?= =?utf-8?q?cMlyvZIfMHuLhhy01inguduolaFw+rV8CUp+Z3QCoaqnF0wEE9ZqnFu7GQal70yTb?= =?utf-8?q?ph0tefQgpvpBxQ/nG93J61mV/jsi5UoBF52wHdn0xit/6I12bw09c5nZRBV2yQKPp?= =?utf-8?q?7EbDNNUcI8ijLs13oiDXd4BKXFdBLwZvYKJ+0YYnaGhai6BbQjoa03tpsuF8dQzg6?= =?utf-8?q?N3kWfIJRj6EyCuY1VClKY8H4YnXhLGIBJ457iELkJpYEDlOJE1FsSbJ5wRdLK9ZN5?= =?utf-8?q?82IgJMos3ErT5SaL3s0+YSjocuWemETd89m+sRBAC9pa1MlR6c+tQCsOSzjXSUxak?= =?utf-8?q?1MPTqVEw0v7UVdUz0zdnr1HUAy/7rkG5LpYQDDtQKgX5oKMn7pAlOItu0U3nmP8o0?= =?utf-8?q?ZumZwoZAJNa9fGinNuQfgH8adfMXtUZ8UINWTGcxKi1omz+UhKBBsUgS2AE1R9FV/?= =?utf-8?q?ikySLx7KNdWFey0ftr4KJm4idW70x+ZlksQCsq4iA09P7fWkIg+sYjEFIK4ZmHIvm?= =?utf-8?q?qPqK4s2wuvT62biB8ddNDSXyQNNxuqbJPvghLkf9g1HRC31nNI2n2AMBHJk1ys2ns?= =?utf-8?q?gm0srNzSW1qW05DhgkMtGcVG7AbeXA9oLHNGCPhxHQgXeO78tiLCmjdlu7lZgerqP?= =?utf-8?q?GPPETcCrVndFeTmZe5UayQVw0S5i3uoHegUQuWmEFvugbe+O444dP4imJe5dFvmmU?= =?utf-8?q?S1zN7EL/P7a8weO22ffb2oX6lpD/U1BncqgRZ8xEORMgwgC6u1PvFMYbk01CybOZw?= =?utf-8?q?A7Cb4xoNDSQKV2BH/nsr2zYIhwd0E7IzbGxFebRwcqY78oiW4U3BLr8K3O2CkpbUf?= =?utf-8?q?pyBLYNxuVly34FRsL6aPiKjTxWX0EVcJiQ6UXChX8gjoFTWuNaf6d2CHmTZY0ErbK?= =?utf-8?q?J0RKLOQALj3atDVsjsv0L/hg8wQcZCu7bOKZRSGXtLYxEaFwRF0vmVGteqgpZKbTa?= =?utf-8?q?z/GtJUudovOGSubStcRaWU9BJPXQwz3S+s6qOyDRayurJT1tMVFOUbkhp2Bdl4Kci?= =?utf-8?q?kfeRcerYr55Kai79SNbm/U/1oj+gK9kyX2VXp1uv3PGZSxr9FXvJNk/Zt8D42TYZF?= =?utf-8?q?o5RmEGv1ksNmP5SQY4Xp3ZXNToHboXWFJd0sMDoXeLjEMBziji4M3WeisCww0O06s?= =?utf-8?q?tp5lOd4zBanVBhQkjoiZFrQ/zITlXnXAMwF/IogtfEdcfSuVM1Rl0R/RMIZPdDkAo?= =?utf-8?q?gIpiffwYTQDB6u8mdx3Ha76jSzvs1eEY9jeEQFChzBqGA4rcpRGZLBANY46AbmAAw?= =?utf-8?q?LmBwIsEZEzxvawqKZMkQ6sTbx0QMDqF298FIB82QNo95yW5E7jYmRTDnzgtZ3cDl6?= =?utf-8?q?GwxNo6IArVM/NBytR8PZJ9VRc+g0qnBe0RZBK5tX2wyMq/xLJZjpBzOH/cZ/pFk4b?= =?utf-8?q?dLuTOPAq6lnL+/UFnn6MGSsfebP6e4tThNaZERYrn/fobVYee3ft8a551W+4ZX+lU?= =?utf-8?q?M58rmk4wuZ8VuVqFCqDN/Q80zGkapchKNQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 4Zt12Awm9CCfS3vzLzsB/TqK5WJRxy441yJsEAigtXrodgRzfDhr12m15IfSI60gcSk+UQTtOzMth1QqTYYdviJWK29sCei1gmWc58GBujFIFmaqybbpAribtd6AnpQcIcKQPiFMtJK1Smp/gUgZyvYqWfftRUF2KBJ995F8sgKKjzfMLgm4AenX/uBA1PpBPnOUJ6FbG49UtkxpUHAqzrYU1KzM4n/KY0z8Mdebvyp0KW31hiPYq9tOsqRs7LngwyRv6dLnhz+hZ1dukL3HCWS0I06XQaZPfG6YfR2w1zTl2JVgBLIA2y+1x53m95ht5zNzIlza2l6+tfiliMcCKT+lmz+nrlHy7amkpP0KIMQ7G9qxpPSdMHZBGI4hY7q0AoNQygD4geSchVQCZbasfH/CHK6cGNSyIvZ53sY2z1nb+TiqA2PDr23xApWnCmZtk4+wak4zJXZj1sDOLc7nEnF2d+tsfYvFQ15ZssdbtyathByJ0GoLy4YVL+WBLSd2nEvUMpzwkoSAV3vigFwvttV47VGD8TbjIfpFSeLH2m3YiidX/wspzm4nSX+bsZEIvDq6MxxyqIljmjLEeJgUld1bV5suhiyq8SYoQeyVAxM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44c66ee0-14e1-44c4-8c6c-08dd03348947 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2024 16:10:33.4022 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PE9tFSy4L6p64McyCzQ57pFrMFeagy3i+2L8QzngLrq2WRS0vFP5GO8jKF0zyNmM+9USW0GBr17zn32gUL821A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR10MB5761 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-11-12_06,2024-11-12_02,2024-09-30_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 suspectscore=0 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2409260000 definitions=main-2411120129 X-Proofpoint-ORIG-GUID: ppvZjPYTeUQbeRyd9x61mB9GUrv_gHcN X-Proofpoint-GUID: ppvZjPYTeUQbeRyd9x61mB9GUrv_gHcN For compiling with W=1, the following warning can be seen: drivers/md/raid5.c: In function ‘setup_conf’: drivers/md/raid5.c:2423:12: error: ‘%s’ directive output may be truncated writing up to 31 bytes into a region of size between 16 and 26 [-Werror=format-truncation=] "raid%d-%s", conf->level, mdname(conf->mddev)); ^~ drivers/md/raid5.c:2422:3: note: ‘snprintf’ output between 7 and 48 bytes into a destination of size 32 snprintf(conf->cache_name[0], namelen, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ "raid%d-%s", conf->level, mdname(conf->mddev)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors Increase the array size to avoid this warning. Signed-off-by: John Garry --- drivers/md/raid5.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid5.h b/drivers/md/raid5.h index 896ecfc4afa6..3da5b412190b 100644 --- a/drivers/md/raid5.h +++ b/drivers/md/raid5.h @@ -633,7 +633,7 @@ struct r5conf { * two caches. */ int active_name; - char cache_name[2][32]; + char cache_name[2][38]; struct kmem_cache *slab_cache; /* for allocating stripes */ struct mutex cache_size_mutex; /* Protect changes to cache size */