From patchwork Sat Jan 25 01:26:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug V Johnson X-Patchwork-Id: 13950098 Received: from mail.bonnevilleinformatics.com (mail.bn-i.net [69.92.154.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F268443AA9; Sat, 25 Jan 2025 01:33:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=69.92.154.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737768813; cv=none; b=N4tS+zvC4iJD6n8zz7f5G/IQf9F/9NqzppTfvzr7l1o+D1DEy4aS4Hd9O9cuLV2/UxZqrrYmraZRdIDxty4bK2MsMbFeqxkP67rwLdONbebFLEWZO5eD5Fu55EctyXvAXls9ww5Ix5LzpE2NwgY2mTgswDKgFMTklvcyp54cs9g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737768813; c=relaxed/simple; bh=7lRd6a4wz9Eo0UDhWcRed5VN7igKc8NSr9/wePVU6Mw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nZoGmilFIpRH7QjQlMVUIahJ16ebHDa+V1MdgziasaLCWXjX4AI01LiF1tJGvROCa0gOEl+t7XrUEFvOEEQN4QLnHGPRGffrBFrSTTyM+TG4A1mnRHDPAJspD93uoW+BF5tG8TO4z4/8rIRzXKK5h6WVgWSinygWF9CKZUTIrd8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=dougvj.net; spf=pass smtp.mailfrom=dougvj.net; dkim=pass (1024-bit key) header.d=dougvj.net header.i=@dougvj.net header.b=E9LU+PkW; arc=none smtp.client-ip=69.92.154.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=dougvj.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dougvj.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=dougvj.net header.i=@dougvj.net header.b="E9LU+PkW" From: Doug V Johnson DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dougvj.net; s=dkim; t=1737768459; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xuajq9/1sODhnb2N844HTk+p7pzivVzQBs6mVSrev/g=; b=E9LU+PkW82pkF8NzoxNYvwsezc0NV+U0dPKwwr2yt4VKriRnPqZW9L7EIOuDcgzhnHiwLK 32/Y5caWX/9o0ZIjHkQYfqpsHU3b8NScVhloNiWPh9akR+H2B4ADTNb/kM4mljgfUAwwIg 4ZSJ3fSfJhSfkFPx/BeSv3G/shDbNiI= Authentication-Results: mail.bonnevilleinformatics.com; auth=pass smtp.mailfrom=dougvj@dougvj.net To: Cc: Doug Johnson , Doug V Johnson , Song Liu , Yu Kuai , linux-raid@vger.kernel.org (open list:SOFTWARE RAID (Multiple Disks) SUPPORT), linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/2] md/raid5: warn when failing a read due to bad blocks metadata Date: Fri, 24 Jan 2025 18:26:58 -0700 Message-ID: <20250125012702.18773-2-dougvj@dougvj.net> In-Reply-To: <20250125012702.18773-1-dougvj@dougvj.net> References: <20250125012702.18773-1-dougvj@dougvj.net> Precedence: bulk X-Mailing-List: linux-raid@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Spamd-Bar: ----- It's easy to suspect that there might be some underlying hardware failures or similar issues when userspace receives a Buffer I/O error from a raid device. In order to hopefully send more sysadmins on the right track, lets report that a read failed at least in part due to bad blocks in the bad block list on device metadata. There are real world examples where bad block lists accidentally get propagated or copied around, so having this warning helps mitigate the consequences Signed-off-by: Doug V Johnson --- drivers/md/raid5.c | 10 +++++++++- drivers/md/raid5.h | 2 +- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 0ae9ac695d8e..5d80e9bcbd6f 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -3671,7 +3671,14 @@ handle_failed_stripe(struct r5conf *conf, struct stripe_head *sh, sh->dev[i].sector + RAID5_STRIPE_SECTORS(conf)) { struct bio *nextbi = r5_next_bio(conf, bi, sh->dev[i].sector); - + /* If we recorded bad blocks from the metadata + * on any of the devices then report this to + * userspace in case anyone might suspect + * something more fundamental instead + */ + if (s->bad_blocks) + pr_warn_ratelimited("%s: read encountered block in device bad block list.", + mdname(conf->mddev)); bio_io_error(bi); bi = nextbi; } @@ -4682,6 +4689,7 @@ static void analyse_stripe(struct stripe_head *sh, struct stripe_head_state *s) if (rdev) { is_bad = rdev_has_badblock(rdev, sh->sector, RAID5_STRIPE_SECTORS(conf)); + s->bad_blocks++; if (s->blocked_rdev == NULL) { if (is_bad < 0) set_bit(BlockedBadBlocks, &rdev->flags); diff --git a/drivers/md/raid5.h b/drivers/md/raid5.h index eafc6e9ed6ee..c755c321ae36 100644 --- a/drivers/md/raid5.h +++ b/drivers/md/raid5.h @@ -282,7 +282,7 @@ struct stripe_head_state { * read all devices, just the replacement targets. */ int syncing, expanding, expanded, replacing; - int locked, uptodate, to_read, to_write, failed, written; + int locked, uptodate, to_read, to_write, failed, written, bad_blocks; int to_fill, compute, req_compute, non_overwrite; int injournal, just_cached; int failed_num[2];