diff mbox series

dm-raid: fix KASAN warning in raid5_add_disks

Message ID alpine.LRH.2.02.2206291340050.18482@file01.intranet.prod.int.rdu2.redhat.com (mailing list archive)
State New, archived
Delegated to: Song Liu
Headers show
Series dm-raid: fix KASAN warning in raid5_add_disks | expand

Commit Message

Mikulas Patocka June 29, 2022, 5:40 p.m. UTC
There's a KASAN warning in raid5_add_disk when running the LVM testsuite.
The warning happens in the test
lvconvert-raid-reshape-linear_to_raid6-single-type.sh. We fix the warning
by verifying that rdev->saved_raid_disk is within limits.

Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: stable@vger.kernel.org

---
 drivers/md/raid5.c |    1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

Index: linux-2.6/drivers/md/raid5.c
===================================================================
--- linux-2.6.orig/drivers/md/raid5.c	2022-06-24 18:45:53.000000000 +0200
+++ linux-2.6/drivers/md/raid5.c	2022-06-24 18:46:59.000000000 +0200
@@ -8065,6 +8065,7 @@  static int raid5_add_disk(struct mddev *
 	 */
 	if (rdev->saved_raid_disk >= 0 &&
 	    rdev->saved_raid_disk >= first &&
+	    rdev->saved_raid_disk <= last &&
 	    conf->disks[rdev->saved_raid_disk].rdev == NULL)
 		first = rdev->saved_raid_disk;