From patchwork Wed Oct 31 12:42:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shamir Rabinovitch X-Patchwork-Id: 10662599 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ECABF13BF for ; Wed, 31 Oct 2018 12:43:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D947A2AAFB for ; Wed, 31 Oct 2018 12:43:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CD5412AC23; Wed, 31 Oct 2018 12:43:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5D8A92AAFB for ; Wed, 31 Oct 2018 12:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729034AbeJaVkw (ORCPT ); Wed, 31 Oct 2018 17:40:52 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:51926 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729033AbeJaVkv (ORCPT ); Wed, 31 Oct 2018 17:40:51 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w9VCguE7184737; Wed, 31 Oct 2018 12:42:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id; s=corp-2018-07-02; bh=g1t9vqaHboDOGFrbtBqnkxICEi8WXG/4oqRe1fnG3hE=; b=iRZCKmkKzxTDsax+HdqwyhF8tWsDO/UHmMzWzDsVXAyZT+YiStwgZMx4WMgfkaZI0iO5 jomxcuUYCyHPt0CZB+DSs3FcJHgnzsyzKr5CDNjFx6XCuzmcOfqEnccJZISsIQddhNns DNbqhk2nbRWU51dryZ8vJODZXBLIQgLsGdb7moFiat8KH3OTl92Ho0ScRW0ez2proqiy zb7ZNle09VaJproNXm6e+BYRTnK04faoSdClPg0tzzE1tk0b9p1rOSnvhvmLVPeBgSEp P/MppQyRv6kiAkDaxqHYIfNmxS8PC5RquDI3C9PtigoWRrM91/tiPHQsviofRkkZrcAC yw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2120.oracle.com with ESMTP id 2ncgnr2n4t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Oct 2018 12:42:56 +0000 Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w9VCgtQn008425 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 Oct 2018 12:42:55 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w9VCgsTp024125; Wed, 31 Oct 2018 12:42:54 GMT Received: from localhost.localdomain (/10.175.5.115) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 31 Oct 2018 05:42:53 -0700 From: Shamir Rabinovitch To: linux-rdma@vger.kernel.org Cc: dledford@redhat.com, jgg@ziepe.ca, leon@kernel.org, santosh.shilimkar@oracle.com, shamir.rabinovitch@oracle.com Subject: [PATCH v3 0/5] figure uverbs/kernel ib_pd w/o using ib_pd uobject Date: Wed, 31 Oct 2018 14:42:37 +0200 Message-Id: <20181031124242.24239-1-shamir.rabinovitch@oracle.com> X-Mailer: git-send-email 2.17.1 X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9062 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=1 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=643 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1807170000 definitions=main-1810310105 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This change has 2 steps. First step is to change the resource tracker so it will not use ib_x uobject pointer to figure if ib_x object was created by uverbs/kernel. The second step is to use the resource tracker ability to tell if ib_pd was created by uverbs/kernel and replace every place in the code where the code test for valid ib_pd uobject pointer just to tell if the ib_pd was created by uverbs/kernel. This series is the first step toward releasing the code from the dependency in the uobject pointer in the ib_pd. This change is required before we can move to shared ib_pd model. Changelog: v1->v2: * Patch 1: Comments from Jason & Leon - Fix bool assign - Add rdma_restrack_kadd, rdma_restrack_uadd - Remove res_is_user - Fix rdma_is_kernel_res * Patch 2: Comments from Jason - Fix rdma_is_user_pd * Patch 3: Comments from Jason to add cleanup patch * Patch 4: Comments from Jason which include the missing patch 3 v2->v3: * Patch 1: Add patch to fix mlx5_core issue where restrack was not initialized for some ib_x objects allocated by the driver. * Patch 5: Fixed hns build issue reported by kbuild Shamir Rabinovitch (5): IB/mlx5: device resources must be created from ib_core RDMA/restrack: resource-tracker should not use uobject pointers IB/verbs: Add rdma_is_user_pd function IB/hw: cleanup of incorrect pd->uobject usage IB/{hw,sw}: use rdma_is_user_pd instead of pd uobject pointer drivers/infiniband/core/cma.c | 2 +- drivers/infiniband/core/core_priv.h | 5 ++- drivers/infiniband/core/cq.c | 2 +- drivers/infiniband/core/restrack.c | 40 +++++++++++------------- drivers/infiniband/core/uverbs_cmd.c | 6 ++-- drivers/infiniband/core/uverbs_std_types_cq.c | 2 +- drivers/infiniband/core/verbs.c | 6 ++-- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 4 +-- drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 3 +- drivers/infiniband/hw/hns/hns_roce_qp.c | 17 ++++++----- drivers/infiniband/hw/i40iw/i40iw_verbs.c | 44 +++++++++++++-------------- drivers/infiniband/hw/mlx4/qp.c | 17 ++++++----- drivers/infiniband/hw/mlx4/srq.c | 10 +++--- drivers/infiniband/hw/mlx5/main.c | 30 +++++++++--------- drivers/infiniband/hw/mlx5/qp.c | 8 ++--- drivers/infiniband/hw/mlx5/srq.c | 8 ++--- drivers/infiniband/hw/mthca/mthca_provider.c | 10 +++--- drivers/infiniband/hw/mthca/mthca_qp.c | 7 +++-- drivers/infiniband/hw/mthca/mthca_srq.c | 8 ++--- drivers/infiniband/hw/nes/nes_verbs.c | 7 +++-- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 2 +- drivers/infiniband/hw/qedr/verbs.c | 4 +-- drivers/infiniband/hw/vmw_pvrdma/pvrdma_qp.c | 2 +- drivers/infiniband/hw/vmw_pvrdma/pvrdma_srq.c | 2 +- drivers/infiniband/sw/rxe/rxe_qp.c | 3 +- include/rdma/ib_verbs.h | 5 +++ include/rdma/restrack.h | 16 ++++++++-- 28 files changed, 144 insertions(+), 128 deletions(-)