From patchwork Fri Mar 8 19:55:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jason Gunthorpe X-Patchwork-Id: 10845375 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7842D17E9 for ; Fri, 8 Mar 2019 19:55:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 62E0D2DE17 for ; Fri, 8 Mar 2019 19:55:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 573272FE8A; Fri, 8 Mar 2019 19:55:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E44292FE1E for ; Fri, 8 Mar 2019 19:55:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbfCHTza (ORCPT ); Fri, 8 Mar 2019 14:55:30 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:34719 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726831AbfCHTza (ORCPT ); Fri, 8 Mar 2019 14:55:30 -0500 Received: by mail-qt1-f195.google.com with SMTP id x20so4962599qto.1 for ; Fri, 08 Mar 2019 11:55:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d0fWlFpHm0F8TGWiAJVrvicbZze4eV0ydlWw1FPZfbw=; b=N7sUqka1VwztiQ8kN03qsDu5a9eZMnfEb3cFuH1I6ai5gGe94cjNuDFbxeAXSEFYz1 gIRDVYuLmCyZlBzRcIvVofOE+nInLZnAnZa8RMXMOPwkpjVzHLhLu0zWrm2YL6MF0C10 9py5qrA8LS91Zti589FeaZgkHmcSfj4rkDONBWnm8YYnLOhAXfzEMRIKHISZZXeKqRmH CkRoWeR8laNi9ej9MGsn5TeKI/CRdCo9YhNQRDhU6S4hIpWh07g5jQv6N/EBeNtpx9xM ktXoK3jyQYRsN6tpMn1IkQrBNFRBeShFqRToOEM9MQ2e6y48tAvQRlf8+pjF46YlOFoW ockQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=d0fWlFpHm0F8TGWiAJVrvicbZze4eV0ydlWw1FPZfbw=; b=B+3ukDzel//E6mAMNVUP+M7LzUyIJpRue66NVq6/r38ibuc9YATA1s/Cf8goVN67sq xEbsD+5i6wIERKt7DsP0A9o7HeRFvJbOWrkwBGZIzriu4fKUWfTpfTmsCD8Xi2ipfS17 CP+IHR4wx4msQWQq48fJBvN0TNAqoJyOdsl8c7ntDHz1aevG902N+JIyPx2shtuBrGbB f2lyJubjI2VuuHZoh6Txom9jGzNFgCm6aeaqHNFA4MBFq+4Ts1hBpf/po6Mk1CexQpl7 oYYunM3ZMfqAn1E/3fMlDCg9RA+zOfbCPKsKPQMZxDHHWC31gaEjM29lQE63yLcZ8qZE en9g== X-Gm-Message-State: APjAAAVro1+cm5H/wVyGnsN+wZUroaJYtI4FdrjyPA7QAumJvHhFyJYH 6FK/XBHWjQCBmS+tyLuT+p2ZVvoCPcjt6g== X-Google-Smtp-Source: APXvYqyFARIja8BTkf5tKqFUcbwQgAOdH1relS4gSGohGYutNhGKTWtv2gFHm08mBsMfQSue+lCUKQ== X-Received: by 2002:ac8:3616:: with SMTP id m22mr4472499qtb.15.1552074929118; Fri, 08 Mar 2019 11:55:29 -0800 (PST) Received: from ziepe.ca ([24.137.65.181]) by smtp.gmail.com with ESMTPSA id 14sm4786872qkf.23.2019.03.08.11.55.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 08 Mar 2019 11:55:23 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1h2LaU-0000uj-0L; Fri, 08 Mar 2019 15:55:22 -0400 From: Jason Gunthorpe To: linux-rdma@vger.kernel.org Cc: Jason Gunthorpe Subject: [PATCH ibdiags 00/14] Fix warnings in infiniband-diags Date: Fri, 8 Mar 2019 15:55:01 -0400 Message-Id: <20190308195515.3408-1-jgg@ziepe.ca> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Jason Gunthorpe When running on a higher warning level the compiler throws lots of interesting warnings out, fix a bunch of them. This brings infiniband-diags to a level where it build warning free with the same warnings flags that rdma-core uses by default on latest compilers. This is a github PR: https://github.com/linux-rdma/infiniband-diags/pull/21 Jason Gunthorpe (14): libibmad: Remove madrpc_def_timeout ibdiags: Remove unused functions ibdiags: Use const char when appropriate libibmad: Use {} instead of {0} ibdiags: Put the prototype for mlnx_ext_port_infor_err in a header ibdiags: Make functions used in only one file static ibdiag: Use modern C function declarations ibdiags: Use a static inline for the empty debug ibdiags: Remove unneeded prototype ibdiags: Remove parameters that are always passed as their global values ibdiags: Rename local variables to avoid shadow ibdiags/perfquery: Move many of the globals into a struct ibdiags/iblinkinfo: Move guid globals to a stuct ibdiags/ibtracert: Remove srcport parameter include/ibdiag_common.h | 10 +- libibmad/include/infiniband/mad.h | 2 +- libibmad/src/dump.c | 2 +- libibmad/src/fields.c | 96 +++--- libibmad/src/libibmad.map | 1 - libibmad/src/rpc.c | 5 - libibnetdisc/include/infiniband/ibnetdisc.h | 2 +- libibnetdisc/src/chassis.c | 11 +- libibnetdisc/src/ibnetdisc.c | 5 +- libibnetdisc/src/internal.h | 3 + libibnetdisc/src/query_smp.c | 3 - libibnetdisc/test/testleaks.c | 4 +- src/dump_fts.c | 88 +++--- src/ibcacheedit.c | 2 +- src/ibccconfig.c | 38 +-- src/ibccquery.c | 24 +- src/ibdiag_common.c | 41 ++- src/iblinkinfo.c | 59 ++-- src/ibnetdiscover.c | 70 +++-- src/ibping.c | 2 +- src/ibportstate.c | 13 +- src/ibqueryerrors.c | 39 +-- src/ibroute.c | 30 +- src/ibsendtrap.c | 6 +- src/ibstat.c | 14 +- src/ibsysstat.c | 2 +- src/ibtracert.c | 12 +- src/mcm_rereg_test.c | 16 +- src/perfquery.c | 317 +++++++++++--------- src/sminfo.c | 2 +- src/smpdump.c | 41 +-- src/smpquery.c | 38 +-- src/vendstat.c | 21 +- 33 files changed, 506 insertions(+), 513 deletions(-)