mbox series

[for-rc,0/2] Fixes for module unload

Message ID 20200623202519.106975.94246.stgit@awfm-01.aw.intel.com (mailing list archive)
Headers show
Series Fixes for module unload | expand

Message

Dennis Dalessandro June 23, 2020, 8:32 p.m. UTC
Two fixes for unload path. One is where the module use count got messed up in a
previous fix, we missed hitting these paths. I missed hitting these paths. The
other patch is going back to kfree for the dummy netdev. We are currently
re-working how this dummy netdev stuff works and will send a series for-next
soon.

---

Dennis Dalessandro (2):
      IB/hfi1: Restore kfree in dummy_netdev cleanup
      IB/hfi1: Fix module use count flaw due to leftover module put calls


 drivers/infiniband/hw/hfi1/debugfs.c   |   19 ++-----------------
 drivers/infiniband/hw/hfi1/netdev_rx.c |    2 +-
 2 files changed, 3 insertions(+), 18 deletions(-)

--
-Denny

Comments

Jason Gunthorpe June 24, 2020, 7:01 p.m. UTC | #1
On Tue, Jun 23, 2020 at 04:32:18PM -0400, Dennis Dalessandro wrote:
> Two fixes for unload path. One is where the module use count got messed up in a
> previous fix, we missed hitting these paths. I missed hitting these paths. The
> other patch is going back to kfree for the dummy netdev. We are currently
> re-working how this dummy netdev stuff works and will send a series for-next
> soon.
> 
> Dennis Dalessandro (2):
>       IB/hfi1: Restore kfree in dummy_netdev cleanup
>       IB/hfi1: Fix module use count flaw due to leftover module put calls

I fixed the bogus Fixes line, please be more carefull

Applied to for-rc

Thanks,
Jason
Dennis Dalessandro June 25, 2020, 11:46 a.m. UTC | #2
On 6/24/2020 3:01 PM, Jason Gunthorpe wrote:
> On Tue, Jun 23, 2020 at 04:32:18PM -0400, Dennis Dalessandro wrote:
>> Two fixes for unload path. One is where the module use count got messed up in a
>> previous fix, we missed hitting these paths. I missed hitting these paths. The
>> other patch is going back to kfree for the dummy netdev. We are currently
>> re-working how this dummy netdev stuff works and will send a series for-next
>> soon.
>>
>> Dennis Dalessandro (2):
>>        IB/hfi1: Restore kfree in dummy_netdev cleanup
>>        IB/hfi1: Fix module use count flaw due to leftover module put calls
> 
> I fixed the bogus Fixes line, please be more carefull
> 
> Applied to for-rc
>

Ah, I see the bug in my presubmit checks script. Will catch it next time.

-Denny