From patchwork Tue Aug 2 12:09:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias May X-Patchwork-Id: 12934584 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04403C00140 for ; Tue, 2 Aug 2022 12:13:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236750AbiHBMM4 (ORCPT ); Tue, 2 Aug 2022 08:12:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233232AbiHBMMz (ORCPT ); Tue, 2 Aug 2022 08:12:55 -0400 Received: from mx07-0057a101.pphosted.com (mx07-0057a101.pphosted.com [205.220.184.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4C552871E; Tue, 2 Aug 2022 05:12:53 -0700 (PDT) Received: from pps.filterd (m0214197.ppops.net [127.0.0.1]) by mx07-0057a101.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 272Bru3x021377; Tue, 2 Aug 2022 14:09:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=westermo.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=12052020; bh=yiYWJq9F9uZdrFhn759TuJd0/YpGKCmVgaHHZh39HmI=; b=lUxQfIFyvIEw4LBm8jkD7UcA9naHvi2jLabSt5SuW3mSYC5J3tJF34XDPmTGNXumBfBR 0Aheb1bo3w+I9L2hz7v+wjNry2VQZmm1x7b+38s1eWN+mkc6cJyFy+xBtoXDURbtMNnz kUZVeKa4RwrdOGY4IFckZLDm13egDoTRxA70fcKfjXKUi42AiAwoFDEJYqrU55ru16/7 9jB8pjlQxptNqICZ+C/Wd4Wvz3wtywSsxLpxK7lwHilSAKWtBwuxeonBUVyGTor+fe+R 7y98idRxdUXD/hyjDcygC8Sh12xInivphCV4cYvLD+m7HJ9KYnJnq90rritd491KjZtv 3g== Received: from mail.beijerelectronics.com ([195.67.87.131]) by mx07-0057a101.pphosted.com (PPS) with ESMTPS id 3hms0c2wbs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 02 Aug 2022 14:09:52 +0200 Received: from Orpheus.westermo.com (172.29.101.13) by EX01GLOBAL.beijerelectronics.com (10.101.10.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.2375.17; Tue, 2 Aug 2022 14:09:50 +0200 From: Matthias May To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Matthias May Subject: [PATCH v2 net 0/4] Do not use RT_TOS for IPv6 flowlabel Date: Tue, 2 Aug 2022 14:09:31 +0200 Message-ID: <20220802120935.1363001-1-matthias.may@westermo.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Originating-IP: [172.29.101.13] X-ClientProxiedBy: wsevst-s0023.westermo.com (192.168.130.120) To EX01GLOBAL.beijerelectronics.com (10.101.10.25) X-Proofpoint-GUID: U05Ks4GhqPAyaFLi6vew2kkis5G3PpGO X-Proofpoint-ORIG-GUID: U05Ks4GhqPAyaFLi6vew2kkis5G3PpGO Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org According to Guillaume Nault RT_TOS should never be used for IPv6. Quote: RT_TOS() is an old macro used to interprete IPv4 TOS as described in the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4 code, although, given the current state of the code, most of the existing calls have no consequence. But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS" field to be interpreted the RFC 1349 way. There's no historical compatibility to worry about. Acked-by: Guillaume Nault --- v1 -> v2: - Fix spacing of "Fixes" tag. - Add missing CCs Matthias May (4): geneve: do not use RT_TOS for IPv6 flowlabel vxlan: do not use RT_TOS for IPv6 flowlabel mlx5: do not use RT_TOS for IPv6 flowlabel ipv6: do not use RT_TOS for IPv6 flowlabel drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 4 ++-- drivers/net/geneve.c | 3 +-- drivers/net/vxlan/vxlan_core.c | 2 +- net/ipv6/ip6_output.c | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-)