From patchwork Fri Aug 5 19:19:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthias May X-Patchwork-Id: 12937660 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE3E0C25B08 for ; Fri, 5 Aug 2022 19:24:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241361AbiHETYD (ORCPT ); Fri, 5 Aug 2022 15:24:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231262AbiHETYC (ORCPT ); Fri, 5 Aug 2022 15:24:02 -0400 Received: from mx07-0057a101.pphosted.com (mx07-0057a101.pphosted.com [205.220.184.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0457366132; Fri, 5 Aug 2022 12:24:00 -0700 (PDT) Received: from pps.filterd (m0214197.ppops.net [127.0.0.1]) by mx07-0057a101.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 275Iw8pF020710; Fri, 5 Aug 2022 21:20:08 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=westermo.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=12052020; bh=azXcdsLu4260lFD/yn5j/LkPyKGtpHhYWRtPGk/Sl68=; b=XHhpZyddNNuQrs27za74WwQGmy52oTf/pq0+JkAkSYjmZ6wRqRHAMXTw4O8dHNh9Wg9i Lubrqb1D8ZW0OeH/h3Gt2e9l9pQfrOACmhx3t3zuC352b8VBsDFB5I//CUQ5VSSoPDG8 wbpFHmkNgx6ww7fa1dqcYQuyOgMmwbWboahgM++pPW2gjZQYv6QGBDi/RoZWqgL1j38/ 0MOYiZ2B5Or7hNyjNuYbKz4ZCap10v8pI31M6j+QgrJ9ZNoXq+AS8GA6G0Wvs2vGpjQT fKBSYwq/RmrxHneZ2CKJdI4D2BBzlZwP3I0pqnY3xxFQ1UZ7kQZEHu6+DX6kiDzJay03 Pw== Received: from mail.beijerelectronics.com ([195.67.87.131]) by mx07-0057a101.pphosted.com (PPS) with ESMTPS id 3hr3tdsntg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 05 Aug 2022 21:20:08 +0200 Received: from Orpheus.nch.westermo.com (172.29.100.2) by EX01GLOBAL.beijerelectronics.com (10.101.10.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.2375.17; Fri, 5 Aug 2022 21:20:05 +0200 From: Matthias May To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Matthias May Subject: [PATCH v3 net 0/4] Do not use RT_TOS for IPv6 flowlabel Date: Fri, 5 Aug 2022 21:19:02 +0200 Message-ID: <20220805191906.9323-1-matthias.may@westermo.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Originating-IP: [172.29.100.2] X-ClientProxiedBy: wsevst-s0023.westermo.com (192.168.130.120) To EX01GLOBAL.beijerelectronics.com (10.101.10.25) X-Proofpoint-GUID: P-FzDb9V4CZpy967eeQjyxN_EOsIRN6q X-Proofpoint-ORIG-GUID: P-FzDb9V4CZpy967eeQjyxN_EOsIRN6q Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org According to Guillaume Nault RT_TOS should never be used for IPv6. Quote: RT_TOS() is an old macro used to interprete IPv4 TOS as described in the obsolete RFC 1349. It's conceptually wrong to use it even in IPv4 code, although, given the current state of the code, most of the existing calls have no consequence. But using RT_TOS() in IPv6 code is always a bug: IPv6 never had a "TOS" field to be interpreted the RFC 1349 way. There's no historical compatibility to worry about. --- v1 -> v2: - Fix spacing of "Fixes" tag. - Add missing CCs v2 -> v3: - Add the info from the cover to the actual patch message (Guillaume Nault) Matthias May (4): geneve: do not use RT_TOS for IPv6 flowlabel vxlan: do not use RT_TOS for IPv6 flowlabel mlx5: do not use RT_TOS for IPv6 flowlabel ipv6: do not use RT_TOS for IPv6 flowlabel drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c | 4 ++-- drivers/net/geneve.c | 3 +-- drivers/net/vxlan/vxlan_core.c | 2 +- net/ipv6/ip6_output.c | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-)