From patchwork Mon Oct 3 10:51:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 12997452 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4728C433FE for ; Mon, 3 Oct 2022 10:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229521AbiJCKwK (ORCPT ); Mon, 3 Oct 2022 06:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiJCKwJ (ORCPT ); Mon, 3 Oct 2022 06:52:09 -0400 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31E155302D for ; Mon, 3 Oct 2022 03:52:07 -0700 (PDT) Received: by mail-ej1-x62e.google.com with SMTP id hy2so21226162ejc.8 for ; Mon, 03 Oct 2022 03:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=GNCnYjkABRW8uKtxLeXkdIxb03UC8OqDbAQJ4XfhNiU=; b=XB4a5pVpNxqD4VsUUj5iFCW/ZcrGv8sZrwnKBWtMC7k2COIz6L0rkQNuIowi0lL1I5 Wpepd1a/Ms4sC3Fb2UOn1VTPy1ELTD5eE5K2DBDLQcMzcqYp1EixUIgVHwzioIkT5rBj wlpYP0cRP+dAWfy8JXVUs8G+QkGgfsI/JTIgJCD5pGfIfynNnekjTbORI8LaNxm/KUE2 ZlDroRDp2Wyu9k/4HS3g9tfVPwMhXZWqhRjUGrKnM5TfVaYJSZy1CXMKwQuwPtnC2yIj dxNl6bMsI+X/88I48KKuv1Jqj3cj3fkkZulrD0YYp3Kh52uuBSZOavSD6lsQ4c344iO5 GHOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=GNCnYjkABRW8uKtxLeXkdIxb03UC8OqDbAQJ4XfhNiU=; b=eTRK9yItsKdDxBzb18oBtsg1QpwdBgCvHQfxD3LGcwPZq7T/ASR/D2uwa1yl20aKcw HUujREO5ZUDxwE360J3FTk5k7r0tq5lEyFnkijRZswbgb7fmvOnYzeRT9XI59pXfgfZK 9xlotDmu+kg1/cPjkXKAQcx8QjXcGecWG/7BCnXDRu7Idr855OkEzSgVleF93wgJrS1T ISJ9PweATcJjN+nswxGLgmlQgqxwwm7DOelGFUa2Xk6qT7APYJs3XpOt8nrPbReYl5qy TEZV3elFxpFmMaXx9E4o1WgciGOFQorhXsxRh4h3+wGritykkSF8tdAg3hSj7izyFqVX qVlw== X-Gm-Message-State: ACrzQf1YFFl3DAgh/dtIJbldaULa+WaCDHI4Y9KLrHk2ogrGTt73knRz uAF0Z6VMbQB2MMK5B6VjudkUog== X-Google-Smtp-Source: AMsMyM60TmGie4JjbBqGnjxbrNuo90DG9zJnZJgtySo7EuyOIYaY9wILwus8yPajPkljQ19h/MBdIA== X-Received: by 2002:a17:907:3f8b:b0:783:2008:e562 with SMTP id hr11-20020a1709073f8b00b007832008e562mr14841367ejc.261.1664794325574; Mon, 03 Oct 2022 03:52:05 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id o4-20020a170906768400b0077826b92d99sm5333473ejm.12.2022.10.03.03.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Oct 2022 03:52:05 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, tariqt@nvidia.com, moshe@nvidia.com, saeedm@nvidia.com, linux-rdma@vger.kernel.org Subject: [patch net-next v2 00/13] net: fix netdev to devlink_port linkage and expose to user Date: Mon, 3 Oct 2022 12:51:51 +0200 Message-Id: <20221003105204.3315337-1-jiri@resnulli.us> X-Mailer: git-send-email 2.37.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Jiri Pirko Currently, the info about linkage from netdev to the related devlink_port instance is done using ndo_get_devlink_port(). This is not sufficient, as it is up to the driver to implement it and some of them don't do that. Also it leads to a lot of unnecessary boilerplate code in all the drivers. Instead of that, introduce a possibility for driver to expose this relationship by new SET_NETDEV_DEVLINK_PORT macro which stores it into dev->devlink_port. It is ensured by the driver init/fini flows that the devlink_port pointer does not change during the netdev lifetime. Devlink port is always registered before netdev register and unregistered after netdev unregister. Benefit from this linkage setup and remove explicit calls from driver to devlink_port_type_eth_set() and clear(). Many of the driver didn't use it correctly anyway. Let the devlink.c to track associated netdev events and adjust type and type pointer accordingly. Also use this events to to keep track on ifname change and remove RTNL lock taking from devlink_nl_port_fill(). Finally, remove the ndo_get_devlink_port() ndo which is no longer used and expose devlink_port handle as a new netdev netlink attribute to the user. That way, during the ifname->devlink_port lookup, userspace app does not have to dump whole devlink port list and instead it can just do a simple RTM_GETLINK query. --- v1->v2: - see patches 5 and 6 for changelogs Jiri Pirko (13): net: devlink: convert devlink port type-specific pointers to union net: devlink: move port_type_warn_schedule() call to __devlink_port_type_set() net: devlink: move port_type_netdev_checks() call to __devlink_port_type_set() net: devlink: take RTNL in port_fill() function only if it is not held net: devlink: track netdev with devlink_port assigned net: make drivers to use SET_NETDEV_DEVLINK_PORT to set devlink_port net: devlink: remove netdev arg from devlink_port_type_eth_set() net: devlink: remove net namespace check from devlink_nl_port_fill() net: devlink: store copy netdevice ifindex and ifname to allow port_fill() without RTNL held net: devlink: add not cleared type warning to port unregister net: devlink: use devlink_port pointer instead of ndo_get_devlink_port net: remove unused ndo_get_devlink_port net: expose devlink port over rtnetlink drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 +- .../freescale/dpaa2/dpaa2-eth-devlink.c | 11 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 + .../ethernet/fungible/funeth/funeth_main.c | 13 +- drivers/net/ethernet/intel/ice/ice_devlink.c | 14 +- drivers/net/ethernet/intel/ice/ice_main.c | 18 +- drivers/net/ethernet/intel/ice/ice_repr.c | 12 +- .../marvell/prestera/prestera_devlink.c | 17 -- .../marvell/prestera/prestera_devlink.h | 5 - .../ethernet/marvell/prestera/prestera_main.c | 5 +- .../net/ethernet/mellanox/mlx4/en_netdev.c | 9 +- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- .../ethernet/mellanox/mlx5/core/en/devlink.c | 17 -- .../ethernet/mellanox/mlx5/core/en/devlink.h | 2 - .../net/ethernet/mellanox/mlx5/core/en_main.c | 4 +- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 43 +--- drivers/net/ethernet/mellanox/mlxsw/core.c | 20 +- drivers/net/ethernet/mellanox/mlxsw/core.h | 7 +- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 17 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 16 +- drivers/net/ethernet/mscc/ocelot_net.c | 11 +- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 6 - drivers/net/ethernet/netronome/nfp/nfp_app.h | 2 - .../net/ethernet/netronome/nfp/nfp_devlink.c | 23 +- .../ethernet/netronome/nfp/nfp_net_common.c | 2 - .../net/ethernet/netronome/nfp/nfp_net_main.c | 11 +- .../net/ethernet/netronome/nfp/nfp_net_repr.c | 1 - drivers/net/ethernet/netronome/nfp/nfp_port.h | 2 - .../ethernet/pensando/ionic/ionic_devlink.c | 2 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 14 +- drivers/net/netdevsim/dev.c | 2 - drivers/net/netdevsim/netdev.c | 10 +- include/linux/netdevice.h | 24 +- include/net/devlink.h | 32 ++- include/uapi/linux/if_link.h | 2 + net/core/dev.c | 11 +- net/core/devlink.c | 205 +++++++++++++----- net/core/net-sysfs.c | 4 +- net/core/rtnetlink.c | 39 ++++ net/dsa/dsa2.c | 9 - net/dsa/slave.c | 9 +- net/ethtool/ioctl.c | 11 +- 42 files changed, 292 insertions(+), 387 deletions(-)