From patchwork Mon Oct 31 12:42:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 13025763 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55C10ECAAA1 for ; Mon, 31 Oct 2022 12:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231207AbiJaMmx (ORCPT ); Mon, 31 Oct 2022 08:42:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230073AbiJaMmw (ORCPT ); Mon, 31 Oct 2022 08:42:52 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EED5AF024 for ; Mon, 31 Oct 2022 05:42:50 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5so7059111wmo.1 for ; Mon, 31 Oct 2022 05:42:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=27jiGBRkKA9KVsu+9TEtFs5XoMhm35d52CGzAYnTh6g=; b=2CcpRxK5VuCTEhqsRyMrSF8VeFTgPBCMBvUXv+cEeNqZu05OHywqk5XzZ/rqCOLVIx fXl0QpsAavV296IbZUewLvQOuORrfPeT5nRhOzL5j6BpKMq3yUNqMhu9W4SM29ZOh2t1 CIU6GwOVlCbnoVqAjcLWTyzyk4nUhw8hx2FORyhhJ8JQI4gIJ+dXZLC3jiAjbzTpamY1 uKDeWS9qEp7fXKHmRFXSIWCDSEpP7Cffz99g2lJ10O+4oBgmj5OHCJxyve35S4u4B0Be PwtAqHOQg5aUr+6lEAnv2vCaaiu8io8N8vC9O8XPqoHdAU6l2NW1H1lIKZT6e/MsBsZ7 VGVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=27jiGBRkKA9KVsu+9TEtFs5XoMhm35d52CGzAYnTh6g=; b=stThNvULJavlN77lq/hczTlNwtU/IiJs3pLx0hX0/Qgn6vzwnFNv1AhuJaH+hqHXNq VR87biwEZgbBw4AXUm+jJVV3AYMgUaI2gISSHhxB58HYn3pYhU+buL/+wL3zj8StbF5X aO0TQ1v20Tx+jiMlhI9w8zDlFK26LX7dCBdtFz/QgFOMWQ2OEtVB2+MZQZcQTeSbaSeN 2x1uPx6P3hVv+T4QLo3JxWgJ+LgJPP4GAs04IrWKAZZw7oww14m4HcIsYvafSAZsBNUb uVLe54lfZl7xvsc1XsLcsk2YA1HUjMyKgAkB8B1FHkcQjFs+n7p85S3b5c10O/+gfwWs /Rpg== X-Gm-Message-State: ACrzQf21HoPyiJ/PCNTfnuvzqH7PX+niLF+2EdsKysWUj5spDhJbnzbV gQEmP2AHPJZwiyA29WpISpYUSQ== X-Google-Smtp-Source: AMsMyM6AvUfHo2kQiXs45niXwce4oPtw18jQpOxzOPA+wEiBUIoDMm54Fux4J+weugaLkwkcyMKV7A== X-Received: by 2002:a05:600c:a4c:b0:3b4:fc1b:81 with SMTP id c12-20020a05600c0a4c00b003b4fc1b0081mr7790068wmq.125.1667220169438; Mon, 31 Oct 2022 05:42:49 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id bd26-20020a05600c1f1a00b003c6b70a4d69sm7153511wmb.42.2022.10.31.05.42.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Oct 2022 05:42:48 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, tariqt@nvidia.com, moshe@nvidia.com, saeedm@nvidia.com, linux-rdma@vger.kernel.org Subject: [patch net-next v3 00/13] net: fix netdev to devlink_port linkage and expose to user Date: Mon, 31 Oct 2022 13:42:35 +0100 Message-Id: <20221031124248.484405-1-jiri@resnulli.us> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Jiri Pirko Currently, the info about linkage from netdev to the related devlink_port instance is done using ndo_get_devlink_port(). This is not sufficient, as it is up to the driver to implement it and some of them don't do that. Also it leads to a lot of unnecessary boilerplate code in all the drivers. Instead of that, introduce a possibility for driver to expose this relationship by new SET_NETDEV_DEVLINK_PORT macro which stores it into dev->devlink_port. It is ensured by the driver init/fini flows that the devlink_port pointer does not change during the netdev lifetime. Devlink port is always registered before netdev register and unregistered after netdev unregister. Benefit from this linkage setup and remove explicit calls from driver to devlink_port_type_eth_set() and clear(). Many of the driver didn't use it correctly anyway. Let the devlink.c to track associated netdev events and adjust type and type pointer accordingly. Also use this events to to keep track on ifname change and remove RTNL lock taking from devlink_nl_port_fill(). Finally, remove the ndo_get_devlink_port() ndo which is no longer used and expose devlink_port handle as a new netdev netlink attribute to the user. That way, during the ifname->devlink_port lookup, userspace app does not have to dump whole devlink port list and instead it can just do a simple RTM_GETLINK query. --- v2->v3: - see patch 6 for a changelog v1->v2: - see patches 5 and 6 for changelogs Jiri Pirko (13): net: devlink: convert devlink port type-specific pointers to union net: devlink: move port_type_warn_schedule() call to __devlink_port_type_set() net: devlink: move port_type_netdev_checks() call to __devlink_port_type_set() net: devlink: take RTNL in port_fill() function only if it is not held net: devlink: track netdev with devlink_port assigned net: make drivers to use SET_NETDEV_DEVLINK_PORT to set devlink_port net: devlink: remove netdev arg from devlink_port_type_eth_set() net: devlink: remove net namespace check from devlink_nl_port_fill() net: devlink: store copy netdevice ifindex and ifname to allow port_fill() without RTNL held net: devlink: add not cleared type warning to port unregister net: devlink: use devlink_port pointer instead of ndo_get_devlink_port net: remove unused ndo_get_devlink_port net: expose devlink port over rtnetlink drivers/net/ethernet/broadcom/bnxt/bnxt.c | 14 +- .../freescale/dpaa2/dpaa2-eth-devlink.c | 11 +- .../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 1 + .../ethernet/fungible/funeth/funeth_main.c | 13 +- drivers/net/ethernet/intel/ice/ice_devlink.c | 14 +- drivers/net/ethernet/intel/ice/ice_main.c | 18 +- drivers/net/ethernet/intel/ice/ice_repr.c | 12 +- .../marvell/prestera/prestera_devlink.c | 17 -- .../marvell/prestera/prestera_devlink.h | 5 - .../ethernet/marvell/prestera/prestera_main.c | 5 +- .../net/ethernet/mellanox/mlx4/en_netdev.c | 9 +- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- .../ethernet/mellanox/mlx5/core/en/devlink.c | 17 -- .../ethernet/mellanox/mlx5/core/en/devlink.h | 2 - .../net/ethernet/mellanox/mlx5/core/en_main.c | 4 +- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 43 +--- drivers/net/ethernet/mellanox/mlxsw/core.c | 20 +- drivers/net/ethernet/mellanox/mlxsw/core.h | 7 +- drivers/net/ethernet/mellanox/mlxsw/minimal.c | 17 +- .../net/ethernet/mellanox/mlxsw/spectrum.c | 16 +- drivers/net/ethernet/mscc/ocelot_net.c | 11 +- drivers/net/ethernet/mscc/ocelot_vsc7514.c | 9 - drivers/net/ethernet/netronome/nfp/nfp_app.h | 2 - .../net/ethernet/netronome/nfp/nfp_devlink.c | 23 +- .../ethernet/netronome/nfp/nfp_net_common.c | 2 - .../net/ethernet/netronome/nfp/nfp_net_main.c | 11 +- .../net/ethernet/netronome/nfp/nfp_net_repr.c | 1 - drivers/net/ethernet/netronome/nfp/nfp_port.h | 2 - .../ethernet/pensando/ionic/ionic_devlink.c | 2 +- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 14 +- drivers/net/netdevsim/dev.c | 2 - drivers/net/netdevsim/netdev.c | 10 +- include/linux/netdevice.h | 24 +- include/net/devlink.h | 32 ++- include/uapi/linux/if_link.h | 2 + net/core/dev.c | 11 +- net/core/devlink.c | 205 +++++++++++++----- net/core/net-sysfs.c | 4 +- net/core/rtnetlink.c | 39 ++++ net/dsa/dsa2.c | 9 - net/dsa/slave.c | 9 +- net/ethtool/ioctl.c | 11 +- 42 files changed, 292 insertions(+), 390 deletions(-)