From patchwork Fri Mar 14 10:10:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= X-Patchwork-Id: 14016588 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B90121F3BBF for ; Fri, 14 Mar 2025 10:12:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741947145; cv=none; b=gKajI9e1KmE3R3NuI5kOnkm5uW4aEHMV6j8VKkNJrFwdfwOe+Ge3f+IwfpWbFLXkFrxtVAZM3ntmbeICK7JN67NEp5pUei4S7DQvzblAa/t7YgELfAZnqPqVwYb3NXhvDNcWgmgeFcWEqi0chZ0i2isnuafBpILuzyu/lQWq04s= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741947145; c=relaxed/simple; bh=ZwQLt7Z4tHTJcWoA9ARFUEED+hl5/cCffTRlgZa7WQU=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=XwXLavqv4luhnC3d1pDjjzeUWVIuBcdV6aJn9M82rYWviR5CndlFOw1E7qSj860jwDRs67iNFSw19TBOenIS6KbSh4ajc0TGIc2ExR+cSFmkf2/VikgBpvjCs1X5oQa37VB4NY5zXFC4yZpNX9cpu/370ttzQOw1/16m11vNEKE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VpVCqqfF; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VpVCqqfF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741947141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=9gm2z62YPqNWN8yJwphL0g3OWPmFyfl9EtTC0QPQVIU=; b=VpVCqqfF73ZZSaIQJV5kFGtTMqdIhI+6uYvUmcMR+ergrLx4spkUJq2U12toySmInyr3pa /79e8MlIbpNVLy6t2ZXhEvEUfEPx3oRGDmXZWdQb9Xd3DY4e6MjFlg3P05kAqlKc2uwvlB 3ifkaJ6g2l7jiM2iV0ejN+Yu1bpr6WA= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-5pxcgVd6O92MqA4kMTjQ4Q-1; Fri, 14 Mar 2025 06:12:19 -0400 X-MC-Unique: 5pxcgVd6O92MqA4kMTjQ4Q-1 X-Mimecast-MFC-AGG-ID: 5pxcgVd6O92MqA4kMTjQ4Q_1741947138 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-54989998f1bso1007894e87.0 for ; Fri, 14 Mar 2025 03:12:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741947138; x=1742551938; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9gm2z62YPqNWN8yJwphL0g3OWPmFyfl9EtTC0QPQVIU=; b=U9kUX1mIe6TTpR8SMN7yr1PbyO417XJ2Db8IdAxO+wmck6M0ElxnGJss7Emtx80CTi lH/8Sd+lMfaLnfu7yLYoPQo8SQ5MnmC+16wLjh00DhUxZHTyzOTcSZCFXIuqR5aZdjPe a4dCSy643/B6Wpl5kZkLr/sqqnb+sGXgy2syv82cGoI6Nw4sqQ47fmiXHE9EUEolzicp tUcp4S1O++As4S8lscoUblPKjM3yZUv5AGh7vd/3yCqRRs1vdvv3Id0eZyQjFbN68oIQ 5MrVm6KX8YDyq3LKuroe9ZZQ12bh7YtM+GY4VtNu+LBZEpxPQ36og8TvGLdTHT+ZoSrA 8Hlw== X-Forwarded-Encrypted: i=1; AJvYcCW0W4kgSGFns9d4HtbHcnXqetW5RP0kaLTzEmmcYq1+dRApVTBc1LXGb95ozQS/WCcKk67Xvjdlpq44@vger.kernel.org X-Gm-Message-State: AOJu0Yy30UKd77foKaxQrDdQOnBjArDFf1JTr0pxn0h5lKY0oLXNn4Mg EXVsjp+w3qdm2tKJt1pX+Z5WJVN40k59c5TdkYUGS2Ew9n+WrVQYxvKVepPWUnQyhQ5+39dQsRl Jy+kSMftfEpch7Hs46JKblEhSe1c260tMDcxfvQ+YJU7d4Qei/+SCqcXyvI0= X-Gm-Gg: ASbGncvFji38vetXLexApq7yM2G9Tx+7E9bglhMeE+j5Fa8POvRhwEEQbrjK40Ugmvz s0Tc5yO6u7Up4UhERCMSBmcWycLlnp+HQqHzlxXQreYVVtXXC7uAJA3rQnKiW6YjL306+z71R6O eAj6o9UhqBJ8G1KF9Mb/bk5xSkRQGuKas/LH+IfT64w8qKp2RxGrrPRAo49B9v5JrRIQFyePZVZ Z65PO72riJY55jwWEb0eWEgtrwUZaz++MvxMNEduNpL4PEjEx8WjGhLne2AjFG2XMfv2o5BCJhf axJDlODPbTMO X-Received: by 2002:a05:6512:3ba4:b0:544:ca1:da41 with SMTP id 2adb3069b0e04-549c39897ddmr668067e87.44.1741947138260; Fri, 14 Mar 2025 03:12:18 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFQUWKDrZlzJOt8qlYePG63LB20pTY5b0FHQCM+E2JqpqZhwzuf+fAjF8sgxJkwHe+V2bVHLw== X-Received: by 2002:a05:6512:3ba4:b0:544:ca1:da41 with SMTP id 2adb3069b0e04-549c39897ddmr668037e87.44.1741947137761; Fri, 14 Mar 2025 03:12:17 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a0c:4d80:42:443::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-549ba7c11f7sm477629e87.84.2025.03.14.03.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 03:12:15 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 0737418FA92C; Fri, 14 Mar 2025 11:12:12 +0100 (CET) From: =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= Subject: [PATCH net-next 0/3] Fix late DMA unmap crash for page pool Date: Fri, 14 Mar 2025 11:10:18 +0100 Message-Id: <20250314-page-pool-track-dma-v1-0-c212e57a74c2@redhat.com> Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAIoA1GcC/x2MQQqDMBAAvyJ77sKa1R78ivSw6KpL2yQkQQLi3 xt6nIGZC7Im0wxTd0HS07IF36B/dLAc4ndFWxuDIzcS94RRmoshfLAkWd64fgWJ2fHAMjxJoZU x6Wb1f53Ba0GvtcDrvn+tpLJRbwAAAA== X-Change-ID: 20250310-page-pool-track-dma-0332343a460e To: "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Saeed Mahameed , Leon Romanovsky , Tariq Toukan , Andrew Lunn , Eric Dumazet , Paolo Abeni , Ilias Apalodimas , Simon Horman , Andrew Morton , Mina Almasry , Yonglong Liu , Yunsheng Lin , Pavel Begunkov , Matthew Wilcox Cc: netdev@vger.kernel.org, bpf@vger.kernel.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org, =?utf-8?q?Toke_H=C3=B8iland-J=C3=B8rgensen?= , Qiuling Ren , Yuying Ma X-Mailer: b4 0.14.2 This series fixes the late dma_unmap crash for page pool first reported by Yonglong Liu in [0]. It is an alternative approach to the one submitted by Yunsheng Lin, most recently in [1]. The first two commits are small refactors of the page pool code, in preparation of the main change in patch 3. See the commit message of patch 3 for the details. -Toke [0] https://lore.kernel.org/lkml/8067f204-1380-4d37-8ffd-007fc6f26738@kernel.org/T/ [1] https://lore.kernel.org/r/20250307092356.638242-1-linyunsheng@huawei.com Signed-off-by: Toke Høiland-Jørgensen Tested-by: Yonglong Liu --- Toke Høiland-Jørgensen (3): page_pool: Move pp_magic check into helper functions page_pool: Turn dma_sync and dma_sync_cpu fields into a bitmap page_pool: Track DMA-mapped pages and unmap them when destroying the pool drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 4 +- include/net/page_pool/helpers.h | 6 +- include/net/page_pool/types.h | 54 +++++++++++++++- mm/page_alloc.c | 9 +-- net/core/devmem.c | 3 +- net/core/netmem_priv.h | 33 +++++++++- net/core/page_pool.c | 81 ++++++++++++++++++++---- net/core/skbuff.c | 16 +---- net/core/xdp.c | 4 +- 9 files changed, 164 insertions(+), 46 deletions(-) --- base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe change-id: 20250310-page-pool-track-dma-0332343a460e