From patchwork Thu Sep 30 08:02:16 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leon Romanovsky X-Patchwork-Id: 12527657 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09BEFC433EF for ; Thu, 30 Sep 2021 08:04:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E7163610A4 for ; Thu, 30 Sep 2021 08:04:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349010AbhI3IGH (ORCPT ); Thu, 30 Sep 2021 04:06:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:60718 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348954AbhI3IEb (ORCPT ); Thu, 30 Sep 2021 04:04:31 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E239061555; Thu, 30 Sep 2021 08:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632988954; bh=TyRhh5K2Ce94vSMeWuR/PAsi56m6bDxsuSdtwtKOoB8=; h=From:To:Cc:Subject:Date:From; b=rgoNgIuWn6U/ny58nucBbqQ/alWU4y4gG3KncetgZy003mOg5SwInUziivQLUf1HQ oVowdM5+G3IY6sLo5zDuyIy/cLB4oz/wyIHBs2genC23dYAUbwcuHl9cG3xrPkEwNz D7uOkvm6KyC39/q2jIEZoiOD22KICUHcGKyDeTcuLcFUPz9sjcoPYL7tVpftlH+XxB gwyDR+udlfA0Gcv/b0NMqwvEuWrrc+OnqFjcMagBjtITJciWZcduc/36g12eiW8zBg adJk+MOZJf1BuNl/nyLezWOSXaohQtC5kPRRtljWUqg9aAqCuvzz2WAevV/POnMmR7 FCzbwFA8REu4w== From: Leon Romanovsky To: Doug Ledford , Jason Gunthorpe Cc: Leon Romanovsky , Aharon Landau , Dennis Dalessandro , Gal Pressman , Jakub Kicinski , linux-rdma@vger.kernel.org, Maor Gottlieb , Mark Zhang , Mike Marciniszyn , Mustafa Ismail , Naresh Kumar PBS , Neta Ostrovsky , netdev@vger.kernel.org, Potnuri Bharat Teja , Saeed Mahameed , Selvin Xavier , Shiraz Saleem , Yishai Hadas , Zhu Yanjun Subject: [PATCH rdma-next v2 00/13] Optional counter statistics support Date: Thu, 30 Sep 2021 11:02:16 +0300 Message-Id: X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Leon Romanovsky Change Log: v2: * Add rdma_free_hw_stats_struct() helper API (with a new patch) * In sysfs add a WARN_ON to check if optional stats are always at the end * Add a new nldev command to get the counter status * Improve nldev_stat_set_counter_dynamic_doit() by creating a target state bitmap v1: https://lore.kernel.org/all/cover.1631660727.git.leonro@nvidia.com * Add a descriptor structure to replace name in struct rdma_hw_stats; * Add a bitmap in struct rdma_hw_stats to indicate the enable/disable status of all counters; * Add a "flag" field in counter descriptor and define IB_STAT_FLAG_OPTIONAL flag; * add/remove_op_stat() are replaced by modify_op_stat(); * Use "set/unset" in command line and send full opcounters list through netlink, and send opcounter indexes instead of names; * Patches are re-ordered. v0: https://lore.kernel.org/all/20210818112428.209111-1-markzhang@nvidia.com ---------------------------------------------------------------------- Hi, This series from Neta and Aharon provides an extension to the rdma statistics tool that allows to set optional counters dynamically, using netlink. The idea of having optional counters is to provide to the users the ability to get statistics of counters that hurts performance. Once an optional counter was added, its statistics will be presented along with all the counters, using the show command. Binding objects to the optional counters is currently not supported, neither in auto mode nor in manual mode. To get the list of optional counters that are supported on this device, use "rdma statistic mode supported". To see which counters are currently enabled, use "rdma statistic mode". Examples: $ rdma statistic mode supported link rocep8s0f0/1 supported optional-counters cc_rx_ce_pkts,cc_rx_cnp_pkts,cc_tx_cnp_pkts link rocep8s0f1/1 supported optional-counters cc_rx_ce_pkts,cc_rx_cnp_pkts,cc_tx_cnp_pkts $ sudo rdma statistic set link rocep8s0f0/1 optional-counters cc_rx_ce_pkts,cc_rx_cnp_pkts $ rdma statistic mode link rocep8s0f0/1 link rocep8s0f0/1 optional-counters cc_rx_ce_pkts,cc_rx_cnp_pkts $ rdma statistic show link rocep8s0f0/1 link rocep8s0f0/1 rx_write_requests 0 rx_read_requests 0 rx_atomic_requests 0 out_of_buffer 0 out_of_sequence 0 duplicate_request 0 rnr_nak_retry_err 0 packet_seq_err 0 implied_nak_seq_err 0 local_ack_timeout_err 0 resp_local_length_error 0 resp_cqe_error 0 req_cqe_error 0 req_remote_invalid_request 0 req_remote_access_errors 0 resp_remote_access_errors 0 resp_cqe_flush_error 0 req_cqe_flush_error 0 roce_adp_retrans 0 roce_adp_retrans_to 0 roce_slow_restart 0 roce_slow_restart_cnps 0 roce_slow_restart_trans 0 rp_cnp_ignored 0 rp_cnp_handled 0 np_ecn_marked_roce_packets 0 np_cnp_sent 0 rx_icrc_encapsulated 0 cc_rx_ce_pkts 0 cc_rx_cnp_pkts 0 $ sudo rdma statistic set link rocep8s0f0/1 optional-counters cc_rx_ce_pkts $ rdma statistic mode link rocep8s0f0/1 link rocep8s0f0/1 optional-counters cc_rx_ce_pkts Thanks Aharon Landau (12): net/mlx5: Add ifc bits to support optional counters net/mlx5: Add priorities for counters in RDMA namespaces RDMA/counter: Add a descriptor in struct rdma_hw_stats RDMA/counter: Add an is_disabled field in struct rdma_hw_stats RDMA/counter: Add optional counter support RDMA/nldev: Add support to get status of all counters RDMA/nldev: Allow optional-counter status configuration through RDMA netlink RDMA/mlx5: Support optional counters in hw_stats initialization RDMA/mlx5: Add steering support in optional flow counters RDMA/mlx5: Add modify_op_stat() support RDMA/mlx5: Add optional counter support in get_hw_stats callback RDMA/nldev: Add support to get status of all counters Mark Zhang (1): RDMA/core: Add a helper API rdma_free_hw_stats_struct drivers/infiniband/core/counters.c | 38 +- drivers/infiniband/core/device.c | 1 + drivers/infiniband/core/nldev.c | 388 ++++++++++++++---- drivers/infiniband/core/sysfs.c | 52 ++- drivers/infiniband/core/verbs.c | 36 ++ drivers/infiniband/hw/bnxt_re/hw_counters.c | 137 +++---- drivers/infiniband/hw/cxgb4/provider.c | 22 +- drivers/infiniband/hw/efa/efa_verbs.c | 19 +- drivers/infiniband/hw/hfi1/verbs.c | 47 ++- drivers/infiniband/hw/irdma/verbs.c | 98 ++--- drivers/infiniband/hw/mlx4/main.c | 37 +- drivers/infiniband/hw/mlx4/mlx4_ib.h | 2 +- drivers/infiniband/hw/mlx5/counters.c | 280 +++++++++++-- drivers/infiniband/hw/mlx5/fs.c | 187 +++++++++ drivers/infiniband/hw/mlx5/mlx5_ib.h | 28 +- drivers/infiniband/sw/rxe/rxe_hw_counters.c | 42 +- .../net/ethernet/mellanox/mlx5/core/fs_core.c | 54 ++- include/linux/mlx5/device.h | 2 + include/linux/mlx5/fs.h | 2 + include/linux/mlx5/mlx5_ifc.h | 22 +- include/rdma/ib_hdrs.h | 1 + include/rdma/ib_verbs.h | 57 ++- include/rdma/rdma_counter.h | 2 + include/uapi/rdma/rdma_netlink.h | 5 + 24 files changed, 1199 insertions(+), 360 deletions(-)