| Message ID | 0b646f62e9272bc962a1ff6ff03ad9523b454dfe.1422553023.git.ydroneaud@opteya.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Thu, Jan 29, 2015 at 07:00:01PM +0100, Yann Droneaud wrote: > As only the requested fields are set and copied to userspace, > there's no need to clear the content of the response structure > beforehand. Agreed. Reviewed-By: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 29/01/2015 20:00, Yann Droneaud wrote: > As only the requested fields are set and copied to userspace, > there's no need to clear the content of the response structure > beforehand. Care must be taken to zero out all the data that is copied to userspace, but I agree it can be done only to the parts that are unsupported as this patch does. Reviewed-by: Haggai Eran <haggaie@mellanox.com> > Link: http://mid.gmane.org/cover.1422553023.git.ydroneaud@opteya.com > Cc: Sagi Grimberg <sagig@mellanox.com> > Cc: Shachar Raindel <raindel@mellanox.com> > Cc: Eli Cohen <eli@mellanox.com> > Cc: Haggai Eran <haggaie@mellanox.com> > Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> > --- > drivers/infiniband/core/uverbs_cmd.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c > index 81d8b5aa2eb6..9520880a163f 100644 > --- a/drivers/infiniband/core/uverbs_cmd.c > +++ b/drivers/infiniband/core/uverbs_cmd.c > @@ -3328,9 +3328,9 @@ int ib_uverbs_ex_query_device(struct ib_uverbs_file *file, > if (err) > return err; > > - memset(&resp, 0, sizeof(resp)); > copy_query_dev_fields(file, &resp.base, &attr); > resp.comp_mask = 0; > + resp.reserved = 0; > > if (ucore->outlen < resp_len + sizeof(resp.odp_caps)) > goto end; > @@ -3343,6 +3343,9 @@ int ib_uverbs_ex_query_device(struct ib_uverbs_file *file, > attr.odp_caps.per_transport_caps.uc_odp_caps; > resp.odp_caps.per_transport_caps.ud_odp_caps = > attr.odp_caps.per_transport_caps.ud_odp_caps; > + resp.odp_caps.reserved = 0; > +#else > + memset(&resp.odp_caps, 0, sizeof(resp.odp_caps)); > #endif > resp.comp_mask |= IB_USER_VERBS_EX_QUERY_DEVICE_ODP; > resp_len += sizeof(resp.odp_caps); > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/infiniband/core/uverbs_cmd.c b/drivers/infiniband/core/uverbs_cmd.c index 81d8b5aa2eb6..9520880a163f 100644 --- a/drivers/infiniband/core/uverbs_cmd.c +++ b/drivers/infiniband/core/uverbs_cmd.c @@ -3328,9 +3328,9 @@ int ib_uverbs_ex_query_device(struct ib_uverbs_file *file, if (err) return err; - memset(&resp, 0, sizeof(resp)); copy_query_dev_fields(file, &resp.base, &attr); resp.comp_mask = 0; + resp.reserved = 0; if (ucore->outlen < resp_len + sizeof(resp.odp_caps)) goto end; @@ -3343,6 +3343,9 @@ int ib_uverbs_ex_query_device(struct ib_uverbs_file *file, attr.odp_caps.per_transport_caps.uc_odp_caps; resp.odp_caps.per_transport_caps.ud_odp_caps = attr.odp_caps.per_transport_caps.ud_odp_caps; + resp.odp_caps.reserved = 0; +#else + memset(&resp.odp_caps, 0, sizeof(resp.odp_caps)); #endif resp.comp_mask |= IB_USER_VERBS_EX_QUERY_DEVICE_ODP; resp_len += sizeof(resp.odp_caps);
As only the requested fields are set and copied to userspace, there's no need to clear the content of the response structure beforehand. Link: http://mid.gmane.org/cover.1422553023.git.ydroneaud@opteya.com Cc: Sagi Grimberg <sagig@mellanox.com> Cc: Shachar Raindel <raindel@mellanox.com> Cc: Eli Cohen <eli@mellanox.com> Cc: Haggai Eran <haggaie@mellanox.com> Signed-off-by: Yann Droneaud <ydroneaud@opteya.com> --- drivers/infiniband/core/uverbs_cmd.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)