From patchwork Thu Jan 9 22:47:39 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Upinder Malhi (umalhi)" X-Patchwork-Id: 3463621 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4453F9F3A0 for ; Thu, 9 Jan 2014 22:48:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 988E120103 for ; Thu, 9 Jan 2014 22:48:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 625612010E for ; Thu, 9 Jan 2014 22:48:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756522AbaAIWsi (ORCPT ); Thu, 9 Jan 2014 17:48:38 -0500 Received: from mtv-iport-4.cisco.com ([173.36.130.15]:51349 "EHLO mtv-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756236AbaAIWsB (ORCPT ); Thu, 9 Jan 2014 17:48:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=841; q=dns/txt; s=iport; t=1389307681; x=1390517281; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=24hHUDhGB2XRnWkxmb62s/v3N+xSwHfZCBXF+YP6/xA=; b=PPml5uCLrL2NSfJzym8UBQ9DRcEjHQVBWGnwsOz1VOpWCL1cCe95JyC4 2VZ/OmdKhCwQEa1/2E8AIGYsP9dp9tt8rzhCW5QG1KfBziGzcxfhttnmf Q8qMC5cV3YMOP5sS3EMcD99IWaVBA/iyNurIODT8i/NowByQpn4JacTPp o=; X-IronPort-AV: E=Sophos;i="4.95,634,1384300800"; d="scan'208";a="102455169" Received: from mtv-core-1.cisco.com ([171.68.58.6]) by mtv-iport-4.cisco.com with ESMTP; 09 Jan 2014 22:47:57 +0000 Received: from sjc-savbu-bld03.cisco.com (sjc-savbu-bld03.cisco.com [171.71.188.58]) by mtv-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id s09Mlv9r030671; Thu, 9 Jan 2014 22:47:57 GMT Received: by sjc-savbu-bld03.cisco.com (Postfix, from userid 246720) id 3B9CB3F7CE; Thu, 9 Jan 2014 14:47:57 -0800 (PST) From: Upinder Malhi To: linux-rdma@vger.kernel.org, roland@kernel.org Cc: Upinder Malhi Subject: [PATCH v1 for-next 11/15] IB/usnic: Remove extraneous if check Date: Thu, 9 Jan 2014 14:47:39 -0800 Message-Id: <1389307663-11296-12-git-send-email-umalhi@cisco.com> X-Mailer: git-send-email 1.8.0-rc0 In-Reply-To: <1389307663-11296-1-git-send-email-umalhi@cisco.com> References: <1389307663-11296-1-git-send-email-umalhi@cisco.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_DEF_DKIM_WL autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Remove extraneous if (chunk->cnt) condition. The code will not go into the next for loop if chunk->cnt is 0. Signed-off-by: Upinder Malhi --- drivers/infiniband/hw/usnic/usnic_vnic.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_vnic.c b/drivers/infiniband/hw/usnic/usnic_vnic.c index 5a50acb..74e4e5b 100644 --- a/drivers/infiniband/hw/usnic/usnic_vnic.c +++ b/drivers/infiniband/hw/usnic/usnic_vnic.c @@ -102,8 +102,6 @@ int usnic_vnic_dump(struct usnic_vnic *vnic, char *buf, spin_lock(&vnic->res_lock); for (i = 0; i < ARRAY_SIZE(vnic->chunks); i++) { chunk = &vnic->chunks[i]; - if (chunk->cnt == 0) - continue; for (j = 0; j < chunk->cnt; j++) { res = chunk->res[j]; offset += scnprintf(buf + offset, buf_sz - offset,