From patchwork Thu Jan 9 22:47:43 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Upinder Malhi (umalhi)" X-Patchwork-Id: 3463641 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 05E9DC02DD for ; Thu, 9 Jan 2014 22:48:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 570C62010B for ; Thu, 9 Jan 2014 22:48:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98D5B20108 for ; Thu, 9 Jan 2014 22:48:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756163AbaAIWsl (ORCPT ); Thu, 9 Jan 2014 17:48:41 -0500 Received: from mtv-iport-3.cisco.com ([173.36.130.14]:51746 "EHLO mtv-iport-3.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756206AbaAIWr7 (ORCPT ); Thu, 9 Jan 2014 17:47:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=840; q=dns/txt; s=iport; t=1389307679; x=1390517279; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=Mq5uNP0NSbhkIVBXKsdmn1x74x+j4VRAUDFSD0d7Mu8=; b=bBvhXi9SVl98DXEqnJTIz894G0YhFXpIdzux3efQZScT09tYmzK0TOx1 JOPklDwJh5u6RPO01m3oL0ydmO31lGvAGpKgA2INvVNNcs0v14ozk4/KL AgeBb8xILAQV4syFv8plBoitgK0eCQlSj6l1BCyJSS50tyHMswS6rNLxN s=; X-IronPort-AV: E=Sophos;i="4.95,634,1384300800"; d="scan'208";a="99936706" Received: from mtv-core-4.cisco.com ([171.68.58.9]) by mtv-iport-3.cisco.com with ESMTP; 09 Jan 2014 22:47:57 +0000 Received: from sjc-savbu-bld03.cisco.com (sjc-savbu-bld03.cisco.com [171.71.188.58]) by mtv-core-4.cisco.com (8.14.5/8.14.5) with ESMTP id s09MlvFZ011681; Thu, 9 Jan 2014 22:47:57 GMT Received: by sjc-savbu-bld03.cisco.com (Postfix, from userid 246720) id 5C97E3F7E7; Thu, 9 Jan 2014 14:47:57 -0800 (PST) From: Upinder Malhi To: linux-rdma@vger.kernel.org, roland@kernel.org Cc: Upinder Malhi Subject: [PATCH v1 for-next 15/15] IB/usnic: Fix false log Date: Thu, 9 Jan 2014 14:47:43 -0800 Message-Id: <1389307663-11296-16-git-send-email-umalhi@cisco.com> X-Mailer: git-send-email 1.8.0-rc0 In-Reply-To: <1389307663-11296-1-git-send-email-umalhi@cisco.com> References: <1389307663-11296-1-git-send-email-umalhi@cisco.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_DEF_DKIM_WL autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP usNIC is falsing printing an error if usnic_ib_qp_grp_modify succeeds. Signed-off-by: Upinder Malhi --- drivers/infiniband/hw/usnic/usnic_ib_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_main.c b/drivers/infiniband/hw/usnic/usnic_ib_main.c index bbe614b..dc09c12 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_main.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_main.c @@ -115,7 +115,7 @@ static void usnic_ib_qp_grp_modify_active_to_err(struct usnic_ib_dev *us_ibdev) status = usnic_ib_qp_grp_modify(qp_grp, IB_QPS_ERR, NULL); - if (!status) { + if (status) { usnic_err("Failed to transistion qp grp %u from %s to %s\n", qp_grp->grp_id, usnic_ib_qp_grp_state_to_string