From patchwork Thu Jan 9 22:47:30 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Upinder Malhi (umalhi)" X-Patchwork-Id: 3463411 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 40AC2C02DC for ; Thu, 9 Jan 2014 22:48:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4294420103 for ; Thu, 9 Jan 2014 22:48:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58B6A20108 for ; Thu, 9 Jan 2014 22:48:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756104AbaAIWr6 (ORCPT ); Thu, 9 Jan 2014 17:47:58 -0500 Received: from mtv-iport-4.cisco.com ([173.36.130.15]:64839 "EHLO mtv-iport-4.cisco.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756070AbaAIWr5 (ORCPT ); Thu, 9 Jan 2014 17:47:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=2101; q=dns/txt; s=iport; t=1389307677; x=1390517277; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=AT7ZTDIatDk+iLlhJQOuaa4nqjd+FjxUjvlAxywl4Gc=; b=h0M13xPmOkogMSNckSWN7Gt4UiuSTi1mGADlUo//ngbmhuBxVqGoeOfR 6xVtvzlbQKBwqE2Ho5nyAER9jpF0UTHHf0WDjqZffB5155pAf9OPAPXIJ pUFLr1uouzLfMYkpB4eYqmNh+AUTyu90ptF62F9DC6r46mSxm8DQ04ZPL 8=; X-IronPort-AV: E=Sophos;i="4.95,634,1384300800"; d="scan'208";a="102455163" Received: from mtv-core-3.cisco.com ([171.68.58.8]) by mtv-iport-4.cisco.com with ESMTP; 09 Jan 2014 22:47:57 +0000 Received: from sjc-savbu-bld03.cisco.com (sjc-savbu-bld03.cisco.com [171.71.188.58]) by mtv-core-3.cisco.com (8.14.5/8.14.5) with ESMTP id s09MluVx017182; Thu, 9 Jan 2014 22:47:57 GMT Received: by sjc-savbu-bld03.cisco.com (Postfix, from userid 246720) id E429E3F58E; Thu, 9 Jan 2014 14:47:56 -0800 (PST) From: Upinder Malhi To: linux-rdma@vger.kernel.org, roland@kernel.org Cc: Upinder Malhi Subject: [PATCH v1 for-next 02/15] IB/usnic: Fix format not a string literal warning Date: Thu, 9 Jan 2014 14:47:30 -0800 Message-Id: <1389307663-11296-3-git-send-email-umalhi@cisco.com> X-Mailer: git-send-email 1.8.0-rc0 In-Reply-To: <1389307663-11296-1-git-send-email-umalhi@cisco.com> References: <1389307663-11296-1-git-send-email-umalhi@cisco.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-14.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_DEF_DKIM_WL autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP usNIC calls printk w/o string literal in some instances. Change these instances so the call is made with string literal. Signed-off-by: Upinder Malhi --- drivers/infiniband/hw/usnic/usnic_ib_main.c | 5 ++--- drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c | 2 +- drivers/infiniband/hw/usnic/usnic_vnic.c | 2 -- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_main.c b/drivers/infiniband/hw/usnic/usnic_ib_main.c index 1771eec..696e401 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_main.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_main.c @@ -75,7 +75,7 @@ void usnic_ib_log_vf(struct usnic_ib_vf *vf) { char buf[1000]; usnic_ib_dump_vf(vf, buf, sizeof(buf)); - usnic_dbg(buf); + usnic_dbg("%s\n", buf); } /* Start of netdev section */ @@ -372,8 +372,7 @@ static void usnic_ib_undiscover_pf(struct kref *kref) } } - if (!found) - WARN("Failed to remove PF %s\n", pci_name(dev)); + WARN(!found, "Failed to remove PF %s\n", pci_name(dev)); mutex_unlock(&usnic_ib_ibdev_list_lock); } diff --git a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c index 5ba8678..f647b6b 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_qp_grp.c @@ -432,7 +432,7 @@ static void log_spec(const struct usnic_vnic_res_spec { char buf[512]; usnic_vnic_spec_dump(buf, sizeof(buf), res_spec); - usnic_dbg(buf); + usnic_dbg("%s\n", buf); } struct usnic_ib_qp_grp *usnic_ib_qp_grp_create(struct usnic_fwd_dev *ufdev, diff --git a/drivers/infiniband/hw/usnic/usnic_vnic.c b/drivers/infiniband/hw/usnic/usnic_vnic.c index 11c2449..ff0b32d 100644 --- a/drivers/infiniband/hw/usnic/usnic_vnic.c +++ b/drivers/infiniband/hw/usnic/usnic_vnic.c @@ -182,8 +182,6 @@ int usnic_vnic_spec_dump(char *buf, int buf_sz, const struct usnic_vnic_res_spec res_cnt); } - offset += scnprintf(buf + offset, buf_sz - offset, - "\n"); return offset; }