From patchwork Tue Jan 14 15:45:14 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eli Cohen X-Patchwork-Id: 3486331 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 060BDC02DC for ; Tue, 14 Jan 2014 15:45:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 169182021A for ; Tue, 14 Jan 2014 15:45:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7030F20218 for ; Tue, 14 Jan 2014 15:45:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751632AbaANPpp (ORCPT ); Tue, 14 Jan 2014 10:45:45 -0500 Received: from mail-ee0-f50.google.com ([74.125.83.50]:51660 "EHLO mail-ee0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751597AbaANPpp (ORCPT ); Tue, 14 Jan 2014 10:45:45 -0500 Received: by mail-ee0-f50.google.com with SMTP id d17so314442eek.9 for ; Tue, 14 Jan 2014 07:45:44 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Brv4X/k+CfgvjnlpKyYwLbIDvcsWkDqAjB+F0z++5go=; b=exAiF6LAJwx+F8+onKdp30yPKrvbynujeqIl4n21rH0LHAMw7U5q5JE4vGKuvfDcoa XHVwabCSYRNTsqJuUkgkZheyBeNYvSRRoCG8TkCicb0N7TL3VGh4E4PSx/WHzCxT9DPC INM7QCLS81YSlI0Mi82RgSZuFSXbVf1QP75yRkfROzI3hWiAgnMhK55/SF/34VounCJ4 F4jYclb4VIEmXiOgCQF2xT2vt4RcLEWSO639bHW48fnABlXYnAjH99p6IxYHJHC5SLrr Wq41tsQLLBogRYtimsLXihrYE6rSdzqRWwUMPgLkW8Gn8fvnjeNWXYY80ON+c9KSI+TJ Uu6A== X-Gm-Message-State: ALoCoQmtc6vwBjBPHWT7KCQk1MXjMBKG7/bfiBs14QW/4FJGd7BHtE5zHiKiyHTNzWty1UDmgCqh X-Received: by 10.15.23.8 with SMTP id g8mr3099798eeu.72.1389714344063; Tue, 14 Jan 2014 07:45:44 -0800 (PST) Received: from localhost (out.voltaire.com. [193.47.165.251]) by mx.google.com with ESMTPSA id 4sm2616397eed.14.2014.01.14.07.45.43 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 14 Jan 2014 07:45:43 -0800 (PST) From: Eli Cohen To: roland@kernel.org Cc: linux-rdma@vger.kernel.org, davem@davemloft.net, ogerlitz@mellanox.com, Eli Cohen Subject: [PATCH for-next 05/14] IB/mlx5: Clear out struct before create QP command Date: Tue, 14 Jan 2014 17:45:14 +0200 Message-Id: <1389714323-20130-6-git-send-email-eli@mellanox.com> X-Mailer: git-send-email 1.8.5.2 In-Reply-To: <1389714323-20130-1-git-send-email-eli@mellanox.com> References: <1389714323-20130-1-git-send-email-eli@mellanox.com> Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Output structs are expected by firmware to be cleared when a command is called. Clear the "out" struct instead of "dout" which is used only later. Signed-off-by: Eli Cohen --- drivers/net/ethernet/mellanox/mlx5/core/qp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/qp.c b/drivers/net/ethernet/mellanox/mlx5/core/qp.c index 54faf8b..e794184 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/qp.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/qp.c @@ -74,7 +74,7 @@ int mlx5_core_create_qp(struct mlx5_core_dev *dev, struct mlx5_destroy_qp_mbox_out dout; int err; - memset(&dout, 0, sizeof(dout)); + memset(&out, 0, sizeof(out)); in->hdr.opcode = cpu_to_be16(MLX5_CMD_OP_CREATE_QP); err = mlx5_cmd_exec(dev, in, inlen, &out, sizeof(out));