| Message ID | 1415175783-4612-2-git-send-email-matanb@mellanox.com (mailing list archive) |
|---|---|
| State | Rejected |
| Headers | show |
diff --git a/include/infiniband/verbs.h b/include/infiniband/verbs.h index cfa1156..7276c40 100644 --- a/include/infiniband/verbs.h +++ b/include/infiniband/verbs.h @@ -881,7 +881,7 @@ struct ibv_context_ops { int (*dealloc_pd)(struct ibv_pd *pd); struct ibv_mr * (*reg_mr)(struct ibv_pd *pd, void *addr, size_t length, int access); - struct ibv_mr * (*rereg_mr)(struct ibv_mr *mr, + int (*rereg_mr)(struct ibv_mr *mr, int flags, struct ibv_pd *pd, void *addr, size_t length,
Currently, MR re-registration isn't implemented in libibverbs. The only part which does exist is an API call between libibverbs and the provider's library. Since there's no way for a user application to invoke this API call, it's safe to assume it's unused. Similarly to other verbs (for example, ibv_modify_qp), a modification to the MR shouldn't change the user's handle. The current existing API is: struct ibv_mr * (*rereg_mr)(struct ibv_mr *mr, int flags, struct ibv_pd *pd, void *addr, size_t length, int access); As a result, this API call returns the exact same pointer it gets. Instead, we propose retuning a status int, which is far more useful than the current return value. Signed-off-by: Matan Barak <matanb@mellanox.com> --- include/infiniband/verbs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)