| Message ID | 1419016100.20566.155.camel@auk59.llnl.gov (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Ira Weiny |
| Headers | show |
Any reason this should not be removed from mad_rpc_rmpp as well? Ira > -----Original Message----- > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > owner@vger.kernel.org] On Behalf Of Albert Chu > Sent: Friday, December 19, 2014 11:08 AM > To: linux-rdma@vger.kernel.org > Subject: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump > > When idebug == 1, mad_rpc outputs only the mad data response in debug > output. It does not output the request mad data. This is confusing since it's not > clear if it's request or response output. > > When idebug > 1, full mad send and receive buffers are output, which makes > the mad data output with idebug == 1 superfluous. Remove it to remove > confusion. > > Signed-off-by: Albert Chu <chu11@llnl.gov> > --- > src/rpc.c | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/src/rpc.c b/src/rpc.c > index 8d961f2..202fac5 100644 > --- a/src/rpc.c > +++ b/src/rpc.c > @@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port, > ib_rpc_t * rpc, > return NULL; > } > > - if (ibdebug) { > - IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz); > - xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc- > >datasz); > - } > - > if (rcvdata) > memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz); > > -- > 1.7.1 > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Just didn't hit the issue there so didn't think to remove it there a well. I'll repost Al On Fri, 2015-01-09 at 23:27 +0000, Weiny, Ira wrote: > Any reason this should not be removed from mad_rpc_rmpp as well? > > Ira > > > > -----Original Message----- > > From: linux-rdma-owner@vger.kernel.org [mailto:linux-rdma- > > owner@vger.kernel.org] On Behalf Of Albert Chu > > Sent: Friday, December 19, 2014 11:08 AM > > To: linux-rdma@vger.kernel.org > > Subject: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump > > > > When idebug == 1, mad_rpc outputs only the mad data response in debug > > output. It does not output the request mad data. This is confusing since it's not > > clear if it's request or response output. > > > > When idebug > 1, full mad send and receive buffers are output, which makes > > the mad data output with idebug == 1 superfluous. Remove it to remove > > confusion. > > > > Signed-off-by: Albert Chu <chu11@llnl.gov> > > --- > > src/rpc.c | 5 ----- > > 1 files changed, 0 insertions(+), 5 deletions(-) > > > > diff --git a/src/rpc.c b/src/rpc.c > > index 8d961f2..202fac5 100644 > > --- a/src/rpc.c > > +++ b/src/rpc.c > > @@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port, > > ib_rpc_t * rpc, > > return NULL; > > } > > > > - if (ibdebug) { > > - IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz); > > - xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc- > > >datasz); > > - } > > - > > if (rcvdata) > > memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz); > > > > -- > > 1.7.1 > > > > > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/src/rpc.c b/src/rpc.c index 8d961f2..202fac5 100644 --- a/src/rpc.c +++ b/src/rpc.c @@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port, ib_rpc_t * rpc, return NULL; } - if (ibdebug) { - IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz); - xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc->datasz); - } - if (rcvdata) memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz);
When idebug == 1, mad_rpc outputs only the mad data response in debug output. It does not output the request mad data. This is confusing since it's not clear if it's request or response output. When idebug > 1, full mad send and receive buffers are output, which makes the mad data output with idebug == 1 superfluous. Remove it to remove confusion. Signed-off-by: Albert Chu <chu11@llnl.gov> --- src/rpc.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-)