From patchwork Sat Jan 10 00:05:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Al Chu X-Patchwork-Id: 5603331 X-Patchwork-Delegate: ira.weiny@intel.com Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id DCAF29F1C5 for ; Sat, 10 Jan 2015 00:06:14 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 17A3D2061E for ; Sat, 10 Jan 2015 00:06:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 16827205DD for ; Sat, 10 Jan 2015 00:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751792AbbAJAGM (ORCPT ); Fri, 9 Jan 2015 19:06:12 -0500 Received: from prdiron-1.llnl.gov ([128.15.143.171]:22711 "EHLO prdiron-1.llnl.gov" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381AbbAJAGM (ORCPT ); Fri, 9 Jan 2015 19:06:12 -0500 X-Attachments: Received: from auk59.llnl.gov (HELO [134.9.93.24]) ([134.9.93.24]) by prdiron-1.llnl.gov with ESMTP; 09 Jan 2015 16:06:11 -0800 Subject: [PATCH] libibmad/src/rpc.c: Remove superfluous packet dump From: Albert Chu To: "Weiny, Ira" Cc: "linux-rdma@vger.kernel.org" In-Reply-To: <2807E5FD2F6FDA4886F6618EAC48510E0CBF09D5@CRSMSX101.amr.corp.intel.com> References: <1419016100.20566.155.camel@auk59.llnl.gov> <2807E5FD2F6FDA4886F6618EAC48510E0CBF09D5@CRSMSX101.amr.corp.intel.com> Date: Fri, 09 Jan 2015 16:05:59 -0800 Message-Id: <1420848359.21271.198.camel@auk59.llnl.gov> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-19.el5) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When idebug is >= 1, mad_rpc and mad_rpc_rmpp output only the mad data response in debug output. It does not output the request mad data. This is confusing since it's not clear if it's request or response output. When idebug > 1, full mad send and receive buffers are output, which makes the mad data output with idebug == 1 superfluous. Remove this output to remove confusion. Signed-off-by: Albert Chu --- src/rpc.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/src/rpc.c b/src/rpc.c index 8d961f2..f286af7 100644 --- a/src/rpc.c +++ b/src/rpc.c @@ -272,11 +272,6 @@ void *mad_rpc(const struct ibmad_port *port, ib_rpc_t * rpc, return NULL; } - if (ibdebug) { - IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz); - xdump(stderr, "mad data\n", mad + rpc->dataoffs, rpc->datasz); - } - if (rcvdata) memcpy(rcvdata, mad + rpc->dataoffs, rpc->datasz); @@ -322,12 +317,6 @@ void *mad_rpc_rmpp(const struct ibmad_port *port, ib_rpc_t * rpc, return NULL; } - if (ibdebug) { - IBWARN("data offs %d sz %d", rpc->dataoffs, rpc->datasz); - xdump(stderr, "rmpp mad data\n", mad + rpc->dataoffs, - rpc->datasz); - } - if (rmpp) { rmpp->flags = mad_get_field(mad, 0, IB_SA_RMPP_FLAGS_F); if ((rmpp->flags & 0x3) &&