From patchwork Thu Feb 5 23:32:58 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rasmus Villemoes X-Patchwork-Id: 5787551 Return-Path: X-Original-To: patchwork-linux-rdma@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 57CAB9F2ED for ; Thu, 5 Feb 2015 23:33:21 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7DDFF20138 for ; Thu, 5 Feb 2015 23:33:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A894202AE for ; Thu, 5 Feb 2015 23:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751358AbbBEXdR (ORCPT ); Thu, 5 Feb 2015 18:33:17 -0500 Received: from mail-lb0-f170.google.com ([209.85.217.170]:55004 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699AbbBEXdR (ORCPT ); Thu, 5 Feb 2015 18:33:17 -0500 Received: by mail-lb0-f170.google.com with SMTP id w7so12925337lbi.1 for ; Thu, 05 Feb 2015 15:33:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; h=from:to:cc:subject:date:message-id; bh=rUa5TTDTJqSJr/ssYrP2GAX9tyJ8NRM9fTNOAbuyZdA=; b=TkW6KHNc4z606omx2Y/Zs1zz1upE3/vgUl2TRRpzt8vfgTxX6RBuoevXlyUj/O90qV Z5ErVpYnqDjcMk3CNf1XYjTfP0R3eRZz5F87R0QUNC1BXH/bwqwm5zgkXw1d2ZF81KUv 3wRHVBNUfmcGC7tcE3xyw4bbDcTyRuQ/0PiPw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=rUa5TTDTJqSJr/ssYrP2GAX9tyJ8NRM9fTNOAbuyZdA=; b=Zt5Yv3pidtNU0LjXC6BLPSNKWVlpuQhnGevesp/78XAZxpAjgoBtozwXcWIvUW1WgV 5vRzzz5vRMSL4qrwEESq57tZR0u8gQXWFvOpOrCJc0fpEso/xMZ86CG6jduHRywXrxGu fBdQ3BdFZdGRETr8tOg4j85ww5tOla8uSbwfTw8z00HwaFgfgheKySzZV06tqe6oqHdN s3yPJaJVDA5JzDuNLSQFXTNt2XVmBYB7eGSLisZHi3ndZD7W85PSPPVzzgMWRhWuYE1g zF7uAK/ix74M5Z45BniyL4a+lt7bT+SJ5bzTllQSiYipw3ZGkjGJiiMO/7IAFSaAbrCE kMQw== X-Gm-Message-State: ALoCoQmMBGzSkECerWrHZ/oirGv1LyAakAx6ECo9VGqASI9BC3cbfYjJMn7BfmL61AJx8m3g1/aL X-Received: by 10.152.9.170 with SMTP id a10mr452793lab.1.1423179195582; Thu, 05 Feb 2015 15:33:15 -0800 (PST) Received: from spencer.imf.au.dk ([130.225.20.51]) by mx.google.com with ESMTPSA id d8sm112398lah.15.2015.02.05.15.33.14 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Feb 2015 15:33:15 -0800 (PST) From: Rasmus Villemoes To: Steve Wise , Roland Dreier , Sean Hefty , Hal Rosenstock Cc: Rasmus Villemoes , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] infiniband: cxgb4: Fix some format strings Date: Fri, 6 Feb 2015 00:32:58 +0100 Message-Id: <1423179179-16847-1-git-send-email-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.1.3 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PDBG prepends MOD (which expands to "iw_cxgb4" ":") to the format string. So the KERN_INFO just ends up in the middle where it just garbles the output. At the same place, there's obviously no reason to add MOD explicitly. The two other are straight-forward fixes of KERN_ERR KERN_ERR, where the second will end up as garbage in the output. Signed-off-by: Rasmus Villemoes Acked-by: Steve Wise --- drivers/infiniband/hw/cxgb4/device.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c index eb5df4e62703..536356a8c58c 100644 --- a/drivers/infiniband/hw/cxgb4/device.c +++ b/drivers/infiniband/hw/cxgb4/device.c @@ -979,7 +979,7 @@ static struct c4iw_dev *c4iw_alloc(const struct cxgb4_lld_info *infop) } } - PDBG(KERN_INFO MOD "ocq memory: " + PDBG("ocq memory: " "hw_start 0x%x size %u mw_pa 0x%lx mw_kva %p\n", devp->rdev.lldi.vr->ocq.start, devp->rdev.lldi.vr->ocq.size, devp->rdev.oc_mw_pa, devp->rdev.oc_mw_kva); @@ -1368,7 +1368,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list) t4_sq_host_wq_pidx(&qp->wq), t4_sq_wq_size(&qp->wq)); if (ret) { - pr_err(KERN_ERR MOD "%s: Fatal error - " + pr_err(MOD "%s: Fatal error - " "DB overflow recovery failed - " "error syncing SQ qid %u\n", pci_name(ctx->lldi.pdev), qp->wq.sq.qid); @@ -1384,7 +1384,7 @@ static void recover_lost_dbs(struct uld_ctx *ctx, struct qp_list *qp_list) t4_rq_wq_size(&qp->wq)); if (ret) { - pr_err(KERN_ERR MOD "%s: Fatal error - " + pr_err(MOD "%s: Fatal error - " "DB overflow recovery failed - " "error syncing RQ qid %u\n", pci_name(ctx->lldi.pdev), qp->wq.rq.qid);